Skip Menu |
 

This queue is for tickets about the Syntax-Highlight-Engine-Simple-Perl CPAN distribution.

Report information
The Basics
Id: 110323
Status: resolved
Priority: 0/
Queue: Syntax-Highlight-Engine-Simple-Perl

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 0.02
  • 0.05
Fixed in: 0.06



Subject: perlcritic test fails
Download (untitled) / with headers
text/plain 121b
Download (untitled) / with headers
text/plain 714b
On 2015-12-14 00:13:01, SREZIC wrote: Show quoted text
> See subject. > > Statistical analysis: > http://analysis.cpantesters.org/solved?distv=Syntax-Highlight-Engine- > Simple-Perl-0.02
Please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester introduce errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, both of which cannot be predicted in advance. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
Download (untitled) / with headers
text/plain 960b
On 2015-12-14 03:13:01, SREZIC wrote: Show quoted text
> See subject. > > Statistical analysis: > http://analysis.cpantesters.org/solved?distv=Syntax-Highlight-Engine- > Simple-Perl-0.02
With 0.04 it still fails: ... # Failed test 'Test::Perl::Critic for "lib/Syntax/Highlight/Engine/Simple/Perl.pm"' # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line 104. # # Modules have to return a true value ("1;") at line 1, column 1. Use "1;" as the last statement of the module. (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 10, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 91, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 129, column 1. (no explanation). (Severity: 5) t/perlcritic.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests ...

This looks to be a historical accident where an author intended to move those tests, but ended up copying them instead.

These tests are nuked in this pending PR:

https://github.com/lab-measurement/Syntax-Highlight-Engine-Simple-Perl/pull/3


-- 
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )
 



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.