Skip Menu |
 

This queue is for tickets about the Religion-Bible-Regex-Config CPAN distribution.

Report information
The Basics
Id: 109202
Status: open
Priority: 0/
Queue: Religion-Bible-Regex-Config

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.61
Fixed in: (no value)



Subject: perlcritic test may fail
Download (untitled) / with headers
text/plain 606b
t/perlcritic.t fails, probably only if the OTRS Perl::Critic plugin is installed: # Failed test 'Test::Perl::Critic for "blib/lib/Religion/Bible/Regex/Config.pm"' # at /opt/perl-5.22.1-RC1/lib/site_perl/5.22.1/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 16, column 8. (no explanation). (Severity: 5) ... # Variable, subroutine, and package names have to be in CamelCase at line 96, column 12. (no explanation). (Severity: 5) t/perlcritic.t ....................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests
On 2015-11-19 23:03:15, SREZIC wrote: Show quoted text
> t/perlcritic.t fails, probably only if the OTRS Perl::Critic plugin is > installed: > > # Failed test 'Test::Perl::Critic for > "blib/lib/Religion/Bible/Regex/Config.pm"' > # at /opt/perl-5.22.1-RC1/lib/site_perl/5.22.1/Test/Perl/Critic.pm > line 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 16, column 8. (no explanation). (Severity: 5) > ... > # Variable, subroutine, and package names have to be in CamelCase at > line 96, column 12. (no explanation). (Severity: 5) > t/perlcritic.t ....................... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests
Please do not allow perlcritic tests to run for normal user installs. Since they run all critic policies that are installed on the user's machine, the outcome can be unpredictable, and they prevent installations unnecessarily. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.