Skip Menu |
 

This queue is for tickets about the JavaScript-Minifier-XS CPAN distribution.

Report information
The Basics
Id: 108682
Status: new
Priority: 0/
Queue: JavaScript-Minifier-XS

People
Owner: Nobody in particular
Requestors: dan [...] randomdan.homeip.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Bug in minification of functions containing only a copyright
Date: Tue, 10 Nov 2015 21:34:18 +0000
To: bug-JavaScript-Minifier-XS [...] rt.cpan.org
From: Dan Goodliffe <dan [...] randomdan.homeip.net>
Download (untitled) / with headers
text/plain 485b
Hi, I've stumbled into a case where JavaScript-Minifier-XS, whilst awesome, breaks the javascript. Given: function() { // keep copyright } Results in: function(){// keep copyright} I've tracked down problem and have attached a test case and patch to address it by checking the previous node's previous node isn't a line comment. There might be a better way... but this seems lightweight and simple. Kind regards Dan -- Dan Goodliffe dan@randomdan.homeip.net 07970 523693
Download patch
text/plain 946b

Message body is not shown because sender requested not to inline it.

Download copyright-only-function.js
application/javascript 29b

Message body not shown because it is not plain text.

Message body is not shown because sender requested not to inline it.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.