Skip Menu |
 

This queue is for tickets about the Carp CPAN distribution.

Report information
The Basics
Id: 108076
Status: resolved
Priority: 0/
Queue: Carp

People
Owner: Nobody in particular
Requestors: ribasushi [...] leporine.io
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.37_01
Fixed in: (no value)



Subject: Unused dependency in 1.37_01
Download (untitled) / with headers
text/plain 361b
When my patch fixing RT#97409 got applied to blead its Makefile.PL hunk[1] got modified, leaving the dependency on parent.pm. As it stands the dependency is pulled in without being used by anything in neither lib/ nor t/. See attached grep result. Cheers [1] https://github.com/ribasushi/p5_Carp_RT97409/commit/3a6c8707c#diff-5d3ba18294715d9415e9e732852bfec6
Subject: spurious_parent.txt
rabbit@Ahasver:~$ wget -qO- https://cpan.metacpan.org/authors/id/R/RJ/RJBS/Carp-1.37_01.tar.gz | gzip -dc | grep -aC2 parent "Test::More" => "0.47", "overload" => 0, "parent" => 0.217, "strict" => 0, "warnings" => 0, -- "Test::More" : "0.47", "overload" : "0", "parent" : "0.217", "strict" : "0", "warnings" : "0" -- Test::More: '0.47' overload: '0' parent: '0.217' strict: '0' warnings: '0' -- sub trusts { my $child = shift; my $parent = shift; my $cache = shift; my ( $known, $partial ) = get_status( $cache, $child ); # Figure out consequences until we have an answer while ( @$partial and not exists $known->{$parent} ) { my $anc = shift @$partial; next if exists $known->{$anc}; -- push @$partial, @$anc_partial; } return exists $known->{$parent}; }
Thanks, fixed in perl5.git 86b64cb -- rjbs


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.