Skip Menu |
 

This queue is for tickets about the DBIx-Class-Fixtures CPAN distribution.

Report information
The Basics
Id: 108017
Status: open
Priority: 0/
Queue: DBIx-Class-Fixtures

People
Owner: SKAUFMAN [...] cpan.org
Requestors: andy [...] andybev.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Table/column names are not always quoted during populate
Date: Wed, 28 Oct 2015 11:01:37 +0000
To: bug-DBIx-Class-Fixtures [...] rt.cpan.org
From: Andrew Beverley <andy [...] andybev.com>
Download (untitled) / with headers
text/plain 401b
There is some raw SQL towards the end of populate(), which doesn't quote table names or columns. This means that populating data fails when these elements are named such that they require quoting. The offending code is almost at the end of the populate subroutine in DBIx/Class/Fixtures.pm: $self->msg(my $sql = "SELECT setval('${sequence}', (SELECT max($column) FROM ${table}));"); Thanks, Andy
Download (untitled) / with headers
text/plain 646b
This has been addressed in the latest release: https://metacpan.org/release/SKAUFMAN/DBIx-Class-Fixtures-1.00103_3-TRIAL Please let me know if this fixes your issue. On Wed Oct 28 07:01:56 2015, abeverley wrote: Show quoted text
> There is some raw SQL towards the end of populate(), which doesn't quote > table names or columns. This means that populating data fails when these > elements are named such that they require quoting. > > The offending code is almost at the end of the populate subroutine in > DBIx/Class/Fixtures.pm: > > $self->msg(my $sql = "SELECT setval('${sequence}', (SELECT max($column) > FROM ${table}));"); > > Thanks, > > Andy >
Subject: Re: [rt.cpan.org #108017] Table/column names are not always quoted during populate
Date: Wed, 09 Dec 2015 18:19:35 +0000
To: bug-DBIx-Class-Fixtures [...] rt.cpan.org
From: Andrew Beverley <andy [...] andybev.com>
Download (untitled) / with headers
text/plain 156b
On Wed, 2015-12-09 at 09:45 -0500, Samuel Kaufman via RT wrote: Show quoted text
> Please let me know if this fixes your issue.
That works great, thanks for fixing. Andy


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.