Skip Menu |
 

This queue is for tickets about the TheSchwartz CPAN distribution.

Report information
The Basics
Id: 107997
Status: new
Priority: 0/
Queue: TheSchwartz

People
Owner: Nobody in particular
Requestors: adam.morton [...] pearson.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Non parameterized values in queries consuming Oracle cursors
Date: Mon, 26 Oct 2015 10:57:55 -0400
To: bug-TheSchwartz [...] rt.cpan.org
From: "Morton, Adam" <adam.morton [...] pearson.com>
Download (untitled) / with headers
text/plain 1.2k
Hi there-- I've started using TheSchwartz with an Oracle db, and quickly ran out of cursors. It seems that some queries were being specified with values directly in the SQL, not paramaterized. Oracle does not like this. Here's a patch against 1.12: 297,298c297,298 < run_after => \"<= $unixtime", < grabbed_until => \"<= $unixtime", --- Show quoted text
> run_after => { op => '<=', value => $unixtime}, > grabbed_until => { op => '<=', value => $unixtime},
357,358c357,358 < run_after => \"<= $unixtime", < grabbed_until => \"<= $unixtime", --- Show quoted text
> run_after => { op => '<=', value => $unixtime }, > grabbed_until => { op => '<=', value => $unixtime },
There may also be an issue with this query at line 427 but I'm not fluent enough with ObjectDriver to be sure that this will be a problem, or know exactly how to fix it. I'm guessing tha tthe last term in the grabbed_until array can become another op/value hashref? if ( $driver->update( $job, { grabbed_until => [ '-and', { op => '=', value => $old_grabbed_until}, \" <= $unixtime" ]}) < 1 )
Subject: Re: [rt.cpan.org #107997] AutoReply: Non parameterized values in queries consuming Oracle cursors
Date: Wed, 25 Nov 2015 11:41:50 -0500
To: bug-TheSchwartz [...] rt.cpan.org
From: "Morton, Adam" <adam.morton [...] pearson.com>
Download (untitled) / with headers
text/plain 172b
The line 427 update is also an issue and can be fixed with this patch: 448c431 < { op => '<=', value => $unixtime}, --- Show quoted text
> \" <= $unixtime"


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.