Skip Menu |
 

This queue is for tickets about the IO-Async CPAN distribution.

Report information
The Basics
Id: 107806
Status: resolved
Priority: 0/
Queue: IO-Async

People
Owner: Nobody in particular
Requestors: leonerd-cpan [...] leonerd.org.uk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.69



Subject: Listener 'acceptor' failures can disappear too easily
Download (untitled) / with headers
text/plain 170b
https://metacpan.org/source/PEVANS/IO-Async-0.68/lib/IO/Async/Listener.pm#L291 to 302 Any failure that isn't an "accept" category will be silently lost. -- Paul Evans
Partial fix. Needs some more thought re: on_accept_error -- Paul Evans
Subject: rt107806.patch
Download rt107806.patch
text/x-diff 614b
=== modified file 'lib/IO/Async/Listener.pm' --- lib/IO/Async/Listener.pm 2015-10-15 14:50:05 +0000 +++ lib/IO/Async/Listener.pm 2015-10-15 15:23:15 +0000 @@ -297,9 +297,9 @@ $self->invoke_error( "accept() failed - $dollarbang", accept => $socket, $dollarbang ); }); - # Caller is not going to keep hold of the Future, so we have to ensure it - # stays alive somehow - $self->adopt_future( $f->else( sub { Future->done } ) ); + # TODO: Consider if this wants a more fine-grained place to report + # non-accept() failures (such as SSL) to + $self->adopt_future( $f ); } sub _accept
Released -- Paul Evans


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.