Skip Menu |
 

This queue is for tickets about the Dist-Zilla-Plugin-Test-EOL CPAN distribution.

Report information
The Basics
Id: 107682
Status: open
Priority: 0/
Queue: Dist-Zilla-Plugin-Test-EOL

People
Owner: ether [...] cpan.org
Requestors: nigel.metheringham [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.17
Fixed in: (no value)



Subject: List of files checked by :TestFiles is too broad
Download (untitled) / with headers
text/plain 598b
The change to using Dist::Zilla's file finders to make a list of files to check means that within the test directory the :TestFiles finder causes any data files to be included whereas previously they would not have been (since previously the files within there would have been restricted to perl and pod files). In the case of the HTML::Formatter module this means that the source and sample data output files (text, html, RTF, postscript) files are included - which may well include files which fail the EOL tests. This can be worked around, but is an unexpected change in the test environment.
Download (untitled) / with headers
text/plain 541b
On 2015-10-10 08:57:38, NIGELM wrote: Show quoted text
> The change to using Dist::Zilla's file finders to make a list of files > to check means that within the test directory the :TestFiles finder > causes any data files to be included whereas previously they would not > have been (since previously the files within there would have been > restricted to perl and pod files).
I'll check what Test::EOL does internally when it isn't given an explicit list of files -- it was not the intention that there would be any change of behaviour in the default case.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.