Skip Menu |
 

This queue is for tickets about the Compress-Raw-Zlib CPAN distribution.

Report information
The Basics
Id: 107642
Status: resolved
Priority: 0/
Queue: Compress-Raw-Zlib

People
Owner: Nobody in particular
Requestors: JHI [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.069
Fixed in: 2.070



Subject: compilation warning from inflate.c
Download (untitled) / with headers
text/plain 236b
inflate.c:1487:9: warning: unused parameter 'subvert' [-Wunused-parameter] I'm afraid now the subvert is unused unless #ifdef INFLATE_ALLOW_INVALID_DISTANCE_TOOFAR_ARRR ... so it warns. Maybe add (void)subvert; to the #else branch?
Download (untitled) / with headers
text/plain 788b
On Thu Oct 08 19:23:37 2015, JHI wrote: Show quoted text
> inflate.c:1487:9: warning: unused parameter 'subvert' [-Wunused- > parameter] > > I'm afraid now the subvert is unused unless #ifdef > INFLATE_ALLOW_INVALID_DISTANCE_TOOFAR_ARRR ... so it warns. > > Maybe add > > (void)subvert; > > to the #else branch?
Thanks Jarkko do you get these warning for free if you build with a newish version of Perl and a newish version of gcc, or is there more going on? FYI, I've been running gcc 4.4 for a few years. Regarding the error, I don't see anything that addresses it in the zlib dev github. All the other changes you pinged me about are already in the zlib dev setup, so I wasn't risking incompatability by merging them into my source. Will see if I can get something added upstream. cheers Paul
Download (untitled) / with headers
text/plain 1.1k
Show quoted text
> Maybe add
> > > > (void)subvert; > > > > to the #else branch?
> > Thanks Jarkko > > do you get these warning for free if you build with a newish version > of Perl and a newish version of gcc, or is there more going on?
I would imagine so. I think at least a newish version of gcc or clang. A more newish Perl (5.22) might affect things by turning on more warnings for the extensions, but I think a more newish compiler might be enough. I think I was looking at the smoke reports at http://www.nntp.perl.org/group/perl.daily-build.reports/ -- take for example http://www.nntp.perl.org/group/perl.daily-build.reports/2015/10/msg183473.html which seems to be using g++ 4.9.1 or http://www.nntp.perl.org/group/perl.daily-build.reports/2015/10/msg183462.html which seems to be using clang 3.5.0. Show quoted text
> FYI, I've been running gcc 4.4 for a few years. > > Regarding the error, I don't see anything that addresses it in the > zlib dev github. All the other changes you pinged me about are already > in the zlib dev setup, so I wasn't risking incompatability by merging > them into my source. Will see if I can get something added upstream.
Download (untitled) / with headers
text/plain 1.8k
On Sat Oct 10 05:18:51 2015, PMQS wrote: Show quoted text
> On Thu Oct 08 19:23:37 2015, JHI wrote:
> > inflate.c:1487:9: warning: unused parameter 'subvert' [-Wunused- > > parameter] > > > > I'm afraid now the subvert is unused unless #ifdef > > INFLATE_ALLOW_INVALID_DISTANCE_TOOFAR_ARRR ... so it warns. > > > > Maybe add > > > > (void)subvert; > > > > to the #else branch?
> > Thanks Jarkko > > do you get these warning for free if you build with a newish version > of Perl and a newish version of gcc, or is there more going on? > > FYI, I've been running gcc 4.4 for a few years. > > Regarding the error, I don't see anything that addresses it in the > zlib dev github. All the other changes you pinged me about are already > in the zlib dev setup, so I wasn't risking incompatability by merging > them into my source. Will see if I can get something added upstream. > > cheers > Paul
I can confirm that this warning is still emitted when compiling perl 5 blead with clang. See, e.g., http://perl5.test-smoke.org/report/50360 where this is the only compiler warning emitted from clang on FreeBSD 10.3. Or this from a compilation on Linux with clang: ##### $ clang --version Ubuntu clang version 3.6.2-3ubuntu2 (tags/RELEASE_362/final) (based on LLVM 3.6.2) Target: x86_64-pc-linux-gnu Thread model: posix Summary of my perl5 (revision 5 version 25 subversion 6) configuration: Commit id: 91dca83e9396e920f65b4f093ac7f6e5250a2f43 Platform: osname=linux osvers=4.4.0-38-generic archname=x86_64-linux uname='linux zareason 4.4.0-38-generic #57-ubuntu smp tue sep 6 15:42:33 utc 2016 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Dusedevel -Dcc=clang' ... $ grep -n unused-parameter ~/learn/perl/p5p/clang.typescript 608:inflate.c:1487:9: warning: unused parameter 'subvert' [-Wunused-parameter] 654:DB_File.xs:563:66: warning: unused parameter 'locp' [-Wunused-parameter] #####
Download (untitled) / with headers
text/plain 405b
Show quoted text
> > I can confirm that this warning is still emitted when compiling perl 5 > blead with clang.
... Show quoted text
> > $ grep -n unused-parameter ~/learn/perl/p5p/clang.typescript > 608:inflate.c:1487:9: warning: unused parameter 'subvert' [-Wunused- > parameter] > 654:DB_File.xs:563:66: warning: unused parameter 'locp' [-Wunused- > parameter] > #####
Thanks. Fixes for both added to my development copies. Paul
Download (untitled) / with headers
text/plain 738b
On Mon Oct 10 17:49:30 2016, PMQS wrote: Show quoted text
>
> > > > I can confirm that this warning is still emitted when compiling perl 5 > > blead with clang.
> ...
> > > > $ grep -n unused-parameter ~/learn/perl/p5p/clang.typescript > > 608:inflate.c:1487:9: warning: unused parameter 'subvert' [-Wunused- > > parameter] > > 654:DB_File.xs:563:66: warning: unused parameter 'locp' [-Wunused- > > parameter] > > #####
> > Thanks. Fixes for both added to my development copies. > > Paul > >
Paul, Thanks for looking into this. Do you have an idea as to when a new version will be released to CPAN so that we can synch blead with that? (I'll need that to eliminate the warnings in my FreeBSD smoke test runs.) Thank you very much. Jim Keenan
Hey Jim, hope to get it released this week. Paul


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.