Skip Menu |
 

This queue is for tickets about the Net-Ident CPAN distribution.

Report information
The Basics
Id: 106932
Status: resolved
Priority: 0/
Queue: Net-Ident

People
Owner: Nobody in particular
Requestors: fsfs [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Net::Ident::_export_hooks() called too early
Date: Mon, 7 Sep 2015 16:04:55 +0200
To: bug-net-ident [...] rt.cpan.org
From: Florian Schlichting <fsfs [...] debian.org>
Download (untitled) / with headers
text/plain 645b
Hi, I'm forwarding Debian bug #320137 about a warning Net::Ident::_export_hooks() called too early to check prototype at /usr/share/perl5/Net/Ident.pm line 29. which is fixed in Debian for some time using the following patch: --- a/Ident.pm +++ b/Ident.pm @@ -24,7 +24,7 @@ ); # provide import magic -sub _export_hooks () { +sub _export_hooks { my ( $tag, $hook ); while ( ( $tag, $hook ) = each %EXPORT_HOOKS ) { my $hookname = "_export_hook_$tag"; # pseudo-function name See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=320137 for the full bug report. Regards, Florian Schlichting Debian Perl Team
Download (untitled) / with headers
text/plain 1003b
On 2015-09-07 10:05:10, fsfs@debian.org wrote: Show quoted text
> Hi, > > I'm forwarding Debian bug #320137 about a warning > > Net::Ident::_export_hooks() called too early to check prototype at > /usr/share/perl5/Net/Ident.pm line 29. > > which is fixed in Debian for some time using the following patch: > > --- a/Ident.pm > +++ b/Ident.pm > @@ -24,7 +24,7 @@ > ); > > # provide import magic > -sub _export_hooks () { > +sub _export_hooks { > my ( $tag, $hook ); > while ( ( $tag, $hook ) = each %EXPORT_HOOKS ) { > my $hookname = "_export_hook_$tag"; # pseudo-function name > > > See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=320137 for the > full bug report. > > Regards, > Florian Schlichting > Debian Perl Team
It seems that this bug was solved long ago with this commit, and thus a patch is not necessary anymore: commit 62cf65c04d7348ed9814b77efae6f2e1315fdf1f Author: Todd Rinaldo <toddr@cpan.org> Date: Thu Jun 10 23:20:44 2010 -0500 fix prototype bug
Subject: Re: [rt.cpan.org #106932] Net::Ident::_export_hooks() called too early
Date: Wed, 9 Sep 2015 13:16:31 +0200
To: Slaven_Rezic via RT <bug-Net-Ident [...] rt.cpan.org>
From: Florian Schlichting <fsfs [...] debian.org>
Download (untitled) / with headers
text/plain 522b
On Mon, Sep 07, 2015 at 01:15:38PM -0400, Slaven_Rezic via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=106932 > > > It seems that this bug was solved long ago with this commit, and thus a patch is not necessary anymore: > > commit 62cf65c04d7348ed9814b77efae6f2e1315fdf1f > Author: Todd Rinaldo <toddr@cpan.org> > Date: Thu Jun 10 23:20:44 2010 -0500 > > fix prototype bug
you're right, of course, I should have re-checked this before forwarding an ancient patch - sorry for the noise! Florian


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.