Skip Menu |
 

This queue is for tickets about the Module-Install-TestTarget CPAN distribution.

Report information
The Basics
Id: 106843
Status: open
Priority: 0/
Queue: Module-Install-TestTarget

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.19
Fixed in: (no value)

Attachments
Module-Install-TestTarget-0.19-Adapt-to-ExtUtils-MakeMaker-6.07.patch



Subject: Test fails with ExtUtils-MakeMaker-6.07
The t/default_make_test/with_extra_tests.t fails with ExtUtils-MakeMaker-6.07: PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/*/*.t # You have make command: make t/00_compile.t .......................... ok # Failed test 'overwrote test_dynamic' # at t/default_make_test/with_extra_tests.t line 9. # undef # doesn't match '(?^:-MFoo::Bar)' # Looks like you failed 1 test of 2. t/default_make_test/with_extra_tests.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests The ExtUtils::MakeMaker changed how to generated Makefile looks like: -test_dynamic :: pure_all +test_dynamic :: subdirs-test_dynamic $(FULLPERLRUN) "-MFoo::Bar" "-Iinc" "-MModule::Install::ExtraTests" "-e" "Module::Install::ExtraTests::__harness('Test::Harness', 1, 'xt/author', '', '', $(TEST_VERBOSE), '$(INST_LIB)', '$(INST_ARCHLIB)'); " $(TEST_FILES) Thus the regular expression expecting the pure_all cannot locate the command.
From: ppisar [...] redhat.com
Download (untitled) / with headers
text/plain 751b
Dne Čt 03.zář.2015 09:22:13, ppisar napsal(a): Show quoted text
> The t/default_make_test/with_extra_tests.t fails with ExtUtils- > MakeMaker-6.07: > > PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "- > MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, > 'blib/lib', 'blib/arch')" t/*.t t/*/*.t > # You have make command: make > t/00_compile.t .......................... ok > # Failed test 'overwrote test_dynamic' > # at t/default_make_test/with_extra_tests.t line 9. > # undef > # doesn't match '(?^:-MFoo::Bar)' > # Looks like you failed 1 test of 2. > t/default_make_test/with_extra_tests.t .. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/2 subtests >
Attached patch fixes it. -- Petr
Subject: Module-Install-TestTarget-0.19-Adapt-to-ExtUtils-MakeMaker-6.07.patch
From 65f0a251c081efa3cca725621f5a5c2ce545fdbf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Thu, 3 Sep 2015 15:31:55 +0200 Subject: [PATCH] Adapt to ExtUtils-MakeMaker-6.07 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ExtUtils-MakeMaker-6.07 changes format of generated Makefile, therefore a regular expression in t/Util.pm could not locate interested line and t/default_make_test/with_extra_tests.t test failed. This patch augemnts the regular expression to work with ExtUtils-MakeMaker-6.07 either. CPAN RT#106843 Signed-off-by: Petr Písař <ppisar@redhat.com> --- t/Util.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/Util.pm b/t/Util.pm index 2757f4f..70b5904 100644 --- a/t/Util.pm +++ b/t/Util.pm @@ -38,7 +38,7 @@ sub find_make_test_command { open my $fh, '<', 'Makefile' or die "Cannot open 'Makefile' for reading: $!"; my $regex = _regex(keys %$target); while (<$fh>) { - next unless /^ ($regex) \s+ :: \s+ (?:pure_all|$regex) /xms; + next unless /^ ($regex) \s+ :: \s+ (?:pure_all|$regex|subdirs-(?:$regex)) /xms; $commands->{$1} = scalar <$fh>; delete $target->{$1}; my @target = keys %$target; -- 2.4.3
Download (untitled) / with headers
text/plain 250b
On 2015-09-03 06:38:35, ppisar wrote: Show quoted text
> Dne Čt 03.zář.2015 09:22:13, ppisar napsal(a):
> > The t/default_make_test/with_extra_tests.t fails with ExtUtils- > > MakeMaker-6.07:
Do you perhaps mean ExtUtils-MakeMaker-7.06? 6.07 is ancient indeed :)
ppisar, as someone who's dabbled in EUMM, this looks like a sensible approach.
Subject: Re: [rt.cpan.org #106843] Test fails with ExtUtils-MakeMaker-6.07
Date: Fri, 4 Sep 2015 08:56:08 +0200
To: Karen Etheridge via RT <bug-Module-Install-TestTarget [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
Download (untitled) / with headers
text/plain 442b
On Thu, Sep 03, 2015 at 12:36:25PM -0400, Karen Etheridge via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=106843 > > > On 2015-09-03 06:38:35, ppisar wrote:
> > Dne Čt 03.zář.2015 09:22:13, ppisar napsal(a):
> > > The t/default_make_test/with_extra_tests.t fails with ExtUtils- > > > MakeMaker-6.07:
> > Do you perhaps mean ExtUtils-MakeMaker-7.06? 6.07 is ancient indeed :)
Of course 7.06. Sorry for my typo. -- Petr
Download (untitled)
application/pgp-signature 213b

Message body not shown because it is not plain text.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.