Skip Menu |
 

This queue is for tickets about the Test-Harness CPAN distribution.

Report information
The Basics
Id: 106616
Status: open
Priority: 0/
Queue: Test-Harness

People
Owner: Nobody in particular
Requestors: MITHALDU [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: TODO parsing still has some edge cases where it fails to recognize a TODO
Download (untitled) / with headers
text/plain 516b
The problematic output is generated by this code-line: is_deeply( [ $found->[0]->literal ], $expected, "$msg literal()" ); $msg typically contains perl code, which can contain anything. Some of its contents cause T::H to fail to recognize test failures marked as TODO. One example is a line like this: not ok 1896 - qw\#\\#\# literal() # TODO known bug Another example would be lines where $msg contains newlines, since the output is suddenly spread over multiple lines. Not sure if that *can* be resolved.
Download (untitled) / with headers
text/plain 883b
On Sat Aug 22 18:15:10 2015, MITHALDU wrote: Show quoted text
> The problematic output is generated by this code-line: > > is_deeply( [ $found->[0]->literal ], $expected, "$msg literal()" ); > > $msg typically contains perl code, which can contain anything. Some of > its contents cause T::H to fail to recognize test failures marked as > TODO. > > One example is a line like this: > > not ok 1896 - qw\#\\#\# literal() # TODO known bug
IMO that's a bug in Test::Builder, not in TAP::Harness. «qw\#\\#\#» should have been «qw\#\\\#\#»; it should escape not just the '#', but also the '\'; any other way is a path to insanity. Show quoted text
> Another example would be lines where $msg contains newlines, since the > output is suddenly spread over multiple lines. Not sure if that *can* > be resolved.
Outputting \n instead of an actual newline may be sensible, but doesn't have any precedent yet. Leon


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.