Skip Menu |
 

This queue is for tickets about the File-Path CPAN distribution.

Report information
The Basics
Id: 106296
Status: resolved
Priority: 0/
Queue: File-Path

People
Owner: Nobody in particular
Requestors: craigberry [...] mac.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: Some Path.t fixes for VMS plus other failures
Date: Fri, 07 Aug 2015 15:54:48 -0500
To: bugs-File-Path [...] rt.cpan.org
From: "Craig A. Berry" <craigberry [...] mac.com>
There were several new test failures when 2.11 came into blead. The attached fixes those. As I was testing this, I ran against current head from github and found that there are a bunch of additional failures in the verbose mode tests. These tests were exposed by the removal of the requirement for Test::Output so had probably never been run before on VMS. There are two basic problems I can see right off, detailed output below. In verbose mode, mkdir reports what it’s working on in Unix format on VMS, whereas the test has constructed expectations from catdir, which always returns a path in native format. In safe mode, rmtree reports "skipped" when it can’t remove a directory without changing permissions. The difference on VMS is that the default protection for directories does not allow deletion without explicitly changing protection, but the test assumes that directories can always be deleted without doing so. ok 96 # skip Mode of 0 means assume user defaults on VMS not ok 97 - mkpath verbose (old style 1) # Failed test 'mkpath verbose (old style 1)' # at t/Path.t line 487. # got: 'mkdir test-55c51426-437-17bae/output # mkdir test-55c51426-437-17bae/output/A/ # ' # expected: 'mkdir [.test-55c51426-437-17bae.output] # mkdir [.test-55c51426-437-17bae.output.A] # ' not ok 98 - mkpath verbose (old style 2) # Failed test 'mkpath verbose (old style 2)' # at t/Path.t line 492. # got: 'mkdir test-55c51426-437-17bae/output/B/ # ' # expected: 'mkdir [.test-55c51426-437-17bae.output.B] # ' not ok 99 - rmtree verbose (old style) # Failed test 'rmtree verbose (old style)' # at t/Path.t line 497. # got: 'skipped [.test-55c51426-437-17bae.output.A] # skipped [.test-55c51426-437-17bae.output.B] # ' # expected: 'rmdir [.test-55c51426-437-17bae.output.A] # rmdir [.test-55c51426-437-17bae.output.B] # ' not ok 100 - mkpath verbose (new style 1) # Failed test 'mkpath verbose (new style 1)' # at t/Path.t line 502. # got: '' # expected: 'mkdir [.test-55c51426-437-17bae.output.A] # ' not ok 101 - mkpath verbose (new style 2) # Failed test 'mkpath verbose (new style 2)' # at t/Path.t line 507. # got: '' # expected: 'mkdir [.test-55c51426-437-17bae.output.B] # ' not ok 102 - again: rmtree verbose (old style) # Failed test 'again: rmtree verbose (old style)' # at t/Path.t line 512. # got: 'skipped [.test-55c51426-437-17bae.output.A] # skipped [.test-55c51426-437-17bae.output.B] # ' # expected: 'rmdir [.test-55c51426-437-17bae.output.A] # rmdir [.test-55c51426-437-17bae.output.B] # ' not ok 103 - make_path verbose with final hashref # Failed test 'make_path verbose with final hashref' # at t/Path.t line 517. # got: '' # expected: 'mkdir [.test-55c51426-437-17bae.output.A] # mkdir [.test-55c51426-437-17bae.output.B] # ' ok 104 - remove_tree verbose with final hashref Show quoted text
________________________________________ Craig A. Berry mailto:craigberry@mac.com "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 397b
On Fri Aug 07 16:55:17 2015, craigberry@mac.com wrote: Show quoted text
> There were several new test failures when 2.11 came into blead. The > attached fixes those. >
HI Craig, thanks so much for this! Would you like to do a Github pull request on this? Or would you rather I just apply the patch? The reason I ask is I would prefer it to be a pull request, but if you're not up for it just let me know.
Subject: Re: [rt.cpan.org #106296] Some Path.t fixes for VMS plus other failures
Date: Fri, 07 Aug 2015 17:44:26 -0500
To: bug-File-Path [...] rt.cpan.org
From: "Craig A. Berry" <craigberry [...] mac.com>
Download (untitled) / with headers
text/plain 779b
Show quoted text
> On Aug 7, 2015, at 5:42 PM, Richard Elberger via RT <bug-File-Path@rt.cpan.org> wrote: > > <URL: https://rt.cpan.org/Ticket/Display.html?id=106296 > > > On Fri Aug 07 16:55:17 2015, craigberry@mac.com wrote:
>> There were several new test failures when 2.11 came into blead. The >> attached fixes those. >>
> > HI Craig, thanks so much for this! > > Would you like to do a Github pull request on this? Or would you rather I just apply the patch? The reason I ask is I would prefer it to be a pull request, but if you're not up for it just let me know.
Please apply the patch. Show quoted text
________________________________________ Craig A. Berry mailto:craigberry@mac.com "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
Download (untitled) / with headers
text/plain 279b
Show quoted text
> Please apply the patch.
Done. https://github.com/rpcme/File-Path/commit/2e9dc4a8db12b8a7f79dce9785c32378ce688c88 I will need to work it out with Jim if we can push a new release so it can be picked up. The impact is very limited so I won't cut a dev release for it just yet.
Subject: Re: [rt.cpan.org #106296] Resolved: Some Path.t fixes for VMS plus other failures
Date: Fri, 07 Aug 2015 18:33:13 -0500
To: bug-File-Path [...] rt.cpan.org
From: "Craig A. Berry" <craigberry [...] mac.com>
Download (untitled) / with headers
text/plain 706b
Show quoted text
> On Aug 7, 2015, at 5:57 PM, Richard Elberger via RT <bug-File-Path@rt.cpan.org> wrote: > > <URL: https://rt.cpan.org/Ticket/Display.html?id=106296 > > > According to our records, your request has been resolved. If you have any > further questions or concerns, please respond to this message.
Do note that the patch only addressed one set of test failures and not the set for which the test output was shown in the original ticket submission. I think the ticket should remain open until those can be addressed. Show quoted text
________________________________________ Craig A. Berry mailto:craigberry@mac.com "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
Download (untitled) / with headers
text/plain 408b
Show quoted text
> Do note that the patch only addressed one set of test failures and not > the set for which the test output was shown in the original ticket > submission. I think the ticket should remain open until those can be > addressed.
Please open another ticket or I can do so. It's better to have one issue for one ticket ... that's why mistakes like closing this ticket without touching all the points happens.
Download (untitled) / with headers
text/plain 241b
Show quoted text
> Do note that the patch only addressed one set of test failures and not > the set for which the test output was shown in the original ticket > submission. I think the ticket should remain open until those can be > addressed.
nm I will do


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.