Skip Menu |
 

This queue is for tickets about the HTTP-Message CPAN distribution.

Report information
The Basics
Id: 105924
Status: resolved
Priority: 0/
Queue: HTTP-Message

People
Owner: Nobody in particular
Requestors: NHORNE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 6.08
Fixed in: (no value)



Subject: if_modified_since calls time2str and dies
Download (untitled) / with headers
text/plain 1.1k
The documentation at http://search.cpan.org/~ether/HTTP-Message-6.08/lib/HTTP/Headers.pm does not specify the format of the argument to HTTP::Headers::if_modified_since. Reading the spec at http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html I assumed H::H::if_modified_since takes a date field. But H::H::if_modified_since has this code which dies in time2str because it's already a string: if (defined $time) { $self->_header($header, HTTP::Date::time2str($time)); } Here's my stack trace of the fault: 2015/07/17 14:43:27 TRACE> 0: bb-links.fcgi:103 main::__ANON__ - /home/hornenj/perlmods/share/perl/5.14.2/HTTP/Headers.pm:304 in function HTTP::Date::time2str 2015/07/17 14:43:27 TRACE> 0: bb-links.fcgi:103 main::__ANON__ - /home/hornenj/perlmods/share/perl/5.14.2/HTTP/Headers.pm:314 in function HTTP::Headers::_date_header 2015/07/17 14:43:27 TRACE> 0: bb-links.fcgi:103 main::__ANON__ - /home/hornenj/perlmods/share/perl/5.14.2/HTTP/Message.pm:644 in function HTTP::Headers::if_modified_since 2015/07/17 14:43:27 TRACE> 0: bb-links.fcgi:103 main::__ANON__ - bb-links.fcgi:2325 in function HTTP::Message::__ANON__
Subject: Re: [rt.cpan.org #105924] if_modified_since calls time2str and dies
Date: Fri, 17 Jul 2015 21:47:41 -0700
To: bug-HTTP-Message [...] rt.cpan.org
From: Karen Etheridge <ether [...] cpan.org>
Download (untitled) / with headers
text/plain 1.7k
Since it's dying in time2str, that would suggest it's expecting a value in machine time (seconds since epoch), surely? On Fri, Jul 17, 2015 at 4:20 PM, Nigel Horne via RT < bug-HTTP-Message@rt.cpan.org> wrote: Show quoted text
> Fri Jul 17 19:20:27 2015: Request 105924 was acted upon. > Transaction: Ticket created by NHORNE > Queue: HTTP-Message > Subject: if_modified_since calls time2str and dies > Broken in: 6.08 > Severity: Important > Owner: Nobody > Requestors: NHORNE@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105924 > > > > The documentation at > http://search.cpan.org/~ether/HTTP-Message-6.08/lib/HTTP/Headers.pm does > not specify the format of the argument to > HTTP::Headers::if_modified_since. Reading the spec at > http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html I assumed > H::H::if_modified_since takes a date field. But H::H::if_modified_since > has this code which dies in time2str because it's already a string: > > if (defined $time) { > $self->_header($header, HTTP::Date::time2str($time)); > } > > Here's my stack trace of the fault: > > 2015/07/17 14:43:27 TRACE> 0: bb-links.fcgi:103 main::__ANON__ - > /home/hornenj/perlmods/share/perl/5.14.2/HTTP/Headers.pm:304 in function > HTTP::Date::time2str > 2015/07/17 14:43:27 TRACE> 0: bb-links.fcgi:103 main::__ANON__ - > /home/hornenj/perlmods/share/perl/5.14.2/HTTP/Headers.pm:314 in function > HTTP::Headers::_date_header > 2015/07/17 14:43:27 TRACE> 0: bb-links.fcgi:103 main::__ANON__ - > /home/hornenj/perlmods/share/perl/5.14.2/HTTP/Message.pm:644 in function > HTTP::Headers::if_modified_since > 2015/07/17 14:43:27 TRACE> 0: bb-links.fcgi:103 main::__ANON__ - > bb-links.fcgi:2325 in function HTTP::Message::__ANON__ >


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.