Skip Menu |
 

This queue is for tickets about the psh CPAN distribution.

Report information
The Basics
Id: 105916
Status: new
Priority: 0/
Queue: psh

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.8.1
Fixed in: (no value)



Subject: Broken on 5.22 due to Can't use 'defined(@array)'
make --jobs=4 --load-average=1.0 test TEST_VERBOSE=0
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/locale.t ..... ok                                                     
t/bi_tieopt.t .. 1/?
Show quoted text
#   Failed test 'use Psh::Builtins::Tieopt;'
#   at t/bi_tieopt.t line 19.
#     Tried to use 'Psh::Builtins::Tieopt'.
#     Error:  Can't use 'defined(@array)' (Maybe you should just omit the defined()?) at /tmp/portage/app-shells-psh-1.8.1-r1/work/psh-1.8.1/blib/lib/Psh.pm line 370.
# Compilation failed in require at /tmp/portage/app-shells-psh-1.8.1-r1/work/psh-1.8.1/blib/lib/Psh/Builtins/Tieopt.pm line 3.
# Compilation failed in require at t/bi_tieopt.t line 19.
# BEGIN failed--compilation aborted at t/bi_tieopt.t line 19.

Show quoted text
#   Failed test 'use Psh::Options;'
#   at t/bi_tieopt.t line 20.
#     Tried to use 'Psh::Options'.
#     Error:  Attempt to reload Psh.pm aborted.
# Compilation failed in require at /tmp/portage/app-shells-psh-1.8.1-r1/work/psh-1.8.1/blib/lib/Psh/Options.pm line 3.
# Compilation failed in require at t/bi_tieopt.t line 20.
# BEGIN failed--compilation aborted at t/bi_tieopt.t line 20.
Can't locate object method "TIESCALAR" via package "Psh::Support::TiedOption::Scalar" at /tmp/portage/app-shells-psh-1.8.1-r1/work/psh-1.8.1/blib/lib/Psh/Builtins/Tieopt.pm
 line 138.
Show quoted text
# Looks like you failed 2 tests of 3.
# Looks like your test exited with 255 just after 3.
t/bi_tieopt.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/3 subtests

Test Summary Report
-------------------
t/bi_tieopt.t (Wstat: 65280 Tests: 3 Failed: 2)
  Failed tests:  2-3
  Non-zero exit status: 255
Files=2, Tests=5,  0 wallclock secs ( 0.07 usr  0.01 sys +  0.12 cusr  0.02 csys =  0.22 CPU)
Result: FAIL
Failed 1/2 test programs. 2/5 subtests failed.
Attached patch resolves issues for me.
Subject: psh.patch
Download psh.patch
text/x-diff 315b
--- a/psh-1.8.1/lib/Psh.pm 2007-07-21 16:40:44.000000000 +1200 +++ b/psh-1.8.1/lib/Psh.pm 2015-07-18 05:30:29.840928282 +1200 @@ -367,7 +367,7 @@ sub defined_and_nonempty { - if (!defined(@_)) { return 0; } + if (!@_) { return 0; } if (scalar(@_) == 0) { return 0; } if (scalar(@_) == 1) {


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.