Skip Menu |
 

This queue is for tickets about the SQL-Abstract CPAN distribution.

Report information
The Basics
Id: 105563
Status: open
Priority: 0/
Queue: SQL-Abstract

People
Owner: Nobody in particular
Requestors: webstrand [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: SQL::Abstract::Tree unrollable_ops_re stripping parenthesis from GROUP_CONCAT
Date: Mon, 29 Jun 2015 15:57:15 -0400
To: bug-SQL-Abstract [...] rt.cpan.org
From: Webstrand <webstrand [...] gmail.com>
Download (untitled) / with headers
text/plain 424b
Hello, In SQL::Abstract::Tree, it appears that unrollable_ops_re matches "ON", "HAVING", "WHERE" etc. anywhere in the function name rather than the complete function name. This causes _parenthesis_unroll to incorrectly strip the parenthesis from function calls such as GROUP_CONCAT, CONNECTION_ID, or where_string. This test case currently results in invalid SQL: $sqlat->unparse($sqlat->parse('select GROUP_CONCAT(a)'));
Download (untitled) / with headers
text/plain 392b
On Mon Jun 29 21:57:43 2015, webstrand@gmail.com wrote: Show quoted text
> Hello, > > In SQL::Abstract::Tree, it appears that unrollable_ops_re matches > "ON", "HAVING", "WHERE" etc. anywhere in the function name rather than > the complete function name.
Bah, indeed. Apologies for the moronic mistake, I don't know what I was thinking. I am going to try to get out a fixed release soon. Anyway - confirmed


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.