Skip Menu |
 

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 105510
Status: stalled
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: ribasushi [...] leporine.io
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Join pruner can be more aggressive when {rows} == 1
Date: Fri, 26 Jun 2015 18:50:17 +0200
To: bug-DBIx-Class [...] rt.cpan.org
From: Peter Rabbitson <ribasushi [...] cpan.org>
Download (untitled) / with headers
text/plain 456b
<ribasushi> https://github.com/dbsrgits/dbix-class/blob/current/blead/lib/DBIx/Class/Storage/DBIHacks.pm#L375-L384 <ribasushi> this should be NOOPed when $attrs->{rows} == 1 <ribasushi> oh also ! offset <ribasushi> you need to also check !$attrs->{software_limit} <ribasushi> as it will *not* apply the limit db-side then <ribasushi> note - this is a "20 seconds of thought" solution <ribasushi> I will need to test every limit dialect, make sure it dtrt
Download (untitled) / with headers
text/plain 169b
Permalink to the code in question: https://github.com/dbsrgits/dbix-class/blob/8bb3f339/lib/DBIx/Class/Storage/DBIHacks.pm#L375-L384 Also stalling, leaving for $maint+1


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.