Skip Menu |
 

This queue is for tickets about the GD CPAN distribution.

Report information
The Basics
Id: 105407
Status: resolved
Priority: 0/
Queue: GD

People
Owner: RURBAN [...] cpan.org
Requestors: hartzell [...] alerce.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.56
Fixed in: (no value)



Subject: GD.t/test7 fails on Red Hat Enterprise Linux Server release 6.6 (Santiago), perl-5.18.4
Download (untitled) / with headers
text/plain 3.4k
t/GD.t fails on test image 7. This blocks automated installations of the module. Walking through GD.t, it is failing on this line DB<1> main::compare_image(t/GD.t:74): return ! $data1->compare($data2) & GD_CMP_IMAGE(); `$data1->compare($data2)` returns 7, which is GD_CMP_IMAGE & GD_CMP_NUM_COLORS & GD_CMP_COLOR The palettes are fairly different. Here's the palette for $data1 (the image the test generates): ``` 0: rgb(255:255:255) 0xffffff 1: rgb( 0: 0: 0) 0x000000 2: rgb(255: 0: 0) 0xff0000 3: rgb( 0: 0:255) 0x0000ff 4: rgb(255:250:205) 0xfffacd 5: rgb(191:191:191) 0xbfbfbf 6: rgb(159:159:159) 0x9f9f9f 7: rgb( 31: 31: 31) 0x1f1f1f 8: rgb(223:223:223) 0xdfdfdf 9: rgb(127:127:127) 0x7f7f7f 10: rgb( 95: 95: 95) 0x5f5f5f 11: rgb( 63: 63: 63) 0x3f3f3f 12: rgb( 83: 83: 83) 0x535353 13: rgb( 79: 79: 79) 0x4f4f4f 14: rgb( 55: 55: 55) 0x373737 15: rgb(119:119:119) 0x777777 16: rgb(143:143:143) 0x8f8f8f 17: rgb(167:167:167) 0xa7a7a7 18: rgb(255:191:191) 0xffbfbf 19: rgb(255:159:159) 0xff9f9f 20: rgb(255:127:127) 0xff7f7f 21: rgb(255: 31: 31) 0xff1f1f 22: rgb(255: 95: 95) 0xff5f5f 23: rgb(255:223:223) 0xffdfdf 24: rgb(255: 63: 63) 0xff3f3f 25: rgb(255:111:111) 0xff6f6f 26: rgb(255: 55: 55) 0xff3737 27: rgb(255: 39: 39) 0xff2727 28: rgb(255:195:195) 0xffc3c3 29: rgb(255:119:119) 0xff7777 30: rgb(255: 83: 83) 0xff5353 31: rgb(255:139:139) 0xff8b8b 32: rgb(223:223:255) 0xdfdfff 33: rgb(159:159:255) 0x9f9fff 34: rgb(127:127:255) 0x7f7fff 35: rgb( 95: 95:255) 0x5f5fff 36: rgb( 63: 63:255) 0x3f3fff 37: rgb(191:191:255) 0xbfbfff 38: rgb( 31: 31:255) 0x1f1fff 39: rgb( 23: 23:255) 0x1717ff 40: rgb( 47: 47:255) 0x2f2fff 41: rgb(195:195:255) 0xc3c3ff 42: rgb(119:119:255) 0x7777ff 43: rgb(139:139:255) 0x8b8bff 44: rgb(167:167:255) 0xa7a7ff ``` and here is the palette for $data2, the known good image: ``` 0: rgb(255:255:255) 0xffffff 1: rgb( 0: 0: 0) 0x000000 2: rgb(255: 0: 0) 0xff0000 3: rgb( 0: 0:255) 0x0000ff 4: rgb(255:250:205) 0xfffacd 5: rgb( 95: 95: 95) 0x5f5f5f 6: rgb(191:191:191) 0xbfbfbf 7: rgb(223:223:223) 0xdfdfdf 8: rgb( 31: 31: 31) 0x1f1f1f 9: rgb( 63: 63: 63) 0x3f3f3f 10: rgb(127:127:127) 0x7f7f7f 11: rgb(159:159:159) 0x9f9f9f 12: rgb( 71: 71: 71) 0x474747 13: rgb( 47: 47: 47) 0x2f2f2f 14: rgb(111:111:111) 0x6f6f6f 15: rgb( 83: 83: 83) 0x535353 16: rgb(167:167:167) 0xa7a7a7 17: rgb(143:143:143) 0x8f8f8f 18: rgb(255: 63: 63) 0xff3f3f 19: rgb(255:127:127) 0xff7f7f 20: rgb(255:191:191) 0xffbfbf 21: rgb(255:159:159) 0xff9f9f 22: rgb(255: 31: 31) 0xff1f1f 23: rgb(255:223:223) 0xffdfdf 24: rgb(255: 95: 95) 0xff5f5f 25: rgb(255:167:167) 0xffa7a7 26: rgb(255: 83: 83) 0xff5353 27: rgb(255: 47: 47) 0xff2f2f 28: rgb(255: 19: 19) 0xff1313 29: rgb(255: 27: 27) 0xff1b1b 30: rgb(255: 99: 99) 0xff6363 31: rgb(255:119:119) 0xff7777 32: rgb(255: 79: 79) 0xff4f4f 33: rgb(255: 55: 55) 0xff3737 34: rgb(223:223:255) 0xdfdfff 35: rgb(159:159:255) 0x9f9fff 36: rgb(127:127:255) 0x7f7fff 37: rgb( 95: 95:255) 0x5f5fff 38: rgb( 63: 63:255) 0x3f3fff 39: rgb(191:191:255) 0xbfbfff 40: rgb( 31: 31:255) 0x1f1fff 41: rgb( 23: 23:255) 0x1717ff 42: rgb( 47: 47:255) 0x2f2fff 43: rgb(195:195:255) 0xc3c3ff 44: rgb(119:119:255) 0x7777ff 45: rgb(139:139:255) 0x8b8bff 46: rgb(167:167:255) 0xa7a7ff ``` The colors that the test explicitly specifies occupy the first 5 slots in both palettes, in the same order. Visually (dumping the images to using ->png and viewing in preview on a mac) the images appear the same. I can't tell if the colors in the other slots in the palette are used for anything (e.g. antialiasing or ...).
Download (untitled) / with headers
text/plain 234b
On 2015-06-22 14:36:58, HARTZELL wrote: Show quoted text
> t/GD.t fails on test image 7. This blocks automated installations of > the module.
The same test image comparison fails on Mac OS X El Capitan, perl518 and gd 2.1.1_3 (both from home-brew).
Download (untitled) / with headers
text/plain 439b
On 2016-05-19 17:57:46, SREZIC wrote: Show quoted text
> On 2015-06-22 14:36:58, HARTZELL wrote:
> > t/GD.t fails on test image 7. This blocks automated installations of > > the module.
> > The same test image comparison fails on Mac OS X El Capitan, perl518 > and gd 2.1.1_3 (both from home-brew).
This may happen also on FreeBSD systems. It could depend on the specific jpeg library installed --- I see the problem where jpeg-turbo-1.4.2 is installed.
Download (untitled) / with headers
text/plain 173b
Thanks. The palette is unstable between gd versions and used libraries, so I relaxed this failing test with RURBAN/GD-2.56_03.tar.gz and the upcoming 2.57 -- Reini Urban
Download (untitled) / with headers
text/plain 509b
On 2017-04-20 04:39:33, RURBAN wrote: Show quoted text
> Thanks. > > The palette is unstable between gd versions and used libraries, so > I relaxed this failing test with RURBAN/GD-2.56_03.tar.gz > and the upcoming 2.57 >
I still see failures with 2.56_03, on most of my systems (linux & freebsd): ... # Failed test 'image comparison test 7' # at t/GD.t line 249. # Looks like you failed 1 test of 11. t/GD.t ........ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/11 subtests ... It passes only on Mac OS X.
Subject: Re: [rt.cpan.org #105407] GD.t/test7 fails on Red Hat Enterprise Linux Server release 6.6 (Santiago), perl-5.18.4
Date: Thu, 20 Apr 2017 19:33:06 +0200
To: bug-GD [...] rt.cpan.org
From: Reini Urban <reini.urban [...] gmail.com>
Download (untitled) / with headers
text/plain 769b
Can you post the fails please? It can depend on many factors. Am 20.04.2017 19:17 schrieb "Slaven_Rezic via RT" <bug-GD@rt.cpan.org>: Show quoted text
> Queue: GD > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105407 > > > On 2017-04-20 04:39:33, RURBAN wrote:
> > Thanks. > > > > The palette is unstable between gd versions and used libraries, so > > I relaxed this failing test with RURBAN/GD-2.56_03.tar.gz > > and the upcoming 2.57 > >
> > I still see failures with 2.56_03, on most of my systems (linux & freebsd): > > ... > # Failed test 'image comparison test 7' > # at t/GD.t line 249. > # Looks like you failed 1 test of 11. > t/GD.t ........ > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/11 subtests > ... > > It passes only on Mac OS X. >
RT-Send-CC: reini.urban [...] gmail.com
Download (untitled) / with headers
text/plain 1.5k
The full test log of t/GD.t looks like this: $ perl5.18.4 -Mblib t/GD.t 1..11 ok 1 - use GD; ok 2 - use GD::Simple; # Testing using gd2 support. ok 3 - image comparison test 1 ok 4 - image comparison test 2 ok 5 - image comparison test 3 ok 6 - image comparison test 4 ok 7 - image comparison test 5 ok 8 - image comparison test 6 not ok 9 - image comparison test 7 # Failed test 'image comparison test 7' # at t/GD.t line 249. ok 10 - round trip gd ok 11 - round trip gd2 # Looks like you failed 1 test of 11. This is on a freebsd 10 system with libgd-2.2.3_1,1 installed. Same output on a debian/jessie system (libgd3 2.1.0-5+deb8u9) and debian/stretch (libgd3 2.2.4-2). All my fail reports are on their way to cpantesters. On 2017-04-20 13:33:25, reini.urban@gmail.com wrote: Show quoted text
> Can you post the fails please? It can depend on many factors. > > Am 20.04.2017 19:17 schrieb "Slaven_Rezic via RT" <bug- > GD@rt.cpan.org>: >
> > Queue: GD > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105407 > > > > > On 2017-04-20 04:39:33, RURBAN wrote:
> > > Thanks. > > > > > > The palette is unstable between gd versions and used libraries, so > > > I relaxed this failing test with RURBAN/GD-2.56_03.tar.gz > > > and the upcoming 2.57 > > >
> > > > I still see failures with 2.56_03, on most of my systems (linux & > > freebsd): > > > > ... > > # Failed test 'image comparison test 7' > > # at t/GD.t line 249. > > # Looks like you failed 1 test of 11. > > t/GD.t ........ > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/11 subtests > > ... > > > > It passes only on Mac OS X. > >
Subject: Re: [rt.cpan.org #105407] GD.t/test7 fails on Red Hat Enterprise Linux Server release 6.6 (Santiago), perl-5.18.4
Date: Thu, 20 Apr 2017 19:59:33 +0200
To: bug-GD [...] rt.cpan.org
From: Reini Urban <reini.urban [...] gmail.com>
Download (untitled) / with headers
text/plain 1.8k
Thanks, should be fixed with 2.57. Am 20.04.2017 19:58 schrieb "Slaven_Rezic via RT" <bug-GD@rt.cpan.org>: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=105407 > > > The full test log of t/GD.t looks like this: > > $ perl5.18.4 -Mblib t/GD.t > 1..11 > ok 1 - use GD; > ok 2 - use GD::Simple; > # Testing using gd2 support. > ok 3 - image comparison test 1 > ok 4 - image comparison test 2 > ok 5 - image comparison test 3 > ok 6 - image comparison test 4 > ok 7 - image comparison test 5 > ok 8 - image comparison test 6 > not ok 9 - image comparison test 7 > # Failed test 'image comparison test 7' > # at t/GD.t line 249. > ok 10 - round trip gd > ok 11 - round trip gd2 > # Looks like you failed 1 test of 11. > > This is on a freebsd 10 system with libgd-2.2.3_1,1 installed. > Same output on a debian/jessie system (libgd3 2.1.0-5+deb8u9) and > debian/stretch (libgd3 2.2.4-2). > > All my fail reports are on their way to cpantesters. > > > On 2017-04-20 13:33:25, reini.urban@gmail.com wrote:
> > Can you post the fails please? It can depend on many factors. > > > > Am 20.04.2017 19:17 schrieb "Slaven_Rezic via RT" <bug- > > GD@rt.cpan.org>: > >
> > > Queue: GD > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105407 > > > > > > > On 2017-04-20 04:39:33, RURBAN wrote:
> > > > Thanks. > > > > > > > > The palette is unstable between gd versions and used libraries, so > > > > I relaxed this failing test with RURBAN/GD-2.56_03.tar.gz > > > > and the upcoming 2.57 > > > >
> > > > > > I still see failures with 2.56_03, on most of my systems (linux & > > > freebsd): > > > > > > ... > > > # Failed test 'image comparison test 7' > > > # at t/GD.t line 249. > > > # Looks like you failed 1 test of 11. > > > t/GD.t ........ > > > Dubious, test returned 1 (wstat 256, 0x100) > > > Failed 1/11 subtests > > > ... > > > > > > It passes only on Mac OS X. > > >
> > > >
Download (untitled) / with headers
text/plain 107b
We don't compare excluding the palette yet, we just loosened this particular test in 2.57. -- Reini Urban


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.