Skip Menu |
 

This queue is for tickets about the Archive-Zip CPAN distribution.

Report information
The Basics
Id: 105330
Status: open
Priority: 0/
Queue: Archive-Zip

People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: broken test skip in 1.47
Date: Thu, 18 Jun 2015 14:46:42 +0100
To: bug-Archive-Zip [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 374b
Archive-Zip-1.47's t/22_deflated_dir.t has a skip() without the requisite SKIP block. If the skip is taken, the test script fails: Label not found for "last SKIP" at /opt/perl-5.20.2/lib/site_perl/5.20.2/Test/More.pm line 1314. # Looks like your test exited with 255 just after 4. t/22_deflated_dir.t ........... Dubious, test returned 255 (wstat 65280, 0xff00) -zefram
Download (untitled) / with headers
text/plain 535b
On 2015-06-18 09:47:01, zefram@fysh.org wrote: Show quoted text
> Archive-Zip-1.47's t/22_deflated_dir.t has a skip() without the > requisite > SKIP block. If the skip is taken, the test script fails: > > Label not found for "last SKIP" at /opt/perl- > 5.20.2/lib/site_perl/5.20.2/Test/More.pm line 1314. > # Looks like your test exited with 255 just after 4. > t/22_deflated_dir.t ........... > Dubious, test returned 255 (wstat 65280, 0xff00) >
This explains the many fails on CPAN Testers: http://matrix.cpantesters.org/?dist=Archive-Zip%201.47
Subject: Re: [rt.cpan.org #105330] broken test skip in 1.47
Date: Thu, 18 Jun 2015 18:32:20 -0700
To: bug-Archive-Zip [...] rt.cpan.org
From: Fred Moyer <fred [...] redhotpenguin.com>
Download (untitled) / with headers
text/plain 791b
I pushed a new release out today to resolve this. On Thu, Jun 18, 2015 at 10:25 AM, Slaven_Rezic via RT <bug-Archive-Zip@rt.cpan.org> wrote: Show quoted text
> Queue: Archive-Zip > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105330 > > > On 2015-06-18 09:47:01, zefram@fysh.org wrote:
>> Archive-Zip-1.47's t/22_deflated_dir.t has a skip() without the >> requisite >> SKIP block. If the skip is taken, the test script fails: >> >> Label not found for "last SKIP" at /opt/perl- >> 5.20.2/lib/site_perl/5.20.2/Test/More.pm line 1314. >> # Looks like your test exited with 255 just after 4. >> t/22_deflated_dir.t ........... >> Dubious, test returned 255 (wstat 65280, 0xff00) >>
> > This explains the many fails on CPAN Testers: > http://matrix.cpantesters.org/?dist=Archive-Zip%201.47
Download (untitled) / with headers
text/plain 1.4k
On Thu Jun 18 21:32:32 2015, fred@redhotpenguin.com wrote: Show quoted text
> I pushed a new release out today to resolve this.
That doesn't improve things: t/22_deflated_dir.t ........... 1/4 # Failed test 'output zip isn't corrupted' # at t/22_deflated_dir.t line 24. # got: '512' # expected: '0' # Looks like you failed 1 test of 4. t/22_deflated_dir.t ........... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests Test Summary Report ------------------- t/22_deflated_dir.t (Wstat: 256 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=22, Tests=291, 2 wallclock secs ( 0.07 usr 0.02 sys + 1.77 cusr 0.23 csys = 2.09 CPU) Result: FAIL Failed 1/22 test programs. 1/291 subtests failed. .cpan/build/Archive-Zip-1.48-xLRQ6o $ prove -vwb t/22_deflated_dir.t t/22_deflated_dir.t .. 1..4 ok 1 - An object of class 'Archive::Zip::Archive' isa 'Archive::Zip' ok 2 - Read file ok 3 - Wrote file not ok 4 - output zip isn't corrupted # Failed test 'output zip isn't corrupted' # at t/22_deflated_dir.t line 24. # got: '512' # expected: '0' # Looks like you failed 1 test of 4. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests Test Summary Report ------------------- t/22_deflated_dir.t (Wstat: 256 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=4, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.06 cusr 0.01 csys = 0.09 CPU) Result: FAIL
Subject: Re: [rt.cpan.org #105330] broken test skip in 1.47
Date: Sun, 21 Jun 2015 12:23:15 -0700
To: bug-Archive-Zip [...] rt.cpan.org
From: Fred Moyer <fred [...] redhotpenguin.com>
Download (untitled) / with headers
text/plain 1.7k
Ugh - that test wasn't included in the manifest before 1.48, so wasn't shipping. I'll see what I can do. On Sun, Jun 21, 2015 at 1:17 AM, H.Merijn Brand via RT <bug-Archive-Zip@rt.cpan.org> wrote: Show quoted text
> Queue: Archive-Zip > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105330 > > > On Thu Jun 18 21:32:32 2015, fred@redhotpenguin.com wrote:
>> I pushed a new release out today to resolve this.
> > That doesn't improve things: > > t/22_deflated_dir.t ........... 1/4 > # Failed test 'output zip isn't corrupted' > # at t/22_deflated_dir.t line 24. > # got: '512' > # expected: '0' > # Looks like you failed 1 test of 4. > t/22_deflated_dir.t ........... Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/4 subtests > > Test Summary Report > ------------------- > t/22_deflated_dir.t (Wstat: 256 Tests: 4 Failed: 1) > Failed test: 4 > Non-zero exit status: 1 > Files=22, Tests=291, 2 wallclock secs ( 0.07 usr 0.02 sys + 1.77 cusr 0.23 csys = 2.09 CPU) > Result: FAIL > Failed 1/22 test programs. 1/291 subtests failed. > > > .cpan/build/Archive-Zip-1.48-xLRQ6o $ prove -vwb t/22_deflated_dir.t > t/22_deflated_dir.t .. > 1..4 > ok 1 - An object of class 'Archive::Zip::Archive' isa 'Archive::Zip' > ok 2 - Read file > ok 3 - Wrote file > not ok 4 - output zip isn't corrupted > > # Failed test 'output zip isn't corrupted' > # at t/22_deflated_dir.t line 24. > # got: '512' > # expected: '0' > # Looks like you failed 1 test of 4. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/4 subtests > > Test Summary Report > ------------------- > t/22_deflated_dir.t (Wstat: 256 Tests: 4 Failed: 1) > Failed test: 4 > Non-zero exit status: 1 > Files=1, Tests=4, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.06 cusr 0.01 csys = 0.09 CPU) > Result: FAIL >
Download (untitled) / with headers
text/plain 485b
On 2015-06-21 04:17:31, HMBRAND wrote: Show quoted text
> On Thu Jun 18 21:32:32 2015, fred@redhotpenguin.com wrote:
> > I pushed a new release out today to resolve this.
> > That doesn't improve things:
Looking at the current matrix, it does improve things. The 'output zip isn't corrupted' error happens, but seems to be quite rare, see: http://analysis.cpantesters.org/reports_by_field?distv=Archive-Zip-1.48;field=qr%3A%28Failed%20test\s%2B\S%2B.*%29 Probably this is something for a new ticket.
Download (untitled) / with headers
text/plain 639b
On 2015-06-21 13:05:09, SREZIC wrote: Show quoted text
> On 2015-06-21 04:17:31, HMBRAND wrote:
> > On Thu Jun 18 21:32:32 2015, fred@redhotpenguin.com wrote:
> > > I pushed a new release out today to resolve this.
> > > > That doesn't improve things:
> > Looking at the current matrix, it does improve things. The 'output zip > isn't corrupted' error happens, but seems to be quite rare, see: > http://analysis.cpantesters.org/reports_by_field?distv=Archive-Zip- > 1.48;field=qr%3A%28Failed%20test\s%2B\S%2B.*%29 > Probably this is something for a new ticket.
I've been seeing consistent failures with Archive::Zip now on travis (which uses linux VMs).
Download (untitled) / with headers
text/plain 792b
On 2015-06-28 11:40:07, ETHER wrote: Show quoted text
> On 2015-06-21 13:05:09, SREZIC wrote:
> > On 2015-06-21 04:17:31, HMBRAND wrote:
> > > On Thu Jun 18 21:32:32 2015, fred@redhotpenguin.com wrote:
> > > > I pushed a new release out today to resolve this.
> > > > > > That doesn't improve things:
> > > > Looking at the current matrix, it does improve things. The 'output > > zip > > isn't corrupted' error happens, but seems to be quite rare, see: > > http://analysis.cpantesters.org/reports_by_field?distv=Archive-Zip- > > 1.48;field=qr%3A%28Failed%20test\s%2B\S%2B.*%29 > > Probably this is something for a new ticket.
> > > I've been seeing consistent failures with Archive::Zip now on travis > (which uses linux VMs).
example - https://s3.amazonaws.com/archive.travis-ci.org/jobs/68726120/log.txt
From: ozcoder [...] gmail.com
Download (untitled) / with headers
text/plain 1.3k
On Sun Jun 28 18:47:13 2015, ETHER wrote: Show quoted text
> On 2015-06-28 11:40:07, ETHER wrote:
> > On 2015-06-21 13:05:09, SREZIC wrote:
> > > On 2015-06-21 04:17:31, HMBRAND wrote:
> > > > On Thu Jun 18 21:32:32 2015, fred@redhotpenguin.com wrote:
> > > > > I pushed a new release out today to resolve this.
> > > > > > > > That doesn't improve things:
> > > > > > Looking at the current matrix, it does improve things. The 'output > > > zip > > > isn't corrupted' error happens, but seems to be quite rare, see: > > > http://analysis.cpantesters.org/reports_by_field?distv=Archive-Zip- > > > 1.48;field=qr%3A%28Failed%20test\s%2B\S%2B.*%29 > > > Probably this is something for a new ticket.
> > > > > > I've been seeing consistent failures with Archive::Zip now on travis > > (which uses linux VMs).
> > > example - https://s3.amazonaws.com/archive.travis- > ci.org/jobs/68726120/log.txt
FYI Ok, I have finally worked out what is going on. It's actually a bug in that particular version of unzip. There was security bug https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2014-8139 that was sort of fixed in this version, but not quite right. It doesn't allow 0 length field, but the check was wrong. A later version has it fixed correctly. See my non-container Travis run https://travis-ci.org/ozcoder/perl-Archive-Zip/builds/109792014 Gordon


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.