Skip Menu |
 

This queue is for tickets about the POE-Component-SSLify CPAN distribution.

Report information
The Basics
Id: 104493
Status: open
Priority: 0/
Queue: POE-Component-SSLify

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.012
Fixed in: 1.012

Attachments
POE-Component-SSLify-1.012-Use-default-SSL-version-in-tests.patch



Subject: Tests fail with Can't locate auto/Net/SSLeay/CTX_v3_new.al
Download (untitled) / with headers
text/plain 2.2k
As you you can see in CPAN Test Matrix, tests fail on calling SSLify_Options: t/connfail_server.t ........... ok # Failed test 'SERVER: SSLify_Options Can't locate auto/Net/SSLeay/CTX_v3_new.al in @INC (@INC contains: /tmp/loop_over_bdir-21278-qUr_69/POE-Component-SSLify-1.012-uXBSkh/blib/arch /tmp/loop_over_bdir-21278-qUr_69/POE-Component-SSLify-1.012-uXBSkh/blib/lib /home/sand/src/perl/repoperls/installed-perls/perl/v5.20.2/8005/lib/site_perl/5.20.2/x86_64-linux-thread-multi /home/sand/src/perl/repoperls/installed-perls/perl/v5.20.2/8005/lib/site_perl/5.20.2 /home/sand/src/perl/repoperls/installed-perls/perl/v5.20.2/8005/lib/5.20.2/x86_64-linux-thread-multi /home/sand/src/perl/repoperls/installed-perls/perl/v5.20.2/8005/lib/5.20.2 .) at /tmp/loop_over_bdir-21278-qUr_69/POE-Component-SSLify-1.012-uXBSkh/blib/lib/POE/Component/SSLify.pm line 362. # ' # at t/renegotiate_client.t line 55. # Failed test 'SERVER: Server_SSLify Please do SSLify_Options() first ( or pass in a $ctx object ) at /tmp/loop_over_bdir-21278-qUr_69/POE-Component-SSLify-1.012-uXBSkh/blib/lib/POE/Component/SSLify.pm line 247. # ' # at t/renegotiate_client.t line 58. # Failed test 'CLIENT: SSLify_ContextCreate Can't locate auto/Net/SSLeay/CTX_v3_new.al in @INC (@INC contains: /tmp/loop_over_bdir-21278-qUr_69/POE-Component-SSLify-1.012-uXBSkh/blib/arch /tmp/loop_over_bdir-21278-qUr_69/POE-Component-SSLify-1.012-uXBSkh/blib/lib /home/sand/src/perl/repoperls/installed-perls/perl/v5.20.2/8005/lib/site_perl/5.20.2/x86_64-linux-thread-multi /home/sand/src/perl/repoperls/installed-perls/perl/v5.20.2/8005/lib/site_perl/5.20.2 /home/sand/src/perl/repoperls/installed-perls/perl/v5.20.2/8005/lib/5.20.2/x86_64-linux-thread-multi /home/sand/src/perl/repoperls/installed-perls/perl/v5.20.2/8005/lib/5.20.2 .) at /tmp/loop_over_bdir-21278-qUr_69/POE-Component-SSLify-1.012-uXBSkh/blib/lib/POE/Component/SSLify.pm line 362. # ' # at t/renegotiate_client.t line 117. Can't use an undefined value as a symbol reference at /tmp/loop_over_bdir-21278-qUr_69/POE-Component-SSLify-1.012-uXBSkh/blib/lib/POE/Component/SSLify.pm line 446. # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 22 just after 7. t/renegotiate_client.t ........ Dubious, test returned 22 (wstat 5632, 0x1600) Failed 3/7 subtests
From: ppisar [...] redhat.com
Download (untitled) / with headers
text/plain 977b
Dne Po 18.Květen.2015 04:22:38, ppisar napsal(a): Show quoted text
> # Failed test 'SERVER: SSLify_Options Can't locate > auto/Net/SSLeay/CTX_v3_new.al in @INC (@INC contains: > /tmp/loop_over_bdir-21278-qUr_69/POE-Component-SSLify-1.012- > uXBSkh/blib/arch /tmp/loop_over_bdir-21278-qUr_69/POE-Component- > SSLify-1.012-uXBSkh/blib/lib /home/sand/src/perl/repoperls/installed- > perls/perl/v5.20.2/8005/lib/site_perl/5.20.2/x86_64-linux-thread-multi > /home/sand/src/perl/repoperls/installed- > perls/perl/v5.20.2/8005/lib/site_perl/5.20.2 > /home/sand/src/perl/repoperls/installed- > perls/perl/v5.20.2/8005/lib/5.20.2/x86_64-linux-thread-multi > /home/sand/src/perl/repoperls/installed- > perls/perl/v5.20.2/8005/lib/5.20.2 .) at /tmp/loop_over_bdir-21278- > qUr_69/POE-Component-SSLify-1.012- > uXBSkh/blib/lib/POE/Component/SSLify.pm line 362. > # ' > # at t/renegotiate_client.t line 55.
This looks like Net-SSLeay issue. See <https://rt.cpan.org/Public/Bug/Display.html?id=104497>.
From: ppisar [...] redhat.com
Download (untitled) / with headers
text/plain 1.3k
Dne Po 18.Květen.2015 09:11:26, ppisar napsal(a): Show quoted text
> Dne Po 18.Květen.2015 04:22:38, ppisar napsal(a):
> > # Failed test 'SERVER: SSLify_Options Can't locate > > auto/Net/SSLeay/CTX_v3_new.al in @INC (@INC contains: > > /tmp/loop_over_bdir-21278-qUr_69/POE-Component-SSLify-1.012- > > uXBSkh/blib/arch /tmp/loop_over_bdir-21278-qUr_69/POE-Component- > > SSLify-1.012-uXBSkh/blib/lib /home/sand/src/perl/repoperls/installed- > > perls/perl/v5.20.2/8005/lib/site_perl/5.20.2/x86_64-linux-thread- > > multi > > /home/sand/src/perl/repoperls/installed- > > perls/perl/v5.20.2/8005/lib/site_perl/5.20.2 > > /home/sand/src/perl/repoperls/installed- > > perls/perl/v5.20.2/8005/lib/5.20.2/x86_64-linux-thread-multi > > /home/sand/src/perl/repoperls/installed- > > perls/perl/v5.20.2/8005/lib/5.20.2 .) at /tmp/loop_over_bdir-21278- > > qUr_69/POE-Component-SSLify-1.012- > > uXBSkh/blib/lib/POE/Component/SSLify.pm line 362. > > # ' > > # at t/renegotiate_client.t line 55.
> > This looks like Net-SSLeay issue. See > <https://rt.cpan.org/Public/Bug/Display.html?id=104497>.
But the SSLv3 support will be sooner or later removed. I recommend to use the `default' everywhere in the tests. I'm not sure about the renegotiate tests. If they have meaning only for SSL, I would skip them if Net::SSLeay::CTX_v3_new() raised an exception.
From: ppisar [...] redhat.com
Download (untitled) / with headers
text/plain 430b
Dne Po 18.Květen.2015 09:45:51, ppisar napsal(a): Show quoted text
> But the SSLv3 support will be sooner or later removed. I recommend to > use the `default' everywhere in the tests. > > I'm not sure about the renegotiate tests. If they have meaning only > for SSL, I would skip them if Net::SSLeay::CTX_v3_new() raised an > exception.
Attached patch changes the tests to the `default' everywhere. This makes the tests passing for me. -- Petr
Subject: POE-Component-SSLify-1.012-Use-default-SSL-version-in-tests.patch
From fab873b9e556bc64cdd9da87ee76332840ca87e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Mon, 18 May 2015 16:04:37 +0200 Subject: [PATCH] Use default SSL version in tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit OpenSSL or distributor will remove support for SSLv3 soon or later. POE-Component-SSLify tests fail now because Net-SSLeay-0.68 has already removed the support. The patch replaces hard-coding any specific procol version to `default' value which should be future-proof. CPAN RT#104493 Signed-off-by: Petr Písař <ppisar@redhat.com> --- t/renegotiate_client.t | 6 +++--- t/renegotiate_client_pings.t | 6 +++--- t/renegotiate_server.t | 6 +++--- t/simple.t | 6 +++--- t/simple_large.t | 6 +++--- t/simple_parallel.t | 6 +++--- t/simple_parallel_large.t | 6 +++--- t/simple_parallel_superbig.t | 6 +++--- t/simple_superbig.t | 6 +++--- t/upgrade.t | 6 +++--- 10 files changed, 30 insertions(+), 30 deletions(-) diff --git a/t/renegotiate_client.t b/t/renegotiate_client.t index 2673653..f140b07 100644 --- a/t/renegotiate_client.t +++ b/t/renegotiate_client.t @@ -50,8 +50,8 @@ POE::Component::Server::TCP->new }, ClientPreConnect => sub { - eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'sslv3') }; - eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'sslv3') } if ($@); + eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'default') }; + eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'default') } if ($@); ok(!$@, "SERVER: SSLify_Options $@"); my $socket = eval { Server_SSLify($_[ARG0]) }; @@ -113,7 +113,7 @@ POE::Component::Client::TCP->new }, PreConnect => sub { - my $ctx = eval { SSLify_ContextCreate(undef, undef, 'sslv3') }; + my $ctx = eval { SSLify_ContextCreate(undef, undef, 'default') }; ok(!$@, "CLIENT: SSLify_ContextCreate $@"); my $socket = eval { Client_SSLify($_[ARG0], undef, undef, $ctx) }; ok(!$@, "CLIENT: Client_SSLify $@"); diff --git a/t/renegotiate_client_pings.t b/t/renegotiate_client_pings.t index 23181dc..565c223 100644 --- a/t/renegotiate_client_pings.t +++ b/t/renegotiate_client_pings.t @@ -52,8 +52,8 @@ POE::Component::Server::TCP->new }, ClientPreConnect => sub { - eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'sslv3') }; - eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'sslv3') } if ($@); + eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'default') }; + eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'default') } if ($@); ok(!$@, "SERVER: SSLify_Options $@"); my $socket = eval { Server_SSLify($_[ARG0]) }; @@ -116,7 +116,7 @@ POE::Component::Client::TCP->new }, PreConnect => sub { - my $ctx = eval { SSLify_ContextCreate(undef, undef, 'sslv3') }; + my $ctx = eval { SSLify_ContextCreate(undef, undef, 'default') }; ok(!$@, "CLIENT: SSLify_ContextCreate $@"); my $socket = eval { Client_SSLify($_[ARG0], undef, undef, $ctx) }; ok(!$@, "CLIENT: Client_SSLify $@"); diff --git a/t/renegotiate_server.t b/t/renegotiate_server.t index 9e07aea..d7384ce 100644 --- a/t/renegotiate_server.t +++ b/t/renegotiate_server.t @@ -50,8 +50,8 @@ POE::Component::Server::TCP->new }, ClientPreConnect => sub { - eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'sslv3') }; - eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'sslv3') } if ($@); + eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'default') }; + eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'default') } if ($@); ok(!$@, "SERVER: SSLify_Options $@"); my $socket = eval { Server_SSLify($_[ARG0]) }; @@ -113,7 +113,7 @@ POE::Component::Client::TCP->new }, PreConnect => sub { - my $ctx = eval { SSLify_ContextCreate(undef, undef, 'sslv3') }; + my $ctx = eval { SSLify_ContextCreate(undef, undef, 'default') }; ok(!$@, "CLIENT: SSLify_ContextCreate $@"); my $socket = eval { Client_SSLify($_[ARG0], undef, undef, $ctx) }; ok(!$@, "CLIENT: Client_SSLify $@"); diff --git a/t/simple.t b/t/simple.t index 742f9e6..9225cd9 100644 --- a/t/simple.t +++ b/t/simple.t @@ -47,8 +47,8 @@ POE::Component::Server::TCP->new }, ClientPreConnect => sub { - eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'sslv3') }; - eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'sslv3') } if ($@); + eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'default') }; + eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'default') } if ($@); ok(!$@, "SERVER: SSLify_Options $@"); my $socket = eval { Server_SSLify($_[ARG0]) }; @@ -107,7 +107,7 @@ POE::Component::Client::TCP->new }, PreConnect => sub { - my $ctx = eval { SSLify_ContextCreate(undef, undef, 'sslv3') }; + my $ctx = eval { SSLify_ContextCreate(undef, undef, 'default') }; ok(!$@, "CLIENT: SSLify_ContextCreate $@"); my $socket = eval { Client_SSLify($_[ARG0], undef, undef, $ctx) }; ok(!$@, "CLIENT: Client_SSLify $@"); diff --git a/t/simple_large.t b/t/simple_large.t index f749880..01046fc 100644 --- a/t/simple_large.t +++ b/t/simple_large.t @@ -49,8 +49,8 @@ POE::Component::Server::TCP->new }, ClientPreConnect => sub { - eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'sslv3') }; - eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'sslv3') } if ($@); + eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'default') }; + eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'default') } if ($@); ok(!$@, "SERVER: SSLify_Options $@"); my $socket = eval { Server_SSLify($_[ARG0]) }; @@ -109,7 +109,7 @@ POE::Component::Client::TCP->new }, PreConnect => sub { - my $ctx = eval { SSLify_ContextCreate(undef, undef, 'sslv3') }; + my $ctx = eval { SSLify_ContextCreate(undef, undef, 'default') }; ok(!$@, "CLIENT: SSLify_ContextCreate $@"); my $socket = eval { Client_SSLify($_[ARG0], undef, undef, $ctx) }; ok(!$@, "CLIENT: Client_SSLify $@"); diff --git a/t/simple_parallel.t b/t/simple_parallel.t index f135b28..006ccd0 100644 --- a/t/simple_parallel.t +++ b/t/simple_parallel.t @@ -47,8 +47,8 @@ POE::Component::Server::TCP->new }, ClientPreConnect => sub { - eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'sslv3') }; - eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'sslv3') } if ($@); + eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'default') }; + eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'default') } if ($@); ok(!$@, "SERVER: SSLify_Options $@"); my $socket = eval { Server_SSLify($_[ARG0]) }; @@ -107,7 +107,7 @@ POE::Component::Client::TCP->new }, PreConnect => sub { - my $ctx = eval { SSLify_ContextCreate(undef, undef, 'sslv3') }; + my $ctx = eval { SSLify_ContextCreate(undef, undef, 'default') }; ok(!$@, "CLIENT: SSLify_ContextCreate $@"); my $socket = eval { Client_SSLify($_[ARG0], undef, undef, $ctx) }; ok(!$@, "CLIENT: Client_SSLify $@"); diff --git a/t/simple_parallel_large.t b/t/simple_parallel_large.t index fa4d3d6..d065748 100644 --- a/t/simple_parallel_large.t +++ b/t/simple_parallel_large.t @@ -49,8 +49,8 @@ POE::Component::Server::TCP->new }, ClientPreConnect => sub { - eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'sslv3') }; - eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'sslv3') } if ($@); + eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'default') }; + eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'default') } if ($@); ok(!$@, "SERVER: SSLify_Options $@"); my $socket = eval { Server_SSLify($_[ARG0]) }; @@ -107,7 +107,7 @@ POE::Component::Client::TCP->new }, PreConnect => sub { - my $ctx = eval { SSLify_ContextCreate(undef, undef, 'sslv3') }; + my $ctx = eval { SSLify_ContextCreate(undef, undef, 'default') }; ok(!$@, "CLIENT: SSLify_ContextCreate $@"); my $socket = eval { Client_SSLify($_[ARG0], undef, undef, $ctx) }; ok(!$@, "CLIENT: Client_SSLify $@"); diff --git a/t/simple_parallel_superbig.t b/t/simple_parallel_superbig.t index c4ca4ad..eba0efc 100644 --- a/t/simple_parallel_superbig.t +++ b/t/simple_parallel_superbig.t @@ -58,8 +58,8 @@ POE::Component::Server::TCP->new }, ClientPreConnect => sub { - eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'sslv3') }; - eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'sslv3') } if ($@); + eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'default') }; + eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'default') } if ($@); ok(!$@, "SERVER: SSLify_Options $@"); my $socket = eval { Server_SSLify($_[ARG0]) }; @@ -116,7 +116,7 @@ POE::Component::Client::TCP->new }, PreConnect => sub { - my $ctx = eval { SSLify_ContextCreate(undef, undef, 'sslv3') }; + my $ctx = eval { SSLify_ContextCreate(undef, undef, 'default') }; ok(!$@, "CLIENT: SSLify_ContextCreate $@"); my $socket = eval { Client_SSLify($_[ARG0], undef, undef, $ctx) }; ok(!$@, "CLIENT: Client_SSLify $@"); diff --git a/t/simple_superbig.t b/t/simple_superbig.t index 6c5eacd..c00a83c 100644 --- a/t/simple_superbig.t +++ b/t/simple_superbig.t @@ -57,8 +57,8 @@ POE::Component::Server::TCP->new }, ClientPreConnect => sub { - eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'sslv3') }; - eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'sslv3') } if ($@); + eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'default') }; + eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'default') } if ($@); ok(!$@, "SERVER: SSLify_Options $@"); my $socket = eval { Server_SSLify($_[ARG0]) }; @@ -119,7 +119,7 @@ POE::Component::Client::TCP->new }, PreConnect => sub { - my $ctx = eval { SSLify_ContextCreate(undef, undef, 'sslv3') }; + my $ctx = eval { SSLify_ContextCreate(undef, undef, 'default') }; ok(!$@, "CLIENT: SSLify_ContextCreate $@"); my $socket = eval { Client_SSLify($_[ARG0], undef, undef, $ctx) }; ok(!$@, "CLIENT: Client_SSLify $@"); diff --git a/t/upgrade.t b/t/upgrade.t index cd5fdb3..7795bbb 100644 --- a/t/upgrade.t +++ b/t/upgrade.t @@ -54,8 +54,8 @@ POE::Component::Server::TCP->new $heap->{client}->flush; # make sure we sent the pong # sslify it in-situ! - eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'sslv3') }; - eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'sslv3') } if ($@); + eval { SSLify_Options('mylib/example.key', 'mylib/example.crt', 'default') }; + eval { SSLify_Options('../mylib/example.key', '../mylib/example.crt', 'default') } if ($@); ok(!$@, "SERVER: SSLify_Options $@"); my $socket = eval { Server_SSLify($heap->{client}->get_output_handle) }; ok(!$@, "SERVER: Server_SSLify $@"); @@ -124,7 +124,7 @@ POE::Component::Client::TCP->new ok(1, "CLIENT: recv: $line"); # sslify it in-situ! - my $ctx = eval { SSLify_ContextCreate(undef, undef, 'sslv3') }; + my $ctx = eval { SSLify_ContextCreate(undef, undef, 'default') }; ok(!$@, "CLIENT: SSLify_ContextCreate $@"); my $socket = eval { Client_SSLify($heap->{server}->get_output_handle, undef, undef, $ctx) }; ok(!$@, "CLIENT: Client_SSLify $@"); -- 2.1.0
Just hit this issue today. Any chance of a release? Thanks, -- Matthew Horsfall (alh)
Still happening two years later.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.