Skip Menu |
 

This queue is for tickets about the File-VirusScan CPAN distribution.

Report information
The Basics
Id: 103885
Status: open
Priority: 0/
Queue: File-VirusScan

People
Owner: dfs+pause [...] roaringpenguin.com
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 0.102
  • 0.103
Fixed in: (no value)



Subject: TMPDIR is not always /tmp
Download (untitled) / with headers
text/plain 628b
This test error looks like it's expected that the temporary directory is /tmp. But a user may overwrite his temporary directory using the TMPDIR environment variable. Probably it's best to replace the filename pattern with just /.*/ # Failed test 'Error string is what we expected' # at t/file-virusscan-trivial.t line 49. # 'bogus scanner looking at /var/tmp/cpansmoker-1001/yApaYqyynW' # doesn't match '(?^:^bogus scanner looking at /tmp/(?:[A-Za-z0-9]+)$)' # Looks like you failed 1 test of 15. t/file-virusscan-trivial.t ........ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/15 subtests
Subject: Re: [rt.cpan.org #103885] TMPDIR is not always /tmp
Date: Wed, 22 Apr 2015 15:29:38 -0400
To: bug-File-VirusScan [...] rt.cpan.org
From: Dianne Skoll <dfs [...] roaringpenguin.com>
Download (untitled) / with headers
text/plain 740b
Hi, Thanks for the bug report. I've applied the patch below in the git repository; the fix will be in the next release. Regards, Dianne. diff --git a/t/file-virusscan-trivial.t b/t/file-virusscan-trivial.t index 31874ef..1ba091b 100644 --- a/t/file-virusscan-trivial.t +++ b/t/file-virusscan-trivial.t @@ -46,5 +46,5 @@ $fh->close; $result = $s->scan( $filename ); isa_ok( $result, 'File::VirusScan::ResultSet'); ok( $result->has_error(), 'Result is an error' ); -like( ($result->get_error)[0]->get_data, qr{^bogus scanner looking at /tmp/(?:[A-Za-z0-9]+)$}, 'Error string is what we expected'); +like( ($result->get_error)[0]->get_data, qr{^bogus scanner looking at /.*/(?:[A-Za-z0-9]+)$}, 'Error string is what we expected'); 1;


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.