Skip Menu |
 

This queue is for tickets about the Config-IniFiles CPAN distribution.

Report information
The Basics
Id: 103496
Status: resolved
Priority: 0/
Queue: Config-IniFiles

People
Owner: Nobody in particular
Requestors: JORISD [...] cpan.org
Cc: a.rabier [...] criteo.com
AdminCc:

Bug Information
Severity: Important
Broken in: 2.83
Fixed in: 2.86



CC: a.rabier [...] criteo.com
Subject: Improperly update while using _write_config_with_a_made_fh
Download (untitled) / with headers
text/plain 418b
Hello, We found a bug in version 2.83 that prevent the correct update of a tied ini file opened with IO::File. If you update some fields values that are shorter than the previous ones, you end up with some screwed ini file. The solution is to truncate the file before a RewriteConfig. You'll find with this bug report an archive providing a script that will showcase the bug, and a patch file. Best regards, Joris
Subject: config-inifiles.tgz
Download config-inifiles.tgz
application/x-compressed-tar 824b

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 741b
On Mon Apr 13 12:00:35 2015, JORISD wrote: Show quoted text
> Hello, > > We found a bug in version 2.83 that prevent the correct update of a > tied ini file opened with IO::File. > > If you update some fields values that are shorter than the previous > ones, you end up with some screwed ini file. > > The solution is to truncate the file before a RewriteConfig. > > You'll find with this bug report an archive providing a script that > will showcase the bug, and a patch file. > > Best regards, > Joris
Thanks for the report and the files you provided. I was able to rework the PoC script into a test case (a t/*.t file) and the problem you reported is now fixed in the recent versions of Config-IniFiles on CPAN. Resolving. Regards, -- Shlomi Fish
Download (untitled) / with headers
text/plain 917b
On 2015-04-13 16:05:49, SHLOMIF wrote: Show quoted text
> On Mon Apr 13 12:00:35 2015, JORISD wrote:
> > Hello, > > > > We found a bug in version 2.83 that prevent the correct update of a > > tied ini file opened with IO::File. > > > > If you update some fields values that are shorter than the previous > > ones, you end up with some screwed ini file. > > > > The solution is to truncate the file before a RewriteConfig. > > > > You'll find with this bug report an archive providing a script that > > will showcase the bug, and a patch file. > > > > Best regards, > > Joris
> > Thanks for the report and the files you provided. I was able to rework > the PoC script into a test case (a t/*.t file) and the problem you > reported is now fixed in the recent versions of Config-IniFiles on > CPAN. > > Resolving. >
Unfortunately the test suite now fails for perl < 5.14. See http://matrix.cpantesters.org/?dist=Config-IniFiles+2.85
On Mon Apr 13 22:33:35 2015, SREZIC wrote: Show quoted text
> On 2015-04-13 16:05:49, SHLOMIF wrote:
> > On Mon Apr 13 12:00:35 2015, JORISD wrote:
> > > Hello, > > > > > > We found a bug in version 2.83 that prevent the correct update of a > > > tied ini file opened with IO::File. > > > > > > If you update some fields values that are shorter than the previous > > > ones, you end up with some screwed ini file. > > > > > > The solution is to truncate the file before a RewriteConfig. > > > > > > You'll find with this bug report an archive providing a script that > > > will showcase the bug, and a patch file. > > > > > > Best regards, > > > Joris
> > > > Thanks for the report and the files you provided. I was able to > > rework > > the PoC script into a test case (a t/*.t file) and the problem you > > reported is now fixed in the recent versions of Config-IniFiles on > > CPAN. > > > > Resolving. > >
> > Unfortunately the test suite now fails for perl < 5.14. See > http://matrix.cpantesters.org/?dist=Config-IniFiles+2.85
Thanks for reporting it SREZIC. This should hopefully be fixed in Config-IniFiles-2.86.
Download (untitled) / with headers
text/plain 1.2k
On 2015-04-14 04:01:23, SHLOMIF wrote: Show quoted text
> On Mon Apr 13 22:33:35 2015, SREZIC wrote:
> > On 2015-04-13 16:05:49, SHLOMIF wrote:
> > > On Mon Apr 13 12:00:35 2015, JORISD wrote:
> > > > Hello, > > > > > > > > We found a bug in version 2.83 that prevent the correct update of > > > > a > > > > tied ini file opened with IO::File. > > > > > > > > If you update some fields values that are shorter than the > > > > previous > > > > ones, you end up with some screwed ini file. > > > > > > > > The solution is to truncate the file before a RewriteConfig. > > > > > > > > You'll find with this bug report an archive providing a script > > > > that > > > > will showcase the bug, and a patch file. > > > > > > > > Best regards, > > > > Joris
> > > > > > Thanks for the report and the files you provided. I was able to > > > rework > > > the PoC script into a test case (a t/*.t file) and the problem you > > > reported is now fixed in the recent versions of Config-IniFiles on > > > CPAN. > > > > > > Resolving. > > >
> > > > Unfortunately the test suite now fails for perl < 5.14. See > > http://matrix.cpantesters.org/?dist=Config-IniFiles+2.85
> > Thanks for reporting it SREZIC. This should hopefully be fixed in > Config-IniFiles-2.86.
Yes, there are PASSes now down to perl 5.8.9.
Download (untitled) / with headers
text/plain 1.3k
Thank you a lot guys ! On Tue Apr 14 14:45:33 2015, SREZIC wrote: Show quoted text
> On 2015-04-14 04:01:23, SHLOMIF wrote:
> > On Mon Apr 13 22:33:35 2015, SREZIC wrote:
> > > On 2015-04-13 16:05:49, SHLOMIF wrote:
> > > > On Mon Apr 13 12:00:35 2015, JORISD wrote:
> > > > > Hello, > > > > > > > > > > We found a bug in version 2.83 that prevent the correct update of > > > > > a > > > > > tied ini file opened with IO::File. > > > > > > > > > > If you update some fields values that are shorter than the > > > > > previous > > > > > ones, you end up with some screwed ini file. > > > > > > > > > > The solution is to truncate the file before a RewriteConfig. > > > > > > > > > > You'll find with this bug report an archive providing a script > > > > > that > > > > > will showcase the bug, and a patch file. > > > > > > > > > > Best regards, > > > > > Joris
> > > > > > > > Thanks for the report and the files you provided. I was able to > > > > rework > > > > the PoC script into a test case (a t/*.t file) and the problem you > > > > reported is now fixed in the recent versions of Config-IniFiles on > > > > CPAN. > > > > > > > > Resolving. > > > >
> > > > > > Unfortunately the test suite now fails for perl < 5.14. See > > > http://matrix.cpantesters.org/?dist=Config-IniFiles+2.85
> > > > Thanks for reporting it SREZIC. This should hopefully be fixed in > > Config-IniFiles-2.86.
> > Yes, there are PASSes now down to perl 5.8.9. >
Download (untitled) / with headers
text/plain 161b
On Wed Apr 15 04:55:30 2015, JORISD wrote: Show quoted text
> Thank you a lot guys ! >
You're welcome! Thanks for the report and the files you sent. Regards, -- Shlomi Fish


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.