Skip Menu |
 

Preferred bug tracker

Please email the preferred bug tracker to report your issue.

This queue is for tickets about the Astro-SpaceTrack CPAN distribution.

Report information
The Basics
Id: 103019
Status: resolved
Priority: 0/
Queue: Astro-SpaceTrack

People
Owner: Nobody in particular
Requestors: vidar [...] ksat.no
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.091



Subject: Sublimit set on since_file queries
Date: Mon, 23 Mar 2015 05:51:32 +0100
To: <bug-Astro-SpaceTrack [...] rt.cpan.org>
From: Vidar Tyldum <vidar [...] ksat.no>
Download (untitled) / with headers
text/plain 761b
Hi Tom, If since_file is set and you do a basic retreive() on multiple OIDs the API will only return 1 result. It seems to happen because of the way $rest{sublimit} is set in the if().. in line 2554. To overcome this I simply added a delete of that hash key into the block on line 2567. I don't think that breaks any other intentions in the code: if ( $opt->{since_file} ) { $rest{FILE} = ">$opt->{since_file}"; $rest{class} = 'tle'; delete $rest{sublimit}; } I edited in place, so I have no diff. Thanks for (another) great module. -- Best regards, Vidar Tyldum Lead Software Engineer, Kongsberg Satellite Services AS [Office: +47 77 60 02 74] [PGP : 0xAC85F5B9] [TNOC: +47 77 60 02 68] [Email: vidar@ksat.no]
Download signature.asc
application/pgp-signature 819b

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 346b
Thank you very much for reporting this problem, and your diligence in working out a solution. Without you and people like you this would be a much worse module. Unfortunately I am not right now in a position to publish a fix, but I should be able to get a development release out by this weekend. I will update the RT ticket when I have done so.
Download (untitled) / with headers
text/plain 698b
Noe that I have had a chance to look at the problem I am even more appreciative of the effort you put into running this to earth. Thank you very much. I have just sent Astro-SpaceTrack version 0.090_01 to PAUSE. I am deleting the {sublimit} key in a different place, because once I figured out that the problem was that '/sublimit/1' was leaking into the REST query I found other cases where it caused the same problem (e.g. "search_oid( { status => 'onorbit' }, 25544, 25546 );" or some such). I also added a test of the query generated by the retrieve() method with your patch installed, and the code actually published passes (n=1!). So I hope your use case still works the way you want it to.
Download (untitled) / with headers
text/plain 501b
Version 0.090_02 just went to PAUSE. The reason for this release is that, after further thought, I came to the completely obvious conclusion that, when building a REST query from options, it was smarter to only put something in the query if it was needed (0.090_02) versus ensuring it was removed if it was not needed (0.090_01). Release 0.090_02 is intended to build the same queries as 0.090_01, but of course I only know this for the tests in 0.090_01's t/spacetrack_queries.t (which 0.090 fails).


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.