Skip Menu |
 

This queue is for tickets about the HTML-FormHandler-Model-DBIC CPAN distribution.

Report information
The Basics
Id: 102376
Status: new
Priority: 0/
Queue: HTML-FormHandler-Model-DBIC

People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: tests not properly rerunnable
Date: Thu, 26 Feb 2015 16:32:36 +0000
To: bug-HTML-FormHandler-Model-DBIC [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 778b
HTML-FormHandler-Model-DBIC's tests mutate a file included in the distribution, t/db/book.db. This means that "make distclean" and the like don't actually return the source tree to its distributed state, which can be very misleading. Also, a bug affecting one run of the test suite can get book.db into a broken state that makes later runs fail even if the earlier bug has been fixed. This happened to me in investigating the problem with the latest HTML-FormHandler, and it's a serious red herring that wastes debugging time. I also wonder whether the multiple writers on one file are compatible with parallelisation of testing. The tests should each make a copy of book.db, and work only on the copy, leaving the original file alone. Attached patch implements. -zefram
Download db_copy.patch
text/x-diff 13.3k

Message body is not shown because sender requested not to inline it.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.