Bug #101586 for libnet: Bug with hidden files for the command LIST

Sat Jan 17 06:29:12 2015 aklyachin [...] beget.ru - Ticket created

Subject:	Bug with hidden files for the command LIST
Date:	Sat, 17 Jan 2015 14:28:54 +0300
To:	bug-libnet@rt.cpan.org
From:	Алексей Клячин <aklyachin@beget.ru>

Hello.
For example, function 'dir' does not return a sometimes hidden files.
You need to use 'LIST -a'

zeus : / [0] # gitt diff 6a2c22f /usr/share/perl/5.10.1/Net/FTP.pm
diff --git a/usr/share/perl/5.10.1/Net/FTP.pm b/usr/share/perl/5.10.1/Net/FTP.pm
index 6afafaa..1773917 100644
--- a/usr/share/perl/5.10.1/Net/FTP.pm
+++ b/usr/share/perl/5.10.1/Net/FTP.pm
@@ -905,7 +905,7 @@ sub _eprt {

sub ls { shift->_list_cmd("NLST", @_); }
-sub dir { shift->_list_cmd("LIST", @_); }
+sub dir { shift->_list_cmd("LIST -a", @_); }

sub pasv {

How quickly bug will be fixed?

-- 
С Уважением, Алексей Клячин,
Системный администратор ООО "Бегет"
Site:    http://beget.ru
Email:   support@beget.ru
ICQ:     580278701
Skype:   beget_support
Phone:   +7 (812) 385-41-36   (СПб)
         +7 (495) 721-80-88   (Москва)
         8 (800) 700-06-08    (Бесплатно по всей России)
         +380 (44) 300-02-18  (Киев)
         0 (800) 802-192      (Бесплатно по всей Украине)

Wed Apr 01 14:43:53 2015 joenio [...] gmail.com - Correspondence added

From:

joenio@gmail.com

I did a pull-request to this: * https://github.com/steve-m-hay/perl-libnet/pull/16

Wed Apr 01 14:43:54 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Jul 17 03:47:23 2015 shay [...] cpan.org - Correspondence added

On Sat Jan 17 06:29:12 2015, aklyachin@beget.ru wrote:

Show quoted text

> Hello. > For example, function 'dir' does not return a sometimes hidden files. > You need to use 'LIST -a' > > zeus : / [0] # gitt diff 6a2c22f /usr/share/perl/5.10.1/Net/FTP.pm > diff --git a/usr/share/perl/5.10.1/Net/FTP.pm > b/usr/share/perl/5.10.1/Net/FTP.pm > index 6afafaa..1773917 100644 > --- a/usr/share/perl/5.10.1/Net/FTP.pm > +++ b/usr/share/perl/5.10.1/Net/FTP.pm > @@ -905,7 +905,7 @@ sub _eprt { > > > sub ls { shift->_list_cmd("NLST", @_); } > -sub dir { shift->_list_cmd("LIST", @_); } > +sub dir { shift->_list_cmd("LIST -a", @_); } > > > sub pasv { > > How quickly bug will be fixed? >

I do not think it would be appropriate to change the dir() function in this way. Users might not want to list all files all the time -- files are sometimes hidden for good reason! Anyone wanting to list all files can easily do so with the existing dir() function, which simply passes its argument list on to the LIST command: $ftp->dir(); $ftp->dir('-a'); $ftp->dir('/subdir'); $ftp->dir('-a', '/subdir'); (And similarly with the ls() function.)

Fri Jul 17 03:47:24 2015 shay [...] cpan.org - Status changed from 'open' to 'rejected'