Skip Menu |
 

This queue is for tickets about the IO-Socket-IP CPAN distribution.

Report information
The Basics
Id: 101396
Status: resolved
Priority: 0/
Queue: IO-Socket-IP

People
Owner: Nobody in particular
Requestors: oleg [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: Fails to listen() without bind() on windows
Download (untitled) / with headers
text/plain 520b
This test script fails on windows with message "Invalid argument at t.pl line 5." use strict; use lib 'IO-Socket-IP-0.35/lib'; use IO::Socket::IP; my $srv = IO::Socket::IP->new(Listen => 1) or die $@; warn "server started at [", $srv->sockhost, "]:", $srv->sockport; __END__ Tested on windows XP and windows 7 This is because IO::Socket::IP will not call bind() before listen() when nor LocalAddr nor LocalPort specified. After this patch we'll get appropriate address to bind to using getaddrinfo('', 0, $hints)
Subject: need-to-bind-on-win32.patch
--- lib/IO/Socket/IP.pm.orig 2015-01-08 13:36:32.107708416 +0600 +++ lib/IO/Socket/IP.pm 2015-01-08 13:34:10.351015399 +0600 @@ -441,10 +441,14 @@ ref $info eq "ARRAY" or croak "Expected 'LocalAddrInfo' to be an ARRAY ref"; @localinfos = @$info; } - elsif( defined $arg->{LocalHost} or defined $arg->{LocalService} ) { + elsif( defined $arg->{LocalHost} or defined $arg->{LocalService} or ($^O eq 'MSWin32' && $arg->{Listen}) ) { # Either may be undef my $host = $arg->{LocalHost}; my $service = $arg->{LocalService}; + + unless ( defined $host or defined $service ) { + $service = 0; + } local $1; # Placate a taint-related bug; [perl #67962] defined $service and $service =~ s/\((\d+)\)$// and
Patch applied. -- Paul Evans
On Sat Jan 10 16:10:44 2015, PEVANS wrote: Show quoted text
> Patch applied.
Thank you!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.