Skip Menu |
 

This queue is for tickets about the XML-Parser CPAN distribution.

Report information
The Basics
Id: 100959
Status: resolved
Priority: 0/
Queue: XML-Parser

People
Owner: Nobody in particular
Requestors: MICHIELB [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.44
Fixed in: 2.44



Subject: Test t/astress.t fails on perl 5.10.0
Download (untitled) / with headers
text/plain 272b
I was able to reproduce this on a 5.10.0 perl on both Linux and OS X. t/astress.t .. 1/27 not ok 5 not ok 6 not ok 7 not ok 8 not ok 9 not ok 10 not ok 11 not ok 14 not ok 18 not ok 19 not ok 20 not ok 21 not ok 22 not ok 23 not ok 24 t/astress.t .. Failed 15/27 subtests
Download (untitled) / with headers
text/plain 873b
This is because the code assumes that FileHandle has a read() method, which it does on more recent perls because of inheritance from IO::Handle, but isn't true on older perls. prove -bv t/astress.t t/astress.t .. 1..27 ok 1 ok 2 ok 3 Parse error: Can't locate object method "read" via package "FileHandle" at /root/.cpan/build/XML-Parser-2.43-haFpxP/blib/lib/XML/Parser/Expat.pm line 482. at line 10, column 34, byte 240 Handler couldn't resolve external entity at line 10, column 34, byte 240 error in processing external entity reference at line 10, column 34, byte 240 at /root/.cpan/build/XML-Parser-2.43-haFpxP/blib/lib/XML/Parser.pm line 187 ok 4 not ok 5 not ok 6 not ok 7 not ok 8 not ok 9 not ok 10 not ok 11 ok 12 ok 13 not ok 14 ok 15 ok 16 ok 17 not ok 18 not ok 19 not ok 20 not ok 21 not ok 22 not ok 23 not ok 24 ok 25 ok 26 ok 27 Failed 15/27 subtests
RT-Send-CC: rt-cpan [...] trout.me.uk
Download (untitled) / with headers
text/plain 277b
This looks to have been broken for a while. For those still using 5.10, the solution appears to be to use FileHandle with your XML::Parser. How about this for a hack on the unit test problem? https://github.com/toddr/XML-Parser/commit/b576a78adec94b808146184eb9ee54be9488c79e
CC: MICHIELB [...] cpan.org
Subject: Re: [rt.cpan.org #100959] Test t/astress.t fails on perl 5.10.0
Date: Mon, 12 Jan 2015 08:38:19 +0100
To: bug-XML-Parser [...] rt.cpan.org
From: Michiel Beijen <michiel.beijen [...] gmail.com>
Download (untitled) / with headers
text/plain 763b
Hi Todd, On Mon, Jan 12, 2015 at 8:06 AM, Todd Rinaldo via RT <bug-XML-Parser@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=100959 > > > This looks to have been broken for a while. For those still using 5.10, the solution appears to be to use FileHandle with your XML::Parser. > > How about this for a hack on the unit test problem? > > https://github.com/toddr/XML-Parser/commit/b576a78adec94b808146184eb9ee54be9488c79e
Great! Or maybe even use if $] < 5.012, FileHandle; although that is just nitpicking, it's only in the test file and your change already makes tests pass... thanks a lot. I'm still interested in 5.10.x mostly because my employer deploys stuff on CentOS/RHEL 6 and it comes with 5.10.1 as a system perl. -- Mike
Thanks, tests pass again on my 5.10.0 and 5.10.1 perls.
RT-Send-CC: rt-cpan [...] trout.me.uk, michiel.beijen [...] gmail.com
Download (untitled) / with headers
text/plain 556b
On 2015-01-12 02:06:06, TODDR wrote: Show quoted text
> This looks to have been broken for a while. For those still using > 5.10, the solution appears to be to use FileHandle with your > XML::Parser. > > How about this for a hack on the unit test problem? > > https://github.com/toddr/XML- > Parser/commit/b576a78adec94b808146184eb9ee54be9488c79e
As I see the same error in another distribution (libxml-perl, see http://www.cpantesters.org/cpan/report/0ada90c8-7d53-11e5-bd9c-5d080e4543d6 for a sample fail report) I think the fix should go to the .pm, not the .t file.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.