Skip Menu |
 

This queue is for tickets about the Finance-Bank-Bankwest CPAN distribution.

Maintainer(s)' notes

This distribution provides the ability to log into Bankwest's Online Banking service using a Personal Access Number (PAN) and access code, then retrieve information on all accounts associated with that PAN and their transactions.

Report information
The Basics
Id: 100946
Status: open
Priority: 0/
Queue: Finance-Bank-Bankwest

People
Owner: lxp [...] cpan.org
Requestors: owenhollands [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.2.8
Fixed in: (no value)



Subject: transaction search dates not being honoured
Download (untitled) / with headers
text/plain 387b
On Tue Dec 16 11:12:01 2014, owenhollands@gmail.com wrote: Show quoted text
> Hi, I was wondering if you had experienced an issue where queries return > the last 7 days of transactions, regardless of the dates specified? > > I haven't had a chance to look into it myself, so I don't know if the issue > is in your code or mine. I thought I would ask in case you were already > looking at it. > > Owen.
Download (untitled) / with headers
text/plain 421b
Hi Owen, On Tue Dec 16 11:12:01 2014, owenhollands@gmail.com wrote: Show quoted text
> I was wondering if you had experienced an issue where queries return > the last 7 days of transactions, regardless of the dates specified?
Thanks for letting me know about this. Bankwest's Transaction Search form parameters have changed, so an update to Finance::Bank::Bankwest is needed. I'll release a fix shortly. -- Kind regards, Alex Peters
Download (untitled) / with headers
text/plain 647b
Hi Owen, On Tue Dec 16 23:07:32 2014, LXP wrote: Show quoted text
> Bankwest's Transaction Search form parameters have changed, so an > update to Finance::Bank::Bankwest is needed. I'll release a fix > shortly.
I've identified the necessary fix, but I don't want to release until I've updated the unit tests (which will require me downloading a bunch of new HTML from Bankwest). In the meantime, if you'd like a fix urgently, the attached patch (prepared against the source on GitHub) shows how to manually modify Finance/Bank/Bankwest/Session.pm for correct operation. I'll let you know when the fix has been properly released. -- Kind regards, Alex Peters
Subject: Session-fix.diff
Download Session-fix.diff
text/x-diff 607b
diff --git a/lib/Finance/Bank/Bankwest/Session.pm b/lib/Finance/Bank/Bankwest/Session.pm index 12b66e0..53d8df1 100644 --- a/lib/Finance/Bank/Bankwest/Session.pm +++ b/lib/Finance/Bank/Bankwest/Session.pm @@ -224,6 +224,8 @@ date of the following Monday. => '3~4~5~6~7', '_ctl0:ContentMain:ddlAccount' => $account, + '_ctl0:ContentMain:ddlRangeOptions' + => 'CUSTOM', '_ctl0:ContentMain:dpFromDate:txtDate' => $from_date, '_ctl0:ContentMain:dpToDate:txtDate'
Subject: Re: [rt.cpan.org #100946] transaction search dates not being honoured
Date: Thu, 18 Dec 2014 12:13:33 +1100
To: bug-Finance-Bank-Bankwest [...] rt.cpan.org
From: Owen Hollands <owenhollands [...] gmail.com>
Download (untitled) / with headers
text/plain 1.7k
That seems to be working - thanks. You saved my a bunch of time trying to fix that. As an asside, do you think there is value in a check script that compares the HTML off the bankwest website with a reference copy to try and detect of the website ahs been updated? Owen. On Thu, Dec 18, 2014 at 12:11 AM, Alex Peters via RT < bug-Finance-Bank-Bankwest@rt.cpan.org> wrote: Show quoted text
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=100946 > > > Hi Owen, > > On Tue Dec 16 23:07:32 2014, LXP wrote:
> > Bankwest's Transaction Search form parameters have changed, so an > > update to Finance::Bank::Bankwest is needed. I'll release a fix > > shortly.
> > I've identified the necessary fix, but I don't want to release until > I've updated the unit tests (which will require me downloading a bunch > of new HTML from Bankwest). > > In the meantime, if you'd like a fix urgently, the attached patch > (prepared against the source on GitHub) shows how to manually modify > Finance/Bank/Bankwest/Session.pm for correct operation. > > I'll let you know when the fix has been properly released. > > -- > Kind regards, > Alex Peters > > diff --git a/lib/Finance/Bank/Bankwest/Session.pm > b/lib/Finance/Bank/Bankwest/Session.pm > index 12b66e0..53d8df1 100644 > --- a/lib/Finance/Bank/Bankwest/Session.pm > +++ b/lib/Finance/Bank/Bankwest/Session.pm > @@ -224,6 +224,8 @@ date of the following Monday. > => '3~4~5~6~7', > '_ctl0:ContentMain:ddlAccount' > => $account, > + '_ctl0:ContentMain:ddlRangeOptions' > + => 'CUSTOM', > '_ctl0:ContentMain:dpFromDate:txtDate' > => $from_date, > '_ctl0:ContentMain:dpToDate:txtDate' > >
Download (untitled) / with headers
text/plain 1.7k
Hi Owen, On Thu Dec 18 12:13:44 2014, owenhollands@gmail.com wrote: Show quoted text
> As an asside, do you think there is value in a check script that > compares the HTML off the bankwest website with a reference copy to > try and detect of the website ahs been updated?
I suppose it would be a bit complicated to directly compare live website data to a reference copy, because of the varying tokens, account info, etc. found on every page. On that basis, I would probably go about this by scripting a bunch of actions on the Bankwest website, passing the resultant HTML to the Finance::Bank::Bankwest::Parser modules, and then testing that they don't reject the HTML. That alone, though, probably wouldn't achieve anything more than just regularly using the Finance::Bank::Bankwest distribution normally. I've tried to code those parser modules with enough expectations that they fail quite verbosely if Bankwest significantly alters the construction of its responses, but with enough leniency that minor design changes would allow the code to continue to work. It seems to be a difficult balance to get right. The parsers continued to work in this case because the change Bankwest made was extremely subtle: take a <select> box which was previously optional, add a new <option> and require that <option> to be selected for the date fields not to be ignored. As far as the relevant parser was concerned, it was exactly the same page. In short, I'm not against the idea of some sort of check script, but I'm struggling to picture how a useful one would operate and whether it would really result in fewer breakages. I'm definitely open to further discussion and insight on the matter though. Thanks for the idea; I'll keep thinking on it. -- Kind regards, Alex Peters


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.