Skip Menu |
 

This queue is for tickets about the CMS-MediaWiki CPAN distribution.

Report information
The Basics
Id: 100921
Status: new
Priority: 0/
Queue: CMS-MediaWiki

People
Owner: Nobody in particular
Requestors: mnemex [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.080008
Fixed in: (no value)



Subject: Corrupts html values if used to edit/save
Download (untitled) / with headers
text/plain 1.2k
A very solid use case is to use CMS::MediaWiki to open files on your wiki, modify them, and then save them. However, this usage is broken because CMS::MediaWiki just sends what it recieves (after pulling html encoded text out of a textarea) -- so it produces encoded html, and writes that encoded html back to the wiki (which thus adds a layer of encoding to the produces text. So any html in the source wiki -- any divs, custom html-ish tags, etc adendum -- will be corrupted when it saves back to the wiki. Solution: use decode_entities from HTML::Entities to decode retrieved text before handing it to clients, thus producing text appropriate to saving without corruption. Patch: --- MediaWiki.pm 2014-12-14 19:08:33.121129063 -0800 +++ MediaWiki.pm.orig 2014-12-14 19:05:29.106717520 -0800 @@ -17,7 +17,6 @@ use LWP::UserAgent; use HTTP::Request::Common; -use HTML::Entities (); # GLOBAL VARIABLES my %Var = (); @@ -266,9 +265,6 @@ push (@content, $line) if ($saving); } - # decode html entities in text, so caller gets clean content. - @content = map HTML::Entities::decode($_) => @content; - # Always return an arrayref for later processing \@content; }
Subject: mediawiki.patch
Download mediawiki.patch
text/x-diff 571b
--- MediaWiki.pm 2014-12-14 19:08:33.121129063 -0800 +++ MediaWiki.pm.orig 2014-12-14 19:05:29.106717520 -0800 @@ -17,7 +17,6 @@ use LWP::UserAgent; use HTTP::Request::Common; -use HTML::Entities (); # GLOBAL VARIABLES my %Var = (); @@ -266,9 +265,6 @@ push (@content, $line) if ($saving); } - # decode html entities in text, so caller gets clean content. - @content = map HTML::Entities::decode($_) => @content; - # Always return an arrayref for later processing \@content; }


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.