Skip Menu |
 

This queue is for tickets about the Archive-Tar CPAN distribution.

Report information
The Basics
Id: 100903
Status: new
Priority: 0/
Queue: Archive-Tar

People
Owner: Nobody in particular
Requestors: craigberry [...] mac.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] fix ptargrep match
Date: Sat, 13 Dec 2014 22:00:24 -0600
To: bugs-Archive-Tar [...] rt.cpan.org
From: "Craig A. Berry" <craigberry [...] mac.com>
Download (untitled) / with headers
text/plain 781b
The 08_ptargrep.t test does a pattern match that appears to assume platform-specific semantics for the pattern that matches a filename. It certainly doesn't match the filename on VMS: not ok 1 - ptargrep shows matched file # Failed test 'ptargrep shows matched file' # at t/08_ptargrep.t;-0 line 29. # '[.t.ptargrep]foo # ' # =~ # '(?^m:^t.*ptargrep.*foo$)' # Looks like you failed 1 test of 1. But we know the actual filename, so the simplest solution is to just do an equality test on that, and that's what the attached patch does. Tested on Windows, VMS, and OS X. Show quoted text
________________________________________ Craig A. Berry mailto:craigberry@mac.com "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
Download ptargrep.patch
text/x-diff 290b

Message body is not shown because sender requested not to inline it.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.