Skip Menu |
 

This queue is for tickets about the Filter CPAN distribution.

Report information
The Basics
Id: 100742
Status: resolved
Priority: 0/
Queue: Filter

People
Owner: Nobody in particular
Requestors: JHI [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: printf type matching
Tiny cleanups due to trying to compile core extensions with -Wall -Wextra. Patch attached.
Subject: 0001-print-type-matching.patch
From 5633a5ed507594199c00e09ada4e668d47c221b1 Mon Sep 17 00:00:00 2001 From: Jarkko Hietaniemi <jhi@iki.fi> Date: Fri, 5 Dec 2014 22:10:36 -0500 Subject: [PATCH] print-type matching. --- cpan/Filter-Util-Call/Call.xs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cpan/Filter-Util-Call/Call.xs b/cpan/Filter-Util-Call/Call.xs index 22163eb..c626dec 100644 --- a/cpan/Filter-Util-Call/Call.xs +++ b/cpan/Filter-Util-Call/Call.xs @@ -60,7 +60,7 @@ filter_call(pTHX_ int idx, SV *buf_sv, int maxlen) if (fdebug) warn("**** In filter_call - maxlen = %d, out len buf = %" IVdf " idx = %d my_sv = %" IVdf " [%s]\n", - maxlen, SvCUR(buf_sv), idx, SvCUR(my_sv), SvPVX(my_sv) ) ; + maxlen, (IV)SvCUR(buf_sv), idx, (IV)SvCUR(my_sv), SvPVX(my_sv) ) ; while (1) { @@ -97,7 +97,7 @@ filter_call(pTHX_ int idx, SV *buf_sv, int maxlen) SvCUR_set(my_sv, n) ; if (fdebug) warn("recycle %d - leaving %d, returning %" IVdf " [%s]", - idx, n, SvCUR(buf_sv), SvPVX(buf_sv)) ; + idx, n, (IV)SvCUR(buf_sv), SvPVX(buf_sv)) ; return SvCUR(buf_sv); } @@ -153,7 +153,7 @@ filter_call(pTHX_ int idx, SV *buf_sv, int maxlen) if (fdebug) warn("status = %d, length op buf = %" IVdf " [%s]\n", - n, SvCUR(DEFSV), SvPVX(DEFSV) ) ; + n, (IV)SvCUR(DEFSV), SvPVX(DEFSV) ) ; if (SvCUR(DEFSV)) sv_setpvn(my_sv, SvPVX(DEFSV), SvCUR(DEFSV)) ; @@ -172,7 +172,7 @@ filter_call(pTHX_ int idx, SV *buf_sv, int maxlen) if (fdebug) warn ("filter_read %d returned %d , returning %" IVdf "\n", idx, n, - (SvCUR(buf_sv)>0) ? SvCUR(buf_sv) : (STRLEN)n); + (SvCUR(buf_sv)>0) ? SvCUR(buf_sv) : (IV)n); /* PERL_MODULE(my_sv) ; */ /* PERL_OBJECT(my_sv) ; */ -- 2.1.2
Download (untitled) / with headers
text/plain 202b
On Fri Dec 05 22:14:43 2014, JHI wrote: Show quoted text
> Tiny cleanups due to trying to compile core extensions with -Wall > -Wextra. Patch attached.
Thanks. Fixed this and some more issues in 1.51 -- Reini Urban


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.