Skip Menu |
 

This queue is for tickets about the autodie CPAN distribution.

Report information
The Basics
Id: 100688
Status: resolved
Priority: 0/
Queue: autodie

People
Owner: Nobody in particular
Requestors: davem [...] iabyn.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] cleanup detritus in /tmp
Date: Wed, 3 Dec 2014 11:46:28 +0000
To: bug-autodie [...] rt.cpan.org
From: Dave Mitchell <davem [...] iabyn.com>
Download (untitled) / with headers
text/plain 655b
In bleadperl, the test file cpan/autodie/t/truncate.t leaves files on /tmp. On smokers, these can gradually accumulate. This patch seems to fix it: diff --git a/cpan/autodie/t/truncate.t b/cpan/autodie/t/truncate.t index 7af7226..a2acfeb 100644 --- a/cpan/autodie/t/truncate.t +++ b/cpan/autodie/t/truncate.t @@ -11,7 +11,7 @@ my ($truncate_status, $tmpfh, $tmpfile); # Some systems have a screwy tempfile. We don't run our tests there. eval { - ($tmpfh, $tmpfile) = tempfile(); + ($tmpfh, $tmpfile) = tempfile(UNLINK => 1); }; if ($@ or !defined $tmpfh) { -- This is a great day for France! -- Nixon at Charles De Gaulle's funeral
Subject: Re: [rt.cpan.org #100688] [PATCH] cleanup detritus in /tmp
Date: Wed, 03 Dec 2014 22:35:09 +0100
To: bug-autodie [...] rt.cpan.org
From: Niels Thykier <niels [...] thykier.net>
Download (untitled) / with headers
text/plain 859b
On 2014-12-03 12:46, Dave Mitchell via RT wrote: Show quoted text
> Wed Dec 03 06:46:39 2014: Request 100688 was acted upon. > [...] > > In bleadperl, the test file cpan/autodie/t/truncate.t leaves files on > /tmp. On smokers, these can gradually accumulate. This patch seems > to fix it: > > diff --git a/cpan/autodie/t/truncate.t b/cpan/autodie/t/truncate.t > index 7af7226..a2acfeb 100644 > --- a/cpan/autodie/t/truncate.t > +++ b/cpan/autodie/t/truncate.t > @@ -11,7 +11,7 @@ my ($truncate_status, $tmpfh, $tmpfile); > > # Some systems have a screwy tempfile. We don't run our tests there. > eval { > - ($tmpfh, $tmpfile) = tempfile(); > + ($tmpfh, $tmpfile) = tempfile(UNLINK => 1); > }; > > if ($@ or !defined $tmpfh) { > >
Applied as 7f420fe[1], thanks. ~Niels [1] https://github.com/pjf/autodie/commit/7f420fe2a293e62b55d75bb242accf2c949ae3c7
Download (untitled) / with headers
text/plain 207b
Hi, Thanks for reporting the issue. :) A fix for this bug was included in the v2.26 release (uploaded to CPAN today). Please have a look at it and let us know if v2.26 works as intended. Thanks, ~Niels


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.