Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the future CPAN distribution.

Report information
The Basics
Id: 100685
Status: resolved
Priority: 0/
Queue: future

People
Owner: Nobody in particular
Requestors: merijnb [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.30
Fixed in: 0.32



Subject: Test fail because of missing dot in exception
Download (untitled) / with headers
text/plain 1.1k
When using Perl 5.14 this test fails: # Failed test 'Lost sequence Future raises warning' # at t/21debug.t line 52. # 'Future=HASH(0x937e210) was constructed at t/21debug.t line 49 and was lost near t/21debug.t line 50 before it was ready. # Future=HASH(0x9470058) (constructed at t/21debug.t line 48) lost a sequence Future at t/21debug.t line 50 # ' # doesn't match '(?-xism:^Future=\S+ was constructed at t\/21debug\.t line 49 and was lost near t\/21debug\.t line (?:50|49) before it was ready\. # Future=\S+ \(constructed at t\/21debug\.t line 48\) lost a sequence Future at t\/21debug\.t line 50\.$)' # Looks like you failed 1 test of 11. t/21debug.t ................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/11 subtests This is easily fixes by changing the regexp in 21debug.t at line 52 like so: qr/^Future=\S+ was constructed at \Q$0\E line $THENLINE and was lost near \Q$0\E line (?:$SEQLINE|$THENLINE) before it was ready\. Future=\S+ \(constructed at \Q$0\E line $LINE\) lost a sequence Future at \Q$0\E line $SEQLINE\.?$/, 'Lost sequence Future raises warning' );
Download (untitled) / with headers
text/plain 100b
Oops. That'll be that Carp version again. Patch attached; will be in next release. -- Paul Evans
Subject: rt100685.patch
Download rt100685.patch
text/x-diff 1.6k
=== modified file 't/21debug.t' --- t/21debug.t 2015-03-10 12:12:14 +0000 +++ t/21debug.t 2015-03-10 12:16:34 +0000 @@ -39,7 +39,7 @@ $LINE = __LINE__; my $f = Future->new; undef $f; }, - qr/^Future=\S+ was constructed at \Q$0\E line $LINE and was lost near \Q$0\E line (?:$LOSTLINE|${\($LINE+1)}) before it was ready\.$/, + qr/^Future=\S+ was constructed at \Q$0\E line $LINE and was lost near \Q$0\E line (?:$LOSTLINE|${\($LINE+1)}) before it was ready\.?$/, 'Lost Future raises a warning' ); my $THENLINE; @@ -49,15 +49,15 @@ $THENLINE = __LINE__; my $fseq = $f1->then( sub { } ); undef $fseq; $SEQLINE = __LINE__; $f1->done; }, - qr/^Future=\S+ was constructed at \Q$0\E line $THENLINE and was lost near \Q$0\E line (?:$SEQLINE|$THENLINE) before it was ready\. -Future=\S+ \(constructed at \Q$0\E line $LINE\) lost a sequence Future at \Q$0\E line $SEQLINE\.$/, + qr/^Future=\S+ was constructed at \Q$0\E line $THENLINE and was lost near \Q$0\E line (?:$SEQLINE|$THENLINE) before it was ready\.? +Future=\S+ \(constructed at \Q$0\E line $LINE\) lost a sequence Future at \Q$0\E line $SEQLINE\.?$/, 'Lost sequence Future raises warning' ); like( warnings { $LINE = __LINE__; my $f = Future->fail("Failed!"); undef $f; }, - qr/^Future=\S+ was constructed at \Q$0\E line $LINE and was lost near \Q$0\E line (?:$LOSTLINE|${\($LINE+1)}) with an unreported failure of: Failed!/, + qr/^Future=\S+ was constructed at \Q$0\E line $LINE and was lost near \Q$0\E line (?:$LOSTLINE|${\($LINE+1)}) with an unreported failure of: Failed!\.?/, 'Destroyed failed future raises warning' ); {
Fixed in 0.32 -- Paul Evans


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.