Skip Menu |
 

This queue is for tickets about the DBIx-Class-ResultSet-RecursiveUpdate CPAN distribution.

Report information
The Basics
Id: 100482
Status: open
Priority: 0/
Queue: DBIx-Class-ResultSet-RecursiveUpdate

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc: ribasushi [...] leporine.io
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Need proper fix for table aliases
Download (untitled) / with headers
text/plain 287b
CE has had this patch applied locally for quite some time: https://gist.github.com/karenetheridge/5d2457221bacfbd3fa68 I understand from ribasushi that this isn't quite the right thing to do, but nevertheless it would be nice to have some sort of fix rolled into the real distribution.
Download (untitled) / with headers
text/plain 597b
On Thu Nov 20 22:14:00 2014, ETHER wrote: Show quoted text
> CE has had this patch applied locally for quite some time: > > https://gist.github.com/karenetheridge/5d2457221bacfbd3fa68 > > I understand from ribasushi that this isn't quite the right thing to > do, but nevertheless it would be nice to have some sort of fix rolled > into the real distribution.
The wheel has finally stopped at this corner of the codebase. Ether: do you happen to have a testcase that goes with the above patch? I.e. I need something that FAILS on current RU as it is on CPAN 0.34, yet passes with your changes applied. Thanks
Download (untitled) / with headers
text/plain 428b
On 2016-08-09 08:31:02, RIBASUSHI wrote: Show quoted text
> The wheel has finally stopped at this corner of the codebase. Ether: > do you happen to have a testcase that goes with the above patch? I.e. > I need something that FAILS on current RU as it is on CPAN 0.34, yet > passes with your changes applied.
I do not, but I can remove the patch and fire up a jenkins instance and see what explodes, to see if that can give us a good test case.
Download (untitled) / with headers
text/plain 861b
On 2016-08-09 10:11:31, ETHER wrote: Show quoted text
> On 2016-08-09 08:31:02, RIBASUSHI wrote: >
> > The wheel has finally stopped at this corner of the codebase. Ether: > > do you happen to have a testcase that goes with the above patch? I.e. > > I need something that FAILS on current RU as it is on CPAN 0.34, yet > > passes with your changes applied.
> > I do not, but I can remove the patch and fire up a jenkins instance > and see what explodes, to see if that can give us a good test case.
Gerda -- if you can recall why you made that patch, that would be fantastic. I found the commit where you applied the patch to the CE codebase, but there are no seemly-relevant commits adjacent to it, and there was no commentary or explanation attached; I didn't see a local github repository for it in the CE organization. (The patch was made at 2014-06-05 20:29:49 -0400.)
Download (untitled) / with headers
text/plain 496b
On Tue Aug 09 19:11:31 2016, ETHER wrote: Show quoted text
> > I do not, but I can remove the patch and fire up a jenkins instance > and see what explodes, to see if that can give us a good test case.
( the email interface is down, you will eventually receive this twice ) Ok, in this case wait a bit. I am almost finished with some changes to ::RU, I suppose starting testing after those are applied to your local tree is the saner thing to do, given the effort on your side is non-trivial. More in a bit.
Subject: Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date: Tue, 9 Aug 2016 19:18:27 +0200
To: bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From: Peter Rabbitson <ribasushi [...] cpan.org>
Download (untitled) / with headers
text/plain 794b
On 08/09/2016 07:11 PM, Karen Etheridge via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > On 2016-08-09 08:31:02, RIBASUSHI wrote: >
>> The wheel has finally stopped at this corner of the codebase. Ether: >> do you happen to have a testcase that goes with the above patch? I.e. >> I need something that FAILS on current RU as it is on CPAN 0.34, yet >> passes with your changes applied.
> I do not, but I can remove the patch and fire up a jenkins instance and see what explodes, to see if that can give us a good test case.
Ok, in this case wait a bit. I am almost finished with some changes to ::RU, I suppose starting testing after those are applied to your local tree is the saner thing to do, given the effort on your side is non-trivial. More in a bit.
RT-Send-CC: ribasushi [...] cpan.org
Download (untitled) / with headers
text/plain 353b
On 2016-08-09 10:56:50, RIBASUSHI wrote: Show quoted text
> Ok, in this case wait a bit. > > I am almost finished with some changes to ::RU, I suppose starting > testing after those are applied to your local tree is the saner thing > to do, given the effort on your side is non-trivial. > > More in a bit.
Checking in... are there any new developments on this front?
Subject: Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date: Fri, 7 Apr 2017 10:18:30 +0200
To: bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From: Peter Rabbitson <perl [...] leporine.io>
Download (untitled) / with headers
text/plain 667b
On 04/06/2017 10:25 PM, Karen Etheridge via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > On 2016-08-09 10:56:50, RIBASUSHI wrote: >
>> Ok, in this case wait a bit. >> >> I am almost finished with some changes to ::RU, I suppose starting >> testing after those are applied to your local tree is the saner thing >> to do, given the effort on your side is non-trivial. >> >> More in a bit.
> > Checking in... are there any new developments on this front? >
All work is blocked on #dbic-cabal getting their act together: https://twitter.com/ribasushi/status/847472053514981376 https://twitter.com/ribasushi/status/847558617926688768 Cheers
Subject: Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date: Fri, 7 Apr 2017 09:20:57 -0700
To: bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From: Karen Etheridge <karen [...] froods.org>
Download (untitled) / with headers
text/plain 990b
can you clarify what you need from the dbic cabal, or in the DBIx-Class codebase, to move forward? On Fri, Apr 7, 2017 at 1:27 AM, Peter Rabbitson via RT < bug-DBIx-Class-ResultSet-RecursiveUpdate@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > On 04/06/2017 10:25 PM, Karen Etheridge via RT wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > > > On 2016-08-09 10:56:50, RIBASUSHI wrote: > >
> >> Ok, in this case wait a bit. > >> > >> I am almost finished with some changes to ::RU, I suppose starting > >> testing after those are applied to your local tree is the saner thing > >> to do, given the effort on your side is non-trivial. > >> > >> More in a bit.
> > > > Checking in... are there any new developments on this front? > >
> > All work is blocked on #dbic-cabal getting their act together: > https://twitter.com/ribasushi/status/847472053514981376 > https://twitter.com/ribasushi/status/847558617926688768 > > Cheers >
Subject: Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date: Fri, 7 Apr 2017 18:27:23 +0200
To: bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From: Peter Rabbitson <perl [...] leporine.io>
Download (untitled) / with headers
text/plain 319b
On 04/07/2017 06:21 PM, Karen Etheridge via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > can you clarify what you need from the dbic cabal, or in the DBIx-Class > codebase, to move forward? >
https://github.com/dbsrgits/dbix-class/commit/7293955#diff-14a995427a39511927479ae4ffbbb9c7R2282
Subject: Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date: Fri, 7 Apr 2017 09:54:04 -0700
To: bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From: Karen Etheridge <karen [...] froods.org>
Download (untitled) / with headers
text/plain 651b
super, thanks! is that available in a branch, or does it have accompanying commits? I will try to find someone to merge it soon. On Fri, Apr 7, 2017 at 9:27 AM, Peter Rabbitson via RT < bug-DBIx-Class-ResultSet-RecursiveUpdate@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > On 04/07/2017 06:21 PM, Karen Etheridge via RT wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > > > can you clarify what you need from the dbic cabal, or in the DBIx-Class > > codebase, to move forward? > >
> > https://github.com/dbsrgits/dbix-class/commit/7293955#diff- > 14a995427a39511927479ae4ffbbb9c7R2282 >
Subject: Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date: Fri, 7 Apr 2017 19:02:44 +0200
To: bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From: Peter Rabbitson <perl [...] leporine.io>
Download (untitled) / with headers
text/plain 584b
On 04/07/2017 06:54 PM, Karen Etheridge via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > super, thanks! is that available in a branch, or does it have accompanying > commits? I will try to find someone to merge it soon. >
This is the "cap commit" of about ~2k lines of changes spread over 20ish commits. This is all already in master and tested against a massove portion of CPAN ( well it was tested 6 months ago, don't know what the state is today ). What is missing is a dev-release-cycle ( a minimum on 2 months would be needed ) and a release.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.