Skip Menu |
 

This queue is for tickets about the Carp CPAN distribution.

Report information
The Basics
Id: 100183
Status: open
Priority: 0/
Queue: Carp

People
Owner: Nobody in particular
Requestors: chris.donnelly [...] vauto.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Carp won't print $. if it is in "chunk" mode
Date: Fri, 7 Nov 2014 16:18:48 +0000
To: "bug-Carp [...] rt.cpan.org" <bug-Carp [...] rt.cpan.org>
From: "Donnelly, Chris R (VAT - Austin)" <chris.donnelly [...] vauto.com>
Download (untitled) / with headers
text/plain 397b
Carp version: 1.3301 The regex on line 437 explicitly looks for "line". I fixed it to look for line OR chunk (see attachment), but I don't know if those are the only possible values. (It looks like the die message does NOT get localized, though, so that's good.) Can you put this (or a more robust version thereof) into an upcoming release? I can use a local patch for now. Thanks, # Chris
Download Carp.pm.patch
text/x-diff 353b

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 1016b
On Fri Nov 07 11:19:04 2014, chris.donnelly@vauto.com wrote: Show quoted text
> Carp version: 1.3301 > > The regex on line 437 explicitly looks for "line". > > I fixed it to look for line OR chunk (see attachment), but I don't > know if those are the only possible values. (It looks like the die > message does NOT get localized, though, so that's good.) > > Can you put this (or a more robust version thereof) into an upcoming > release? I can use a local patch for now. > > Thanks, > # Chris
I wrote that regex, and didn't realize that 'chunk' is a possibility when I submitted the bug report it fixed. Sorry. This test case demonstrates the issue: perl -MCarp -e'$/=\10;while(<>){chomp; print "$_<\n";} carp "slow death"' abc ^D I have looked thru the Perl source & so far as I can tell, 'line' and 'chunk' are the only possible values. (Perl_mess_sv in Util.c) Your patch looks right to me. It would be good if Carp's owner would apply it, as I don't have commit privs for the core. The bug still exists in 1.38.
From: arc [...] cpan.org
Download (untitled) / with headers
text/plain 749b
On Sun Feb 07 16:46:21 2016, tlhackque wrote: Show quoted text
> On Fri Nov 07 11:19:04 2014, chris.donnelly@vauto.com wrote:
> > Carp version: 1.3301 > > > > The regex on line 437 explicitly looks for "line".
> > Your patch looks right to me. > > It would be good if Carp's owner would apply it, as I don't have > commit privs for the core. The bug still exists in 1.38.
I'm sorry this has gone so long without any attention. Perl is currently highly frozen in the run up to the 5.24.0 release, so the change can't be applied right now. However, I've pushed a branch with your fix (and a test): http://perl5.git.perl.org/perl.git/commitdiff/0d332ade3828d58a9bccd4db5b4df44aab9adc81 I expect to merge this to blead early in the 5.25.x cycle. -- Aaron Crane
From: arc [...] cpan.org
Download (untitled) / with headers
text/plain 448b
I wrote: Show quoted text
> Perl is currently highly frozen in the run up to the 5.24.0 release, > so the change can't be applied right now. > > I expect to merge this to blead early in the 5.25.x cycle.
This change has been applied to blead as commit 2f7a15bf0111b35a9af62de5c74e13855cb9cea3, and should be released as part of Perl 5.25.1 (due in a few days' time). Thank you, and my apologies again for how long it took for this to get merged. -- Aaron Crane


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.