Skip Menu |
 

This queue is for tickets about the Math-BigInt CPAN distribution.

Report information
The Basics
Id: 98185
Status: resolved
Priority: 0/
Queue: Math-BigInt

People
Owner: Nobody in particular
Requestors: lkundrak [...] v3.sk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.999705



CC: Lubomir Rintel <lkundrak [...] v3.sk>
X-Spam-Status: No, score=-2.568 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.668] autolearn=ham
X-Mailer: git-send-email 2.0.4
X-Spam-Flag: NO
Message-ID: <1408480208-6401-1-git-send-email-lkundrak [...] v3.sk>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Virus-Scanned: amavisd-new at zimbra.v3.sk
X-Spam-Score: -2.568
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 69DEE24041B for <cpan-bug+math-bigint [...] hipster.bestpractical.com>; Tue, 19 Aug 2014 16:30:33 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nYrlThFvs+0F for <cpan-bug+math-bigint [...] hipster.bestpractical.com>; Tue, 19 Aug 2014 16:30:32 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id E255E2403BD for <bug-math-bigint [...] rt.cpan.org>; Tue, 19 Aug 2014 16:30:31 -0400 (EDT)
Received: (qmail 30327 invoked by alias); 19 Aug 2014 20:30:30 -0000
Received: from shell.v3.sk (HELO shell.v3.sk) (195.168.3.45) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 19 Aug 2014 13:30:28 -0700
Received: from localhost (localhost [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 2F65081A3C for <bug-math-bigint [...] rt.cpan.org>; Tue, 19 Aug 2014 22:30:23 +0200 (CEST)
Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Y75T8WJ9xZ9A; Tue, 19 Aug 2014 22:30:19 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 1091581A45; Tue, 19 Aug 2014 22:30:19 +0200 (CEST)
Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id w-HOtG_P-pXH; Tue, 19 Aug 2014 22:30:18 +0200 (CEST)
Received: from goatlord.localdomain (ip-94-113-108-82.net.upcbroadband.cz [94.113.108.82]) by zimbra.v3.sk (Postfix) with ESMTPSA id 23DF681A3C; Tue, 19 Aug 2014 22:30:17 +0200 (CEST)
Delivered-To: cpan-bug+math-bigint [...] hipster.bestpractical.com
Subject: [PATCH] Avoid using my() in a condition
Return-Path: <lkundrak [...] v3.sk>
X-RT-Mail-Extension: math-bigint
X-Original-To: cpan-bug+math-bigint [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Date: Tue, 19 Aug 2014 22:30:08 +0200
X-Spam-Level:
To: bug-math-bigint [...] rt.cpan.org
From: Lubomir Rintel <lkundrak [...] v3.sk>
X-RT-Original-Encoding: ascii
content-type: text/plain; charset="utf-8"
X-RT-Interface: Email
Content-Length: 905
Download (untitled) / with headers
text/plain 905b
Due to an old bug, using my in a false conditional results in an accidental creation of a state (or "static" variable). See "Deprecated use of my() in false conditional" in perldiag(1). Unfortunately, due to another bug in interpreter, the warning fails to trigger if there's an assignment in variable declaration. This change removes a condition (which is useless anyway) to avoid the noise once the second bug is fixed and the warning triggers properly. --- lib/Math/BigFloat.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Math/BigFloat.pm b/lib/Math/BigFloat.pm index 28b18c1..07493cd 100755 --- a/lib/Math/BigFloat.pm +++ b/lib/Math/BigFloat.pm @@ -1263,7 +1263,7 @@ sub _log $over->bmul($u); $factor = $self->new(3); $f = $self->new(2); - my $steps = 0 if DEBUG; + my $steps = 0; $limit = $self->new("1E-". ($scale-1)); while (3 < 5) { -- 2.0.4


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.