Skip Menu |
 

This queue is for tickets about the FCGI CPAN distribution.

Report information
The Basics
Id: 97680
Status: resolved
Priority: 0/
Queue: FCGI

People
Owner: ether [...] cpan.org
Requestors: fraserbn [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.76

Attachments
0001-On-Android-set-TMPDIR-before-calling-configure.patch



Subject: [PATCH] On Android, set TMPDIR before calling configure
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
Message-ID: <rt-4.0.18-19816-1406922287-621.0-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1406922287-19816-2"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
Content-Length: 135
Download (untitled) / with headers
text/plain 135b
See the attached patch for an explanation -- I couldn't find Makefile.PL in the git repo, so this patch is against the latest tarball.
Subject: 0001-On-Android-set-TMPDIR-before-calling-configure.patch
MIME-Version: 1.0
Content-Type: application/octet-stream; name="0001-On-Android-set-TMPDIR-before-calling-configure.patch"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="0001-On-Android-set-TMPDIR-before-calling-configure.patch"
Content-Transfer-Encoding: base64
Content-Length: 1213
From 184517c315a35e28796d5817d278d59e354475ef Mon Sep 17 00:00:00 2001 From: Brian Fraser <fraserbn@gmail.com> Date: Fri, 1 Aug 2014 21:48:30 +0200 Subject: [PATCH] On Android, set TMPDIR before calling configure The full explanation for this is here: http://stackoverflow.com/questions/15283220/android-shell-eof In short, Android's sh has a bug in that writing cat <<EOF ... EOF will try creating a temporary file in /sqlite_stmt_journals, which may or may not exist, and may or may not be writeable by the current user. So instead do the right thing and set TMPDIR to whatever the current File::Spec->tmpdir returns. --- Makefile.PL | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Makefile.PL b/Makefile.PL index f35c97e..fdf7076 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -139,6 +139,11 @@ if ($sys eq "win32") { print "Please read configure.readme for information on how to run it yourself\n"; $ENV{'CC'} = $Config{'cc'}; + if ( $^O eq 'android' && !$ENV{'TMPDIR'} ) { + # See http://stackoverflow.com/a/15417261 + require File::Spec; + $ENV{'TMPDIR'} = File::Spec->tmpdir(); + } system("$Config{sh} configure"); } -- 1.7.12.4 (Apple Git-37)
X-Sa-Exim-Connect-Ip: 69.50.167.197
MIME-Version: 1.0
X-Spam-Status: No, score=-3.327 tagged_above=-99.9 required=10 tests=[AWL=0.573, BAYES_00=-1.9, FROM_OUR_RT=-2] autolearn=ham
In-Reply-To: <rt-4.0.18-19816-1406922287-557.97680-4-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-97680 [...] rt.cpan.org> <rt-4.0.18-19816-1406922287-557.97680-4-0 [...] rt.cpan.org>
X-Acl-Warn: !authenticated = *
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20140801203037.GQ97202 [...] tequila>
content-type: text/plain; charset="utf-8"
X-Spam-Score-Int: 0
X-RT-Original-Encoding: utf-8
X-Spam-Score: -3.327
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 3406C24042E for <cpan-bug+FCGI [...] hipster.bestpractical.com>; Fri, 1 Aug 2014 16:30:48 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zah5nV6NDO5r for <cpan-bug+FCGI [...] hipster.bestpractical.com>; Fri, 1 Aug 2014 16:30:46 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 646492400AD for <bug-FCGI [...] rt.cpan.org>; Fri, 1 Aug 2014 16:30:46 -0400 (EDT)
Received: (qmail 9823 invoked by alias); 1 Aug 2014 20:30:45 -0000
Received: from ns2.lightspeed.ca (HELO www.lightspeed.ca) (206.12.82.4) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 01 Aug 2014 13:30:42 -0700
Received: from 69-50-167-197.westerncable.ca ([69.50.167.197] helo=etheridge.ca) by www.lightspeed.ca with esmtp (Exim 4.80) (envelope-from <ether [...] cpan.org>) id 1XDJTJ-0002Vf-Qc for bug-FCGI [...] rt.cpan.org; Fri, 01 Aug 2014 13:30:37 -0700
Delivered-To: cpan-bug+FCGI [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #97680] [PATCH] On Android, set TMPDIR before calling configure
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Sa-Exim-Mail-From: ether [...] cpan.org
Return-Path: <ether [...] cpan.org>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+FCGI [...] hipster.bestpractical.com
X-RT-Mail-Extension: fcgi
Date: Fri, 1 Aug 2014 13:30:37 -0700
X-Sa-Exim-Scanned: No (on www.lightspeed.ca); SAEximRunCond expanded to false
X-Spam-Level:
X-Spam-Bar: /
To: Brian Fraser via RT <bug-FCGI [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
RT-Message-ID: <rt-4.0.18-25327-1406925048-1176.97680-0-0 [...] rt.cpan.org>
Content-Length: 630
Download (untitled) / with headers
text/plain 630b
On Fri, Aug 01, 2014 at 03:44:48PM -0400, Brian Fraser via RT wrote: Show quoted text
> The full explanation for this is here: > http://stackoverflow.com/questions/15283220/android-shell-eof > > In short, Android's sh has a bug in that writing > > cat <<EOF > ... > EOF > > will try creating a temporary file in /sqlite_stmt_journals, > which may or may not exist, and may or may not be writeable > by the current user. > So instead do the right thing and set TMPDIR to whatever the > current File::Spec->tmpdir returns.
Since this would affect everything using a here-doc, I wonder if this should not be done by ExtUtils::MakeMaker instead?
MIME-Version: 1.0
X-Spam-Status: No, score=-4.699 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-25327-1406925050-799.97680-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-97680 [...] rt.cpan.org> <rt-4.0.18-19816-1406922287-557.97680-4-0 [...] rt.cpan.org> <20140801203037.GQ97202 [...] tequila> <rt-4.0.18-25327-1406925050-799.97680-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.180.11.206 with SMTP id s14mr31878821wib.27.1407183470733; Mon, 04 Aug 2014 13:17:50 -0700 (PDT)
Message-ID: <CA+nL+nYPGXM9vKGneL8Xfdx7e0EVLZg5obnkaLHxjzDaCjGD2w [...] mail.gmail.com>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -4.699
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 53CBA2403ED for <cpan-bug+FCGI [...] hipster.bestpractical.com>; Mon, 4 Aug 2014 16:18:02 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ToYSSKgmfiZF for <cpan-bug+FCGI [...] hipster.bestpractical.com>; Mon, 4 Aug 2014 16:18:00 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id B84552402DE for <bug-FCGI [...] rt.cpan.org>; Mon, 4 Aug 2014 16:18:00 -0400 (EDT)
Received: (qmail 10586 invoked by alias); 4 Aug 2014 20:18:00 -0000
Received: from mail-we0-f171.google.com (HELO mail-we0-f171.google.com) (74.125.82.171) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 04 Aug 2014 13:17:57 -0700
Received: by mail-we0-f171.google.com with SMTP id p10so8364285wes.16 for <bug-FCGI [...] rt.cpan.org>; Mon, 04 Aug 2014 13:17:51 -0700 (PDT)
Received: by 10.216.88.68 with HTTP; Mon, 4 Aug 2014 13:17:50 -0700 (PDT)
Delivered-To: cpan-bug+FCGI [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #97680] [PATCH] On Android, set TMPDIR before calling configure
Return-Path: <fraserbn [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=r2cTkADn+l07qoyjVvpw6I/wRlUrWodGP2Bb7e96YE0=; b=d1OfjDdJP8YLnvi8/h3GxBVFlfMQu7tctOWWjjS0SIogF0dn/FMgGuQ0/iPjNQ/Z+r SJZwGvV4tNYPbeoPYNwRqHswc2EAvXW29xMMW8ZHkB7TopXpxWWslMR8h623utO51Jg6 xEweS5zIB3PdfuA9PNaIN3I4OwCLVSirQ26NX/dY+lneLsxUkgPg2ajRxnuIDPSVjTn2 kycWQ8HHz7BhUjdIc3YzzrE6ILtc5RxzVoJp7uNAA2/GwZsapch+ANzPe0sp6jAvGSxn BaDksRnpWWMGGHaj2YmdVlBjP36OGPPSwPJ+ixDtnRW5hZbEVxtINuhisrQOMrEPtCun Boxg==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+FCGI [...] hipster.bestpractical.com
X-RT-Mail-Extension: fcgi
Date: Mon, 4 Aug 2014 22:17:50 +0200
X-Spam-Level:
To: bug-FCGI [...] rt.cpan.org
From: Brian Fraser <fraserbn [...] gmail.com>
RT-Message-ID: <rt-4.0.18-8804-1407183483-228.97680-0-0 [...] rt.cpan.org>
Content-Length: 1046
On Fri, Aug 1, 2014 at 10:30 PM, Karen Etheridge via RT <bug-FCGI@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=97680 > > > On Fri, Aug 01, 2014 at 03:44:48PM -0400, Brian Fraser via RT wrote:
>> The full explanation for this is here: >> http://stackoverflow.com/questions/15283220/android-shell-eof >> >> In short, Android's sh has a bug in that writing >> >> cat <<EOF >> ... >> EOF >> >> will try creating a temporary file in /sqlite_stmt_journals, >> which may or may not exist, and may or may not be writeable >> by the current user. >> So instead do the right thing and set TMPDIR to whatever the >> current File::Spec->tmpdir returns.
> > Since this would affect everything using a here-doc, I wonder if this > should not be done by ExtUtils::MakeMaker instead? >
Hm.. maybe, but out of ~900 different distributions I've installed on Android, this is the only module with this problem, so it's probably not worth adding it to MM. That being said, if it comes up a couple more times, I'll file a patch against MM.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-8804-1407183483-228.97680-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-97680 [...] rt.cpan.org> <rt-4.0.18-19816-1406922287-557.97680-4-0 [...] rt.cpan.org> <20140801203037.GQ97202 [...] tequila> <rt-4.0.18-25327-1406925050-799.97680-6-0 [...] rt.cpan.org> <CA+nL+nYPGXM9vKGneL8Xfdx7e0EVLZg5obnkaLHxjzDaCjGD2w [...] mail.gmail.com> <rt-4.0.18-8804-1407183483-228.97680-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-9692-1407202148-770.97680-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 21
Ok, released as 0.76!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.