Skip Menu |
 

This queue is for tickets about the Archive-Zip CPAN distribution.

Report information
The Basics
Id: 96572
Status: new
Priority: 0/
Queue: Archive-Zip

People
Owner: Nobody in particular
Requestors: johannes.ernst [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



MIME-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\))
X-Google-Original-From: Johannes Ernst <Johannes.Ernst [...] gmail.com>
X-Spam-Status: No, score=-2.699 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
X-Mailer: Apple Mail (2.1878.2)
X-Spam-Flag: NO
Message-ID: <D6CDED88-823C-47CE-9563-1CE13927FC25 [...] gmail.com>
content-type: text/plain; charset="utf-8"
X-Received: by 10.66.145.233 with SMTP id sx9mr9436049pab.151.1403223426747; Thu, 19 Jun 2014 17:17:06 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -2.699
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 3418924060E for <cpan-bug+Archive-Zip [...] hipster.bestpractical.com>; Thu, 19 Jun 2014 20:17:16 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S1e2rlzlTV8R for <cpan-bug+Archive-Zip [...] hipster.bestpractical.com>; Thu, 19 Jun 2014 20:17:15 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id D93A024023D for <bug-Archive-Zip [...] rt.cpan.org>; Thu, 19 Jun 2014 20:17:14 -0400 (EDT)
Received: (qmail 21463 invoked by alias); 20 Jun 2014 00:17:13 -0000
Received: from mail-pa0-f54.google.com (HELO mail-pa0-f54.google.com) (209.85.220.54) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Thu, 19 Jun 2014 17:17:11 -0700
Received: by mail-pa0-f54.google.com with SMTP id et14so2428476pad.41 for <bug-Archive-Zip [...] rt.cpan.org>; Thu, 19 Jun 2014 17:17:07 -0700 (PDT)
Received: from sharpwifi.aviatis.com (c-107-3-142-14.hsd1.ca.comcast.net. [107.3.142.14]) by mx.google.com with ESMTPSA id jb5sm10446166pbd.73.2014.06.19.17.17.05 for <bug-Archive-Zip [...] rt.cpan.org> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Jun 2014 17:17:06 -0700 (PDT)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Delivered-To: cpan-bug+Archive-Zip [...] hipster.bestpractical.com
Subject: Missing return statement in /usr/share/perl5/vendor_perl/Archive/Zip/Member.pm::extractToFileNamed
Return-Path: <johannes.ernst [...] gmail.com>
X-RT-Mail-Extension: archive-zip
X-Original-To: cpan-bug+Archive-Zip [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:content-transfer-encoding:subject:message-id:date :to:mime-version; bh=LFB0wvdFX6eRkxUvthidhnoI3fqyR2+IhjKjV0cJ4Qk=; b=bU44vw9PJEEdRQS1X5YjXfHCbPbvwLgNrX61zVeqvESJma6zIyTJggTvVJrAlF+Ctz AjvyAzlZJ2ZqFuC9td1QJtzkQiajZ2+ACmH+rzsYGgCGlXCVsd+p0HKQ79ZWqefmmIOW 59PF1KNaGja7d62T2NdIni2+nxcaskps0JRR4uru8Ac0IIWZDRArj2+C7Fw+X448b5kH RUOlwlwb6y2yM3DDMZe+6sB8zota0vYW/SFyChwNblA8vadJYIjSuXEMSCyfYvUFaK91 TLH4DxLsN1gr9F6vSML8VujoD75WCXC+H2/tAxUFc7HicBGsRh2j4AXygJGOLBv7/eai dwpg==
Date: Thu, 19 Jun 2014 17:17:04 -0700
X-Spam-Level:
To: bug-Archive-Zip [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Johannes Ernst <johannes.ernst [...] gmail.com>
X-RT-Original-Encoding: ascii
X-RT-Interface: Email
Content-Length: 1806
Download (untitled) / with headers
text/plain 1.7k
From http://svn.ali.as/cpan/trunk/Archive-Zip/lib/Archive/Zip/Member.pm: Note single *** marked line that is missing. As a result, some of my archives stop unpacking after they have encountered a random symlink. sub extractToFileNamed { my $self = shift; # local FS name my $name = ( ref( $_[0] ) eq 'HASH' ) ? $_[0]->{name} : $_[0]; $self->{'isSymbolicLink'} = 0; # Check if the file / directory is a symbolic link or not if ( $self->{'externalFileAttributes'} == 0xA1FF0000 ) { $self->{'isSymbolicLink'} = 1; $self->{'newName'} = $name; my ( $status, $fh ) = _newFileHandle( $name, 'r' ); my $retval = $self->extractToFileHandle($fh); $fh->close(); *** return $retval; *** } else { #return _writeSymbolicLink($self, $name) if $self->isSymbolicLink(); my ( $status, $fh ); if ( $^O eq 'MSWin32' && $Archive::Zip::UNICODE ) { $name = decode_utf8( Win32::GetFullPathName($name) ); mkpath_win32($name); if ( $self->{'compressedSize'} == 0 ) { return; } else { Win32::CreateFile($name); } ( $status, $fh ) = _newFileHandle( Win32::GetANSIPathName($name), 'w' ); } else { mkpath( dirname($name) ); # croaks on error ( $status, $fh ) = _newFileHandle( $name, 'w' ); } return _ioError("Can't open file $name for write") unless $status; my $retval = $self->extractToFileHandle($fh); $fh->close(); chmod ($self->unixFileAttributes(), $name) or return _error("Can't chmod() ${name}: $!"); utime( $self->lastModTime(), $self->lastModTime(), $name ); return $retval; } }


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.