Skip Menu |
 

This queue is for tickets about the Scalar-List-Utils CPAN distribution.

Report information
The Basics
Id: 94806
Status: resolved
Priority: 0/
Queue: Scalar-List-Utils

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.39



Subject: looks_like_number exposes internal details inappropriately
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-16654-1397675483-80.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 89
It should instead return a boolean. see https://rt.cpan.org/Ticket/Display.html?id=94805
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-16654-1397675483-80.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
References: <rt-4.0.18-16654-1397675483-80.0-0-0 [...] rt.cpan.org>
Content-Type: multipart/mixed; boundary="----------=_1401978505-6285-4"
Message-ID: <rt-4.0.18-6285-1401978505-653.94806-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 165
Download (untitled) / with headers
text/plain 165b
On Wed Apr 16 15:11:24 2014, ETHER wrote: Show quoted text
> It should instead return a boolean. see > https://rt.cpan.org/Ticket/Display.html?id=94805
Seems good. -- Paul Evans
MIME-Version: 1.0
Subject: rt94806.patch
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Type: text/x-diff; name="rt94806.patch"
Content-Disposition: inline; filename="rt94806.patch"
Content-Transfer-Encoding: binary
Content-Length: 499
Download rt94806.patch
text/x-diff 499b
diff --git a/ListUtil.xs b/ListUtil.xs index 5d66ee0..84be2f1 100644 --- a/ListUtil.xs +++ b/ListUtil.xs @@ -1076,13 +1076,13 @@ CODE: } #if PERL_BCDVERSION < 0x5008005 if(SvPOK(sv) || SvPOKp(sv)) { - RETVAL = looks_like_number(sv); + RETVAL = !!looks_like_number(sv); } else { RETVAL = SvFLAGS(sv) & (SVf_NOK|SVp_NOK|SVf_IOK|SVp_IOK); } #else - RETVAL = looks_like_number(sv); + RETVAL = !!looks_like_number(sv); #endif OUTPUT: RETVAL
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-16654-1397675483-80.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-16654-1397675483-80.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-6268-1402051716-259.94806-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 33
Released in 1.39 -- Paul Evans


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.