Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 94087
Status: open
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



MIME-Version: 1.0
X-Spam-Status: No, score=-2.049 tagged_above=-99.9 required=10 tests=[AWL=-0.138, BAYES_00=-1.9, SPF_HELO_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Content-Disposition: inline
X-Spam-Flag: NO
content-type: text/plain; charset="utf-8"
Message-ID: <20140321143458.GS18071 [...] fysh.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -2.049
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id D39EA2403FE for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 21 Mar 2014 10:35:13 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Cy1mekxggYjf for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 21 Mar 2014 10:35:12 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id C3994240490 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 21 Mar 2014 10:35:11 -0400 (EDT)
Received: (qmail 31993 invoked by alias); 21 Mar 2014 14:35:11 -0000
Received: from river.fysh.org (HELO river.fysh.org) (5.135.154.127) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 21 Mar 2014 07:35:09 -0700
Received: from zefram by river.fysh.org with local (Exim 4.80 #2 (Debian)) id 1WR0XC-0000Zu-Tt; Fri, 21 Mar 2014 14:34:58 +0000
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: t/20_policies.t fail on 5.19.10
Return-Path: <zefram [...] fysh.org>
X-RT-Mail-Extension: perl-critic
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Date: Fri, 21 Mar 2014 14:34:58 +0000
X-Spam-Level:
To: bug-Perl-Critic [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
X-RT-Original-Encoding: ascii
X-RT-Interface: Email
Content-Length: 1842
Download (untitled) / with headers
text/plain 1.7k
On Perl 5.19.10: t/20_policies.t ............................... 705/2675 # Failed test 'Modules::RequireVersionVar - line 72 - Readonly VERSION' # at t/20_policies.t line 27. # Expected 0 violations, got 1. Found violations follow... # Found violation: No package-scoped "$VERSION" variable found at line 1, column 1. () # Failed test 'Modules::RequireVersionVar - line 80 - Readonly::Scalar VERSION' # at t/20_policies.t line 27. # Expected 0 violations, got 1. Found violations follow... # Found violation: No package-scoped "$VERSION" variable found at line 1, column 1. () # Failed test 'NamingConventions::Capitalization - line 53 - Special case: main' # at t/20_policies.t line 27. # Expected 0 violations, got 1. Found violations follow... # Found violation: Package "main" does not start with a upper case letter at line 2, column 1. (package main;) t/20_policies.t ............................... 2465/2675 # Failed test 'Variables::ProhibitPerl4PackageNames - line 230 - $POSTMATCH' # at t/20_policies.t line 27. # Expected 0 violations, got 2. Found violations follow... # Found violation: "$'" uses the obsolete single quote package separator." at line 2, column 8. ($foo = $';) # Found violation: "$'" uses the obsolete single quote package separator." at line 3, column 7. (print $';) t/20_policies.t ............................... 2661/2675 # Failed test 'Variables::RequireNegativeIndices - line 26 - Basic failure' # at t/20_policies.t line 27. # Expected 5 violations, got 0. # Failed test 'Variables::RequireNegativeIndices - line 38 - Complex failures' # at t/20_policies.t line 27. # Expected 8 violations, got 0. # Looks like you failed 6 tests of 2675. t/20_policies.t ............................... Dubious, test returned 6 (wstat 1536, 0x600) Failed 6/2675 subtests -zefram
MIME-Version: 1.0
X-Spam-Status: No, score=-3.056 tagged_above=-99.9 required=10 tests=[AWL=0.855, BAYES_00=-1.9, FROM_OUR_RT=-2, SPF_HELO_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
In-Reply-To: <rt-4.0.18-305-1395412514-831.94087-3-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-94087 [...] rt.cpan.org> <20140321143458.GS18071 [...] fysh.org> <rt-4.0.18-305-1395412514-831.94087-3-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20140321153153.GA9175 [...] fysh.org>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -3.056
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 03CF52403D5 for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 21 Mar 2014 11:32:08 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rHCDXKl9if4S for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Fri, 21 Mar 2014 11:32:07 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id B87A62400C2 for <bug-Perl-Critic [...] rt.cpan.org>; Fri, 21 Mar 2014 11:32:06 -0400 (EDT)
Received: (qmail 5220 invoked by alias); 21 Mar 2014 15:32:05 -0000
Received: from river.fysh.org (HELO river.fysh.org) (5.135.154.127) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 21 Mar 2014 08:32:04 -0700
Received: from zefram by river.fysh.org with local (Exim 4.80 #2 (Debian)) id 1WR1QH-0002Oc-NY; Fri, 21 Mar 2014 15:31:53 +0000
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #94087] AutoReply: t/20_policies.t fail on 5.19.10
Return-Path: <zefram [...] fysh.org>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic
Date: Fri, 21 Mar 2014 15:31:53 +0000
X-Spam-Level:
To: Bugs in Perl-Critic via RT <bug-Perl-Critic [...] rt.cpan.org>
From: Zefram <zefram [...] fysh.org>
RT-Message-ID: <rt-4.0.18-6001-1395415928-317.94087-0-0 [...] rt.cpan.org>
Content-Length: 148
Download (untitled) / with headers
text/plain 148b
Aaron Crane comments that this is almost certainly due to [perl #121484], as removing all the /m flags from the code makes the tests pass. -zefram
MIME-Version: 1.0
X-Spam-Status: No, score=-4.599 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, FROM_OUR_RT=-2, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-6001-1395415928-1170.94087-5-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-94087 [...] rt.cpan.org> <20140321143458.GS18071 [...] fysh.org> <rt-4.0.18-305-1395412514-831.94087-3-0 [...] rt.cpan.org> <20140321153153.GA9175 [...] fysh.org> <rt-4.0.18-6001-1395415928-1170.94087-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.180.106.40 with SMTP id gr8mr26776836wib.31.1395791168523; Tue, 25 Mar 2014 16:46:08 -0700 (PDT)
Message-ID: <CABE6C1Hnktwk-XwdZ62T9_vfC5PX7YNFcgp3hJapr-oz_OBHxw [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="f46d044519a9c7e9d804f576f457"
X-Spam-Score: -4.599
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 0074A24059E for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Tue, 25 Mar 2014 19:46:16 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PnIjwNg4NHOL for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Tue, 25 Mar 2014 19:46:16 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id CE673240543 for <bug-Perl-Critic [...] rt.cpan.org>; Tue, 25 Mar 2014 19:46:15 -0400 (EDT)
Received: (qmail 29873 invoked by alias); 25 Mar 2014 23:46:15 -0000
Received: from mail-wi0-f169.google.com (HELO mail-wi0-f169.google.com) (209.85.212.169) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 25 Mar 2014 16:46:13 -0700
Received: by mail-wi0-f169.google.com with SMTP id hm4so4009716wib.2 for <bug-Perl-Critic [...] rt.cpan.org>; Tue, 25 Mar 2014 16:46:08 -0700 (PDT)
Received: by 10.180.19.164 with HTTP; Tue, 25 Mar 2014 16:46:08 -0700 (PDT)
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #94087] AutoReply: t/20_policies.t fail on 5.19.10
Return-Path: <jeff [...] imaginative-software.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=t0cjVIOE298JGpjbm0MrhIdJUp8dORuPDS8B8CoB/cY=; b=PIJeeJzavIWyPErXHDFGaQXp3+voW8V2s70znJdmPHuRTWJDtyJ0mXfG6W664VfNKD o8uCpQXKVhAKB/UYxkNaQ6W+wBO1yXT9XWbqAgI7IiAoFnplWMXwi5xEihrwGwJFOEBV v3p6uFQSnt1OcSi+Sjs8Z950OqW+Jwcb2537/mggvD+6P0RUiTHIFWF+MYjAn4uDHfrA 6qWIQRR2SUwZLaJtFE3L4u/UHY/K7SJLm0LI7yRI3tNHmF7aFVOmRUzVGiEmmGQjCoju Xcr9RruF7v5yGSswSkDj3GDYXy0Iomc0wXVnPP5gpfENiiQSPVaUUN4C5yvb6iZOQ+BV rwcA==
Date: Tue, 25 Mar 2014 16:46:08 -0700
X-Spam-Level:
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
X-GM-Message-State: ALoCoQkVLDq+4eUEQK0603+JvWsrf7VCiOKRJl4jpeo8jngQ1N737Ko6WKyeXK9at5LO2tShy0de
From: "Thalhammer, Jeffrey Ryan" <jeff [...] imaginative-software.com>
RT-Message-ID: <rt-4.0.18-26935-1395791177-331.94087-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 183
Download (untitled) / with headers
text/plain 183b
Thanks Zefram. I read #121484, and it sounds like the problem lies with 5.19 and fixed in commit 7742aa66. So no action should be required in Perl::Critic. Or have I misunderstood?
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 238
MIME-Version: 1.0
X-Spam-Status: No, score=-3.064 tagged_above=-99.9 required=10 tests=[AWL=0.847, BAYES_00=-1.9, FROM_OUR_RT=-2, SPF_HELO_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
In-Reply-To: <rt-4.0.18-26935-1395791178-1591.94087-6-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-94087 [...] rt.cpan.org> <20140321143458.GS18071 [...] fysh.org> <rt-4.0.18-305-1395412514-831.94087-3-0 [...] rt.cpan.org> <20140321153153.GA9175 [...] fysh.org> <rt-4.0.18-6001-1395415928-1170.94087-5-0 [...] rt.cpan.org> <CABE6C1Hnktwk-XwdZ62T9_vfC5PX7YNFcgp3hJapr-oz_OBHxw [...] mail.gmail.com> <rt-4.0.18-26935-1395791178-1591.94087-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20140326063913.GI18071 [...] fysh.org>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -3.064
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id A8ED22405D4 for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Wed, 26 Mar 2014 02:39:24 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qotoeu3fksBy for <cpan-bug+Perl-Critic [...] hipster.bestpractical.com>; Wed, 26 Mar 2014 02:39:23 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id E201224059F for <bug-Perl-Critic [...] rt.cpan.org>; Wed, 26 Mar 2014 02:39:22 -0400 (EDT)
Received: (qmail 21623 invoked by alias); 26 Mar 2014 06:39:21 -0000
Received: from river.fysh.org (HELO river.fysh.org) (5.135.154.127) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 25 Mar 2014 23:39:20 -0700
Received: from zefram by river.fysh.org with local (Exim 4.80 #2 (Debian)) id 1WShUX-0000t8-DS; Wed, 26 Mar 2014 06:39:13 +0000
Delivered-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #94087] AutoReply: t/20_policies.t fail on 5.19.10
Return-Path: <zefram [...] fysh.org>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic
Date: Wed, 26 Mar 2014 06:39:13 +0000
X-Spam-Level:
To: Jeffrey Thalhammer via RT <bug-Perl-Critic [...] rt.cpan.org>
From: Zefram <zefram [...] fysh.org>
RT-Message-ID: <rt-4.0.18-15180-1395815965-1750.94087-0-0 [...] rt.cpan.org>
Content-Length: 267
Download (untitled) / with headers
text/plain 267b
Jeffrey Thalhammer via RT wrote: Show quoted text
>Thanks Zefram. I read #121484, and it sounds like the problem lies with >5.19 and fixed in commit 7742aa66. So no action should be required in >Perl::Critic. Or have I misunderstood?
No further action should be required. -zefram


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.