Skip Menu |
 

This queue is for tickets about the Test-Perl-Critic-Progressive CPAN distribution.

Report information
The Basics
Id: 93744
Status: new
Priority: 0/
Queue: Test-Perl-Critic-Progressive

People
Owner: Nobody in particular
Requestors: ran.eilam [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: diag() and note() should be called after, not before $TEST->ok()
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-23539-1394518415-497.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 415
Download (untitled) / with headers
text/plain 415b
Test::More, and everybody else I could find do it this way. Except Test::Vars that is, but that is being fixed. Test::Perl::Critic does it the correct way, but Test::Perl::Critic::Progressive, for implementation reasons, first sends out diag() messages, then calls $TEST->ok(). I we don't fix this, there are several cases where it is impossible for TAP formatters to understand where the diag() messages belong.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-23539-1394518415-497.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-23539-1394518415-497.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-21477-1394554037-901.93744-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 78


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.