Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Sereal-Encoder CPAN distribution.

Report information
The Basics
Id:
93615
Status:
open
Priority:
Low/Low

People
Owner:
Nobody in particular
Requestors:
zefram [...] fysh.org
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



From zefram@fysh.org Fri Mar 7 12: 16:50 2014
MIME-Version: 1.0
X-Spam-Status: No, score=-2.255 tagged_above=-99.9 required=10 tests=[AWL=0.181, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.535, SPF_HELO_PASS=-0.001] autolearn=ham
Content-Disposition: inline
X-Spam-Flag: NO
X-Virus-Checked: Checked
Content-Type: multipart/mixed; boundary="76DTJ5CE0DCVQemd"
Message-ID: <20140307171638.GQ18071@fysh.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -2.255
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 652A5240562 for <cpan-bug+Sereal-Encoder@hipster.bestpractical.com>; Fri, 7 Mar 2014 12:16:50 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R+mmelxeVveU for <cpan-bug+Sereal-Encoder@hipster.bestpractical.com>; Fri, 7 Mar 2014 12:16:49 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id CB35D240124 for <bug-Sereal-Encoder@rt.cpan.org>; Fri, 7 Mar 2014 12:16:48 -0500 (EST)
Received: (qmail 32227 invoked by alias); 7 Mar 2014 17:16:48 -0000
Received: from river.fysh.org (HELO river.fysh.org) (5.135.154.127) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 07 Mar 2014 09:16:45 -0800
Received: from zefram by river.fysh.org with local (Exim 4.80 #2 (Debian)) id 1WLyNy-0002OO-7g; Fri, 07 Mar 2014 17:16:38 +0000
Delivered-To: cpan-bug+Sereal-Encoder@hipster.bestpractical.com
Subject: custom op implementation
Return-Path: <zefram@fysh.org>
X-RT-Mail-Extension: sereal-encoder
X-Original-To: cpan-bug+Sereal-Encoder@hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Date: Fri, 7 Mar 2014 17:16:38 +0000
X-Spam-Level:
To: bug-Sereal-Encoder@rt.cpan.org
From: Zefram <zefram@fysh.org>
X-RT-Interface: Email
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Disposition: inline
X-RT-Original-Encoding: ascii
Content-Length: 525
Attached patch implements custom op optimisation for Sereal-Encoder. Same deal as for Sereal-Decoder. Should maintain Perl version portability, but not actually tested. Patch lacks tests for the new exportable sub. This one is considerably simpler than Sereal-Decoder, because there's only one affected sub. Rate method function op method 2.33738e+06+-59/s -- -12.3% -21.4% function 2.66585e+06+-7.4/s 14.1% -- -10.4% op 2.97563e+06+-9.2/s 27.3% 11.6% -- -zefram
Content-Type: text/x-diff; charset="us-ascii"
Content-Disposition: attachment; filename="custom_op.patch"
X-RT-Original-Encoding: ascii
Content-Length: 6820

Message body is not shown because sender requested not to inline it.

From demerphq@gmail.com Mon Mar 10 03: 36:21 2014
MIME-Version: 1.0
X-Spam-Status: No, score=-2.68 tagged_above=-99.9 required=10 tests=[AWL=0.019, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-10052-1394212611-1065.93615-4-0@rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-93615@rt.cpan.org> <20140307171638.GQ18071@fysh.org> <rt-4.0.18-10052-1394212611-1065.93615-4-0@rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.140.97.37 with SMTP id l34mr37034205qge.56.1394436972457; Mon, 10 Mar 2014 00:36:12 -0700 (PDT)
Message-ID: <CANgJU+UB+cVdSgagRXBFvCE0v3L4i_EDaZotFPnSHqtQYXD2_Q@mail.gmail.com>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -2.68
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i=@gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 42B952403A6 for <cpan-bug+Sereal-Encoder@hipster.bestpractical.com>; Mon, 10 Mar 2014 03:36:21 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q+rDQq6HPLLs for <cpan-bug+Sereal-Encoder@hipster.bestpractical.com>; Mon, 10 Mar 2014 03:36:19 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 9878C2400AC for <bug-Sereal-Encoder@rt.cpan.org>; Mon, 10 Mar 2014 03:36:19 -0400 (EDT)
Received: (qmail 21673 invoked by alias); 10 Mar 2014 07:36:18 -0000
Received: from mail-qc0-f173.google.com (HELO mail-qc0-f173.google.com) (209.85.216.173) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 10 Mar 2014 00:36:16 -0700
Received: by mail-qc0-f173.google.com with SMTP id r5so7295662qcx.32 for <bug-Sereal-Encoder@rt.cpan.org>; Mon, 10 Mar 2014 00:36:12 -0700 (PDT)
Received: by 10.140.104.200 with HTTP; Mon, 10 Mar 2014 00:36:12 -0700 (PDT)
Delivered-To: cpan-bug+Sereal-Encoder@hipster.bestpractical.com
Subject: Re: [rt.cpan.org #93615] custom op implementation
Return-Path: <demerphq@gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=fiChEIKNs2UQf0zYqYT4PZbF+wb125n2a8R3tSKAhNQ=; b=DxQuK0QXILexy1sl5ie9quLBaOq8ZGCZU20tIWJlj7NEXbJFHuyZ43yGYQsJJ6/Qbo 0X+GtTD83Z71c8nTUkglFl87d+Zm9w7T4iW6k22DcK7TNUUMeLtU3RVYmGegNnenAJSB oI0MToIHZxrmiDKvjjZ2nczU4vpu0FdS1IzOwi4oiPrpzs7/A9TIHWDzWYBbdjhHXQ9K bRxjX92MWArde9ce7WN6GWSUc1mSWPvIGWVLMaRIduXIBPdLSr8CBbHdcqz3isjX7Pek C82VPTTTKmqEWbuOPR3nqdKnB1cIsCK8mlt/QDBq2bc1jKRpkOZeUqA9VeCuPuDIg34N S2Ng==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Sereal-Encoder@hipster.bestpractical.com
X-RT-Mail-Extension: sereal-encoder
Date: Mon, 10 Mar 2014 08:36:12 +0100
X-Spam-Level:
To: bug-Sereal-Encoder@rt.cpan.org
From: demerphq <demerphq@gmail.com>
RT-Message-ID: <rt-4.0.18-10462-1394436982-1895.93615-0-0@rt.cpan.org>
Content-Length: 1138
Please review "custom_op" branch. I have not merged your comments yet. Yves On 7 March 2014 18:16, Zefram via RT <bug-Sereal-Encoder@rt.cpan.org> wrote:
Show quoted text
> Fri Mar 07 12:16:51 2014: Request 93615 was acted upon. > Transaction: Ticket created by zefram@fysh.org > Queue: Sereal-Encoder > Subject: custom op implementation > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: zefram@fysh.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=93615 > > > > Attached patch implements custom op optimisation for Sereal-Encoder. Same > deal as for Sereal-Decoder. Should maintain Perl version portability, > but not actually tested. Patch lacks tests for the new exportable sub. > This one is considerably simpler than Sereal-Decoder, because there's > only one affected sub. > > Rate method function op > method 2.33738e+06+-59/s -- -12.3% -21.4% > function 2.66585e+06+-7.4/s 14.1% -- -10.4% > op 2.97563e+06+-9.2/s 27.3% 11.6% -- > > -zefram >
-- perl -Mre=debug -e "/just|another|perl|hacker/"
From zefram@fysh.org Wed Mar 12 09: 13:08 2014
MIME-Version: 1.0
X-Spam-Status: No, score=-2.265 tagged_above=-99.9 required=10 tests=[AWL=0.171, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.535, SPF_HELO_PASS=-0.001] autolearn=ham
In-Reply-To: <rt-4.0.18-10462-1394436982-754.93615-6-0@rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-93615@rt.cpan.org> <20140307171638.GQ18071@fysh.org> <rt-4.0.18-10052-1394212611-1065.93615-4-0@rt.cpan.org> <CANgJU+UB+cVdSgagRXBFvCE0v3L4i_EDaZotFPnSHqtQYXD2_Q@mail.gmail.com> <rt-4.0.18-10462-1394436982-754.93615-6-0@rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20140312131258.GX18071@fysh.org>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -2.265
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E7C1D24046A for <cpan-bug+Sereal-Encoder@hipster.bestpractical.com>; Wed, 12 Mar 2014 09:13:08 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zPvJUr0CGWkZ for <cpan-bug+Sereal-Encoder@hipster.bestpractical.com>; Wed, 12 Mar 2014 09:13:08 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id E53B2240344 for <bug-Sereal-Encoder@rt.cpan.org>; Wed, 12 Mar 2014 09:13:07 -0400 (EDT)
Received: (qmail 2144 invoked by alias); 12 Mar 2014 13:13:06 -0000
Received: from river.fysh.org (HELO river.fysh.org) (5.135.154.127) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Wed, 12 Mar 2014 06:13:05 -0700
Received: from zefram by river.fysh.org with local (Exim 4.80 #2 (Debian)) id 1WNixu-0003AW-JX; Wed, 12 Mar 2014 13:12:58 +0000
Delivered-To: cpan-bug+Sereal-Encoder@hipster.bestpractical.com
Subject: Re: [rt.cpan.org #93615] custom op implementation
Return-Path: <zefram@fysh.org>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Sereal-Encoder@hipster.bestpractical.com
X-RT-Mail-Extension: sereal-encoder
Date: Wed, 12 Mar 2014 13:12:58 +0000
X-Spam-Level:
To: demerphq via RT <bug-Sereal-Encoder@rt.cpan.org>
From: Zefram <zefram@fysh.org>
RT-Message-ID: <rt-4.0.18-28087-1394629989-110.93615-0-0@rt.cpan.org>
Content-Length: 196
demerphq via RT wrote:
Show quoted text
>Please review "custom_op" branch. I have not merged your comments yet.
Looks fine from inspection, and passes tests for me on various Perls from 5.8.8 to 5.19.8. -zefram
From zefram@fysh.org Mon Mar 17 07: 24:14 2014
MIME-Version: 1.0
X-Spam-Status: No, score=-3.045 tagged_above=-99.9 required=10 tests=[AWL=0.866, BAYES_00=-1.9, FROM_OUR_RT=-2, SPF_HELO_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
In-Reply-To: <20140312131258.GX18071@fysh.org>
Content-Disposition: inline
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-93615@rt.cpan.org> <20140307171638.GQ18071@fysh.org> <rt-4.0.18-10052-1394212611-1065.93615-4-0@rt.cpan.org> <CANgJU+UB+cVdSgagRXBFvCE0v3L4i_EDaZotFPnSHqtQYXD2_Q@mail.gmail.com> <rt-4.0.18-10462-1394436982-754.93615-6-0@rt.cpan.org> <20140312131258.GX18071@fysh.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20140317112353.GA2907@fysh.org>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -3.045
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 0550B2403A6 for <cpan-bug+Sereal-Encoder@hipster.bestpractical.com>; Mon, 17 Mar 2014 07:24:14 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SuVq5QWhfwcf for <cpan-bug+Sereal-Encoder@hipster.bestpractical.com>; Mon, 17 Mar 2014 07:24:13 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id ACB8324037F for <bug-Sereal-Encoder@rt.cpan.org>; Mon, 17 Mar 2014 07:24:12 -0400 (EDT)
Received: (qmail 14598 invoked by alias); 17 Mar 2014 11:24:12 -0000
Received: from river.fysh.org (HELO river.fysh.org) (5.135.154.127) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 17 Mar 2014 04:24:10 -0700
Received: from zefram by river.fysh.org with local (Exim 4.80 #2 (Debian)) id 1WPVe5-0000uR-0Z; Mon, 17 Mar 2014 11:23:53 +0000
Delivered-To: cpan-bug+Sereal-Encoder@hipster.bestpractical.com
Subject: Re: [rt.cpan.org #93615] custom op implementation
Return-Path: <zefram@fysh.org>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Sereal-Encoder@hipster.bestpractical.com
X-RT-Mail-Extension: sereal-encoder
Date: Mon, 17 Mar 2014 11:23:53 +0000
X-Spam-Level:
To: demerphq via RT <bug-Sereal-Encoder@rt.cpan.org>
From: Zefram <zefram@fysh.org>
RT-Message-ID: <rt-4.0.18-854-1395055454-652.93615-0-0@rt.cpan.org>
Content-Length: 111
Your Changes entry refers to "sereal_decode_with_object" which should be "sereal_encode_with_object". -zefram


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.