Skip Menu |
 

This queue is for tickets about the Mail-SPF CPAN distribution.

Report information
The Basics
Id: 93241
Status: open
Priority: 0/
Queue: Mail-SPF

People
Owner: Nobody in particular
Requestors: rjbs [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Pod testing prevents installation by end users
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-9798-1393018916-1950.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 716
Download (untitled) / with headers
text/plain 716b
This test fails: t/90-author-pod-validation.t (Wstat: 256 Tests: 27 Failed: 1) # blib/lib/Mail/SPF/Util.pm (157): L<> starts or ends with whitespace # blib/lib/Mail/SPF/Util.pm (157): L<> starts or ends with whitespace The problem with Pod should be fixed, but more importantly, this test should not be run by end users trying to install the code. It's almost certainly only useful for the about-to-release author to prevent a silly mistake. After the distribution is released, the test should be ignored by users. The convention for this is usually to skip_all unless $ENV{RELEASE_TESTING}. Anyway, right now Mail-SPF can't be installed on a fresh perl install without human involvement. -- rjbs
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-9798-1393018916-1950.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: API
References: <rt-4.0.18-9798-1393018916-1950.0-0-0 [...] rt.cpan.org>
Content-Type: multipart/mixed; boundary="----------=_1457025646-13272-2"
Message-ID: <rt-4.0.18-13272-1457025646-431.0-0-0 [...] rt.cpan.org>
Message-ID: <rt-4.0.18-13272-1457025646-1027.93241-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
From: rwfranks [...] acm.org
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 860
Download (untitled) / with headers
text/plain 860b
On Fri Feb 21 16:41:56 2014, RJBS wrote: Show quoted text
> This test fails: > > t/90-author-pod-validation.t (Wstat: 256 Tests: 27 Failed: 1) > # blib/lib/Mail/SPF/Util.pm (157): L<> starts or ends with whitespace > # blib/lib/Mail/SPF/Util.pm (157): L<> starts or ends with whitespace > > The problem with Pod should be fixed, but more importantly, this test > should not be run by end users trying to install the code. It's > almost certainly only useful for the about-to-release author to > prevent a silly mistake. After the distribution is released, the test > should be ignored by users. The convention for this is usually to > skip_all unless $ENV{RELEASE_TESTING}. > > Anyway, right now Mail-SPF can't be installed on a fresh perl install > without human involvement.
Attached patch fixes offending pod. All we need now is some human involvement to apply it!
MIME-Version: 1.0
Subject: Util.pm-patch.gz
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Type: application/x-gzip; name="Util.pm-patch.gz"
Content-Disposition: inline; filename="Util.pm-patch.gz"
Content-Transfer-Encoding: base64
Content-Length: 404
Download Util.pm-patch.gz
application/x-gzip 404b

Message body not shown because it is not plain text.

MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-13272-1457025646-431.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-9798-1393018916-1950.0-0-0 [...] rt.cpan.org> <rt-4.0.18-13272-1457025646-431.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-1086-1513420041-1196.93241-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1120
On 2016-03-03 12:20:46, rwfranks@acm.org wrote: Show quoted text
> On Fri Feb 21 16:41:56 2014, RJBS wrote:
> > This test fails: > > > > t/90-author-pod-validation.t (Wstat: 256 Tests: 27 Failed: 1) > > # blib/lib/Mail/SPF/Util.pm (157): L<> starts or ends with whitespace > > # blib/lib/Mail/SPF/Util.pm (157): L<> starts or ends with whitespace > > > > The problem with Pod should be fixed, but more importantly, this test > > should not be run by end users trying to install the code. It's > > almost certainly only useful for the about-to-release author to > > prevent a silly mistake. After the distribution is released, the test > > should be ignored by users. The convention for this is usually to > > skip_all unless $ENV{RELEASE_TESTING}. > > > > Anyway, right now Mail-SPF can't be installed on a fresh perl install > > without human involvement.
> > Attached patch fixes offending pod. > > All we need now is some human involvement to apply it! >
Alternatively, CPAN.pm users may use the following distropref file to workaround the problem: https://github.com/eserte/srezic-cpan-distroprefs/blob/master/Mail-SPF.yml


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.