Skip Menu |
 

This queue is for tickets about the Proc-ProcessTable CPAN distribution.

Report information
The Basics
Id: 91150
Status: resolved
Priority: 0/
Queue: Proc-ProcessTable

People
Owner: cpan [...] bargsten.org
Requestors: HMBRAND [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.48
Fixed in: (no value)



Subject: [PATCH] Build/test FAIL on Linux 3.11 kernel
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-24616-1386077354-681.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1744
Download (untitled) / with headers
text/plain 1.7k
Linux 3.11.6-4-desktop [openSUSE 13.1 (Bottle)] t/process.t .. Ran into unknown state (hex char: 29) at t/process.t line 19. Ran into unknown state (hex char: 29) at t/process.t line 19. Ran into unknown state (hex char: 29) at t/process.t line 19. Ran into unknown state (hex char: 29) at t/process.t line 19. --- Proc-ProcessTable-0.48/os/Linux.c 2013-04-07 12:56:30.000000000 +0200 +++ Proc-ProcessTable-0.48-3gKaNU/os/Linux.c 2013-12-03 14:18:42.217199814 +0100 @@ -33,6 +33,7 @@ static unsigned system_hertz; static bool init_failed = false; +extern char *canonicalize_file_name(const char *path); /* get_string() * @@ -331,6 +332,7 @@ static bool get_proc_stat(char *pid, cha * NOTE: we don't bother checking bounds since strchr didn't return NULL * thus the NULL terminator will be at least paren+1, which is ok */ stat_cont = paren + 1; + if (*stat_cont == ')') stat_cont++; /* scape the remaining values */ result = sscanf(stat_cont, " %c %d %d %d %d %d %u %lu %lu %lu %lu %llu" diff -purd Proc-ProcessTable-0.48/os/Linux.h Proc-ProcessTable-0.48-3gKaNU/os/Linux.h --- Proc-ProcessTable-0.48/os/Linux.h 2013-04-07 12:56:30.000000000 +0200 +++ Proc-ProcessTable-0.48-3gKaNU/os/Linux.h 2013-12-03 14:12:25.718710547 +0100 @@ -32,7 +32,7 @@ struct procstat unsigned long wchan; /* these are derived from above time values */ unsigned long long time, ctime; - /* from above state_c but fixed up elese where */ + /* from above state_c but fixed up elsewhere */ const char *state; /* values scraped from /proc/{$pid}/status */ int euid, suid, fuid;
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-24616-1386077354-681.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-24616-1386077354-681.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-25038-1386180174-989.91150-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 434
Download (untitled) / with headers
text/plain 434b
This patch just postpones the bug (imagine processes with two ")" in their name). I ran into this earlier, the bug might be already fixed in the source code on github. Could you download the source, build it and run the tests? The git-repo you can clone via: git clone https://github.com/jwbargsten/perl-proc-processtable.git If it solves your problem, I'll hurry up and publish version 0.49 on CPAN with the bugfix resolved ASAP.
From h.m.brand [...] xs4all.nl Wed Dec 4 15: 23:29 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.592 tagged_above=-99.9 required=10 tests=[AWL=0.308, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
In-Reply-To: <rt-4.0.18-25038-1386180175-1146.91150-6-0 [...] rt.cpan.org>
X-Mailer: Claws Mail 3.9.2-126-g433f67 (GTK+ 2.24.10; x86_64-suse-linux-gnu)
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-91150 [...] rt.cpan.org> <rt-4.0.18-24616-1386077354-681.91150-6-0 [...] rt.cpan.org> <rt-4.0.18-25038-1386180175-1146.91150-6-0 [...] rt.cpan.org>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwEAIAAACI8LKTAAAACXBIWXMAAABIAAAASABGyWs+AAAC JElEQVRo3u2aMY4CMQxFczZ6RItEzRm4DBINDbRUSPRInIRbsNK6+dJfezN4kokn48IaCSjysL8d e9Knoj2fr9f9/gllqQ6U9/vxWK3EdwdIEGjRIVCu18NhuxUfK46SH81+fzrdbuKPx/P5ctHQdAdI TKAgpvV6s9ntBEfXEYSGgMQzIHnuFBBjkshCNJ2KtJZ04hHNAugP8bZr3NIHhbcF0AKoK0CoaHXU LUWBIs1n+jV+Fl8CVqOApEXAwyMO/DSR4XVntoAYDR7eBjQupuYAYTMph8Rj21D4m7MChN02tpqs NSnb/KqU2oHCXu5xDCgflj/RAgBiKBIXnICzAsSjWBsTz5K4/HeXYvb8yK5lY3VGEwPi2aONKT+5 AlcxrTPOwcTiraGRChgMEKJh0bVVifGVTq6qgBiNVl8QE29EsK6VE+YJAOG2wz5AvsqUS6uqgHCA n4NGvBYpnJ64Jgg27sCtxtBk1CJIA4S/GhdWKh07QxUB48jWGhZ4jKamRRr/T8/M0AaEyctry6YB 4dTGj9iWZNs3DahES5kPCJOu0RQbF/fQOBprsB9gaO9JtPDzII9U5ySXX7AnuIt91y54AAW7rPpT LCe5gt3F+CLqr2UarGB3MXvMylWGq4+9RCx3TW1oJq1t3HPQlFs6N1fFNEB4s8dn7Ne7ACSm7TPQ I5quAWmw6qBpulHM33B0Csge4Nd8JTTYG2b1XyRe3lH8x34ABJ6aePuQ2N4AAAAASUVORK5CYII=
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Virus-Scanned: by XS4ALL Virus Scanner
Message-ID: <20131204212318.468e4b04 [...] pc09.procura.nl>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.592
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id DAD252409DC for <cpan-bug+Proc-ProcessTable [...] hipster.bestpractical.com>; Wed, 4 Dec 2013 15:23:29 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kS2m7VC48EyA for <cpan-bug+Proc-ProcessTable [...] hipster.bestpractical.com>; Wed, 4 Dec 2013 15:23:28 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id EC14C2409D7 for <bug-Proc-ProcessTable [...] rt.cpan.org>; Wed, 4 Dec 2013 15:23:27 -0500 (EST)
Received: (qmail 7418 invoked by alias); 4 Dec 2013 20:23:26 -0000
Received: from smtp-vbr13.xs4all.nl (HELO smtp-vbr13.xs4all.nl) (194.109.24.33) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Wed, 04 Dec 2013 12:23:24 -0800
Received: from pc09.procura.nl (static.kpn.net [46.144.236.233] (may be forged)) (authenticated bits=0) by smtp-vbr13.xs4all.nl (8.13.8/8.13.8) with ESMTP id rB4KNIxw036293 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for <bug-Proc-ProcessTable [...] rt.cpan.org>; Wed, 4 Dec 2013 21:23:19 +0100 (CET) (envelope-from h.m.brand [...] xs4all.nl)
Delivered-To: cpan-bug+Proc-ProcessTable [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #91150] [PATCH] Ran into unknown state (hex char: 29) on Linux 3.11 kernel
Return-Path: <h.m.brand [...] xs4all.nl>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Proc-ProcessTable [...] hipster.bestpractical.com
X-RT-Mail-Extension: proc-processtable
Date: Wed, 4 Dec 2013 21:23:18 +0100
X-Spam-Level:
To: bug-Proc-ProcessTable [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
RT-Message-ID: <rt-4.0.18-22965-1386188610-243.91150-0-0 [...] rt.cpan.org>
Content-Length: 1842
Download (untitled) / with headers
text/plain 1.7k
On Wed, 4 Dec 2013 13:02:55 -0500, "jwbargsten via RT" <bug-Proc-ProcessTable@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=91150 > > > This patch just postpones the bug (imagine processes with two ")" in their name). I ran into this earlier, the bug might be already fixed in the source code on github. Could you download the source, build it and run the tests? The git-repo you can clone via: > > git clone https://github.com/jwbargsten/perl-proc-processtable.git > > If it solves your problem, I'll hurry up and publish version 0.49 on CPAN with the bugfix resolved ASAP.
cc -c -fno-strict-aliasing -pipe -fstack-protector -I/pro/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -DVERSION=\"0.48\" -DXS_VERSION=\"0.48\" -fPIC "-I/pro/lib/perl5/5.18.0/i686-linux-64int-ld/CORE" OS.c OS.c: In function ‘eval_link’: OS.c:387:10: warning: assignment makes pointer from integer without a cast [enabled by default] link = canonicalize_file_name(link_file); ^ OS.c: In function ‘OS_get_table’: OS.c:708:9: warning: passing argument 2 of ‘bless_into_proc’ from incompatible pointer type [enabled by default] ); ^ In file included from OS.c:21:0: os/Linux.h:4:6: note: expected ‘char **’ but argument is of type ‘const char * const*’ void bless_into_proc(char* , char**, ...); ^ t/process.t ............................. ok All tests successful. Files=5, Tests=10, 3 wallclock secs ( 0.02 usr 0.00 sys + 0.19 cusr 0.06 csys = 0.27 CPU) Result: PASS -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.19 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-24616-1386077354-681.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-24616-1386077354-681.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-30782-1386286396-475.91150-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 52
updated github repo & uploaded version 0.49 to cpan.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.