Skip Menu |
 

This queue is for tickets about the Search-Sitemap CPAN distribution.

Report information
The Basics
Id: 90909
Status: open
Priority: 0/
Queue: Search-Sitemap

People
Owner: Nobody in particular
Requestors: upasna.shukla [...] gmail.com
cpan [...] zoffix.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From upasna.shukla [...] gmail.com Thu Nov 28 17: 04:36 2013
X-Spam-Status: No, score=-4.963 tagged_above=-99.9 required=10 tests=[AWL=0.601, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_SORBS_WEB=0.77, SPF_SOFTFAIL=0.665] autolearn=unavailable
X-Spam-Flag: NO
Message-ID: <5297bdee.a8df440a.5846.7a73 [...] mx.google.com>
X-Received: by 10.66.148.97 with SMTP id tr1mr23910432pab.163.1385676270920; Thu, 28 Nov 2013 14:04:30 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -4.963
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id C224D240A36 for <cpan-bug+Search-Sitemap [...] hipster.bestpractical.com>; Thu, 28 Nov 2013 17:04:36 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pYZpQ515x08x for <cpan-bug+Search-Sitemap [...] hipster.bestpractical.com>; Thu, 28 Nov 2013 17:04:36 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 619672409CA for <bug-Search-Sitemap [...] rt.cpan.org>; Thu, 28 Nov 2013 17:04:36 -0500 (EST)
Received: (qmail 15866 invoked by alias); 28 Nov 2013 22:04:35 -0000
Received: from mail-pd0-f172.google.com (HELO mail-pd0-f172.google.com) (209.85.192.172) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Thu, 28 Nov 2013 14:04:34 -0800
Received: by mail-pd0-f172.google.com with SMTP id g10so12688801pdj.3 for <bug-Search-Sitemap [...] rt.cpan.org>; Thu, 28 Nov 2013 14:04:30 -0800 (PST)
Received: from localhost.localdomain ([182.68.179.192]) by mx.google.com with ESMTPSA id qv8sm97475463pbc.31.2013.11.28.14.04.29 for <bug-Search-Sitemap [...] rt.cpan.org> (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 28 Nov 2013 14:04:30 -0800 (PST)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Delivered-To: cpan-bug+Search-Sitemap [...] hipster.bestpractical.com
Subject: New Moose may break your code
Return-Path: <upasna.shukla [...] gmail.com>
X-RT-Mail-Extension: search-sitemap
X-Original-To: cpan-bug+Search-Sitemap [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:to:from:subject:date; bh=oh0CH7oRWeNlgNNhVDujxXn9+RXcHX3bHRtYr9abAfo=; b=cg7Mf2ATYOwfF/mDlSHz5GhNSNKi7cgv8G5HbfUzgVEYQopGm+B44dKoJewFruNsGC xNoiyE4ml7c0NSzmmhKVG3add499aE4LYT7bD8KPJzRozj8wtI2f+0TuaK8gC3j3wcAj t7rK+jz2784SG9fP7dr8QEO0DcNnPXLoW8zVwxjIgpqriFiv2zlnAj3+A6wOUFg//+fT si5NTJS2zMeP0HdEIKjuqwUUzxH3dxr0WwHszCnYFOVuUDLRZEJX0fuxncj0GDEXBbVk n4mmXefqsp6NI6l/a0WB7hMKlHPXAurNYu6pmDze7v5kmYy50wjwBnOKp76rQqL+Ic4E 2ApQ==
Date: Fri, 29 Nov 2013 03:34:27 +0530
X-Spam-Level:
To: bug-Search-Sitemap [...] rt.cpan.org
From: "Upasana Shukla" <upasna.shukla [...] gmail.com>
X-RT-Original-Encoding: ascii
content-type: text/plain; charset="utf-8"
X-RT-Interface: Email
Content-Length: 535
Download (untitled) / with headers
text/plain 535b
We recently deprecated Class::MOP::load_class in Moose. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.
MIME-Version: 1.0
In-Reply-To: <5297bdee.a8df440a.5846.7a73 [...] mx.google.com>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
References: <5297bdee.a8df440a.5846.7a73 [...] mx.google.com>
Content-Type: multipart/mixed; boundary="----------=_1390613735-17031-3"
Message-ID: <rt-4.0.18-17031-1390613735-1095.90909-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 87
Attached patch fixes the issue. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]
MIME-Version: 1.0
Subject: Search-Sitemap-2.13.patch
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Type: text/x-diff; name="Search-Sitemap-2.13.patch"
Content-Disposition: inline; filename="Search-Sitemap-2.13.patch"
Content-Transfer-Encoding: binary
Content-Length: 3316
diff -Naur Search-Sitemap-2.13_orig/lib/Search/Sitemap/Types.pm Search-Sitemap-2.13/lib/Search/Sitemap/Types.pm --- Search-Sitemap-2.13_orig/lib/Search/Sitemap/Types.pm 2014-01-24 20:33:09.998361343 -0500 +++ Search-Sitemap-2.13/lib/Search/Sitemap/Types.pm 2014-01-24 20:33:55.570361940 -0500 @@ -2,6 +2,7 @@ use strict; use warnings; our $VERSION = '2.13'; our $AUTHORITY = 'cpan:JASONK'; +use Class::Load; use MooseX::Types -declare => [qw( SitemapURL SitemapUrlStore SitemapChangeFreq SitemapLastMod SitemapPriority XMLPrettyPrintValue XMLTwig SitemapPinger @@ -15,11 +16,11 @@ coerce SitemapURL, from HashRef, via { - Class::MOP::load_class( 'Search::Sitemap::URL' ); + Class::Load::load_class( 'Search::Sitemap::URL' ); Search::Sitemap::URL->new( $_ ); }, from Str, via { - Class::MOP::load_class( 'Search::Sitemap::URL' ); + Class::Load::load_class( 'Search::Sitemap::URL' ); Search::Sitemap::URL->new( loc => $_ ); }; @@ -128,12 +129,12 @@ my $class = $type =~ /::/ ? $type : 'Search::Sitemap::URLStore::'.$type; - Class::MOP::load_class( $class ); + Class::Load::load_class( $class ); $class->new( $_ ) }, from Str, via { my $class = 'Search::Sitemap::URLStore::'.$_; - Class::MOP::load_class( $class ); + Class::Load::load_class( $class ); return $class->new; }; @@ -144,7 +145,7 @@ subtype SitemapPinger, as 'Search::Sitemap::Pinger'; coerce SitemapPinger, from Str, via { my $class = 'Search::Sitemap::Pinger::'.$_; - Class::MOP::load_class( $class ); + Class::Load::load_class( $class ); return $class->new; }; diff -Naur Search-Sitemap-2.13_orig/lib/Search/Sitemap.pm Search-Sitemap-2.13/lib/Search/Sitemap.pm --- Search-Sitemap-2.13_orig/lib/Search/Sitemap.pm 2014-01-24 20:33:09.998361343 -0500 +++ Search-Sitemap-2.13/lib/Search/Sitemap.pm 2014-01-24 20:34:13.762362179 -0500 @@ -13,6 +13,7 @@ use IO::File; use Carp qw( carp croak ); use HTML::Entities qw( decode_entities ); +use Class::Load; use namespace::clean -except => 'meta'; has 'urls' => ( @@ -20,7 +21,7 @@ isa => SitemapUrlStore, coerce => 1, default => sub { - Class::MOP::load_class( 'Search::Sitemap::URLStore::Memory' ); + Class::Load::load_class( 'Search::Sitemap::URLStore::Memory' ); return Search::Sitemap::URLStore::Memory->new; }, handles => { @@ -79,7 +80,7 @@ lazy => 1, default => sub { local $@; - eval { Class::MOP::load_class( 'IO::Zlib' ) }; + eval { Class::Load::load_class( 'IO::Zlib' ) }; return $@ ? 0 : 1; }, ); diff -Naur Search-Sitemap-2.13_orig/Makefile.PL Search-Sitemap-2.13/Makefile.PL --- Search-Sitemap-2.13_orig/Makefile.PL 2014-01-24 20:33:09.994361343 -0500 +++ Search-Sitemap-2.13/Makefile.PL 2014-01-24 20:34:30.202362394 -0500 @@ -7,7 +7,7 @@ Moose LWP::UserAgent XML::Twig IO::File Carp POSIX IO::Zlib Class::Trigger HTML::Entities Module::Find Moose::Util::TypeConstraints MooseX::Types MooseX::Types::Moose MooseX::ClassAttribute namespace::clean - MooseX::Types::URI DateTime + MooseX::Types::URI DateTime Class::Load ); test_requires $_ for qw(


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.