Skip Menu |
 

This queue is for tickets about the MozRepl CPAN distribution.

Report information
The Basics
Id: 88942
Status: new
Priority: 0/
Queue: MozRepl

People
Owner: Nobody in particular
Requestors: zrusilla [...] mac.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.06
Fixed in: (no value)



Subject: Setting Timeout in Net::Telnet does not work as expected
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
Message-ID: <rt-4.0.16-18015-1380040286-499.0-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1380040286-18015-8"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
Content-Length: 386
Download (untitled) / with headers
text/plain 386b
1. Typo at line 142: $connect_args{Timeoout} = int($args->{timeout}) if (defined $args->{timeout} && $args->{timeout} > 0); I think you mean Timeout. 2. Setting Timeout in the connect_args does not set the timeout for all Net::Telnet operations as one might expect, whereas setting it via its accessor does: $self->telnet->timeout($args->{timeout}); A patchfile is attached.
Subject: mozrepl-client.patch
MIME-Version: 1.0
Content-Type: text/x-patch; name="mozrepl-client.patch"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="mozrepl-client.patch"
Content-Transfer-Encoding: binary
Content-Length: 803
--- misc/Client.pm 2007-07-04 09:39:48.000000000 +0200 +++ lib/perl5/MozRepl/Client.pm 2013-09-24 18:21:24.000000000 +0200 @@ -93,6 +93,7 @@ Timeout => int($args->{timeout}) } }); + $self->telnet->timeout($args->{timeout}); return $self; } @@ -139,7 +140,7 @@ $connect_args{Host} = $args->{host} if ($args->{host}); $connect_args{Port} = int($args->{port}) if (defined $args->{port}); - $connect_args{Timeoout} = int($args->{timeout}) if (defined $args->{timeout} && $args->{timeout} > 0); + $connect_args{Timeout} = int($args->{timeout}) if (defined $args->{timeout} && $args->{timeout} > 0); unless ($telnet->open(%connect_args)) { my $message = q|Can't connect to | . sprintf("%s:%d", $connect_args{Host}, $connect_args{Port});


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.