Skip Menu |
 

This queue is for tickets about the Apache-Test CPAN distribution.

Report information
The Basics
Id: 87620
Status: resolved
Priority: 0/
Queue: Apache-Test

People
Owner: Nobody in particular
Requestors: mschout [...] gkg.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


From mschout [...] gkg.net Mon Aug 5 11: 36:29 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.598 tagged_above=-99.9 required=10 tests=[AWL=-0.363, BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_SOFTFAIL=0.665] autolearn=ham
X-Spam-Flag: NO
Content-Type: multipart/mixed; boundary="------------090706030207060609060903"
Message-ID: <51FFC662.8000206 [...] gkg.net>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -6.598
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 8A6F224041B for <cpan-bug+apache-test [...] hipster.bestpractical.com>; Mon, 5 Aug 2013 11:36:29 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y0cBwK8hsFjr for <cpan-bug+apache-test [...] hipster.bestpractical.com>; Mon, 5 Aug 2013 11:36:24 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 5B5A32403C2 for <bug-apache-test [...] rt.cpan.org>; Mon, 5 Aug 2013 11:36:24 -0400 (EDT)
Received: (qmail 21627 invoked by alias); 5 Aug 2013 15:36:23 -0000
Received: from smtp.gkg.net (HELO smtp-a.gkg.net) (208.180.25.111) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 05 Aug 2013 08:36:16 -0700
Received: from lothlorien.local (proxy.gkg.net [208.180.24.220]) by smtp-a.gkg.net (Postfix) with ESMTPSA id 3A6A35CBAA9; Mon, 5 Aug 2013 10:36:04 -0500 (CDT)
Delivered-To: cpan-bug+apache-test [...] hipster.bestpractical.com
Subject: PATCH: add -D APACHE24 if running under httpd 2.4
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
Return-Path: <mschout [...] gkg.net>
X-RT-Mail-Extension: apache-test
X-Original-To: cpan-bug+apache-test [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Date: Mon, 05 Aug 2013 10:36:02 -0500
X-Spam-Level:
To: bug-apache-test [...] rt.cpan.org, phred [...] cpan.org
X-Enigmail-Version: 1.5.2
From: Michael Schout <mschout [...] gkg.net>
X-RT-Interface: Email
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: utf-8
Content-Length: 822
Download (untitled) / with headers
text/plain 822b
I'm the maintainer of Apache::AuthCookie. As you probably already know, the authentication API in httpd 2.4 has changed radically. As a result, for authentication modules that need to support httpd 2.x as well as 2.4, there is a need to have a conditional define to determine if we are running under Apache 2.4 or later. The attached patch adds -D APACHE24 (this is in addition to -D APACHE2) if running under httpd 2.4. Example of why this is needed: <IfDefine APACHE24> PerlAddAuthzProvider user My::Auth->authz </IfDefine> # and since this makes PerlAuthzHandler pointless in httpd 2.4: <IfDefine APACHE2> ... <IfDefine !APACHE24> PerlAuthzHandler .... </IfDefine> </IfDefine> I'd really like to see this make it into Apache::Test for the official httpd 2.4 support release. Thanks! Michael Schout
content-type: text/plain; charset="utf-8"; name="ap-test-apache24-define.patch"; x-mac-creator="0"; x-mac-type="0"
Content-Disposition: attachment; filename="ap-test-apache24-define.patch"
Content-Transfer-Encoding: base64
X-RT-Original-Encoding: utf-8
Content-Length: 827

Message body is not shown because sender requested not to inline it.

MIME-Version: 1.0
In-Reply-To: <51FFC662.8000206 [...] gkg.net>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <51FFC662.8000206 [...] gkg.net>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-3258-1403597990-1514.87620-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1068
On Mon Aug 05 11:36:30 2013, mschout@gkg.net wrote: Show quoted text
> I'm the maintainer of Apache::AuthCookie. As you probably already know, > the authentication API in httpd 2.4 has changed radically. As a result, > for authentication modules that need to support httpd 2.x as well as > 2.4, there is a need to have a conditional define to determine if we are > running under Apache 2.4 or later. > > The attached patch adds -D APACHE24 (this is in addition to -D APACHE2) > if running under httpd 2.4. >
Thanks for the patch. It looks good at a quick glance except for one thing that troubles me; I don't know if it's really a big problem. We currently set -D APACHE2 for httpd-2, and when httpd-3 arrives that will automatically become -D APACHE3. But your new code will set -D APACHE24 not only for httpd-2.4, but also for httpd-2.5 and httpd-2.6 etc, if they should ever appear. I don't know how likely that is, but would it be better to only set it for httpd-2.4, or else give it a slightly different name to reflect its different meaning compared to the APACHE2 define?
MIME-Version: 1.0
X-Spam-Status: No, score=-3.361 tagged_above=-99.9 required=10 tests=[AWL=1.190, BAYES_00=-1.9, FROM_OUR_RT=-2, RCVD_IN_DNSWL_NONE=-0.0001, RP_MATCHES_RCVD=-0.651] autolearn=ham
In-Reply-To: <rt-4.0.18-3258-1403597990-1046.87620-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-87620 [...] rt.cpan.org> <51FFC662.8000206 [...] gkg.net> <rt-4.0.18-3258-1403597990-1046.87620-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <53A98E1C.7030402 [...] gkg.net>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -3.361
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 2D51F240329 for <cpan-bug+Apache-Test [...] hipster.bestpractical.com>; Tue, 24 Jun 2014 10:41:56 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uJ9s4P-7DjP5 for <cpan-bug+Apache-Test [...] hipster.bestpractical.com>; Tue, 24 Jun 2014 10:41:51 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 849202400A9 for <bug-Apache-Test [...] rt.cpan.org>; Tue, 24 Jun 2014 10:41:51 -0400 (EDT)
Received: (qmail 31309 invoked by alias); 24 Jun 2014 14:41:50 -0000
Received: from smtp.gkg.net (HELO smtp-a.gkg.net) (208.180.25.111) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 24 Jun 2014 07:41:46 -0700
Received: from lothlorien.snowcrash.lan (proxy.gkg.net [208.180.24.220]) by smtp-a.gkg.net (Postfix) with ESMTPSA id F36BB5CBC2F for <bug-Apache-Test [...] rt.cpan.org>; Tue, 24 Jun 2014 09:41:33 -0500 (CDT)
Delivered-To: cpan-bug+Apache-Test [...] hipster.bestpractical.com
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
Subject: Re: [rt.cpan.org #87620] PATCH: add -D APACHE24 if running under httpd 2.4
Return-Path: <mschout [...] gkg.net>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Apache-Test [...] hipster.bestpractical.com
X-RT-Mail-Extension: apache-test
Date: Tue, 24 Jun 2014 09:41:32 -0500
X-Spam-Level:
To: bug-Apache-Test [...] rt.cpan.org
X-Enigmail-Version: 1.6
Content-Transfer-Encoding: 7bit
From: Michael Schout <mschout [...] gkg.net>
RT-Message-ID: <rt-4.0.18-30470-1403620916-1581.87620-0-0 [...] rt.cpan.org>
Content-Length: 1866
Download (untitled) / with headers
text/plain 1.8k
On 6/24/14, 3:19 AM, Steve Hay via RT wrote: Show quoted text
> But your new code will set -D APACHE24 not only for httpd-2.4, but > also for httpd-2.5 and httpd-2.6 etc, if they should ever appear. I > don't know how likely that is, but would it be better to only set it > for httpd-2.4, or else give it a slightly different name to reflect > its different meaning compared to the APACHE2 define?
I had these same thoughts. The only problem with that is if httpd 2.5 has the same auth api (and presumably it would), then I (and presumably other auth module writers) will have to duplicate some configuration. e.g.: <IfDefine APACHE24> PerlAddAuthzProvider user My::Auth->authz </IfDefine> <IfDefine APACHE25> PerlAddAuthzProvider user My::Auth->authz </IfDefine> ... repeat for every apache version >= 2.4 that is out there... But then we also need -DAPACHE20 and -DAPACHE22 etc so that those modules can be supported: <IfDefine APACHE22> PerlAuthzHandler My::Auth->authorization </IfDefine> <IfDefine APACHE20> PerlAuthzHandler My::Auth->authorization </IfDefine> But I can live with this. There are no comparison operators available in httpd.conf sadly. As for the name, if we ever get to Apache v20.x, then its perhaps a bit of a problem, and I had the same thought as you about that. Maybe use -DAPACHE2 -DAPACHE2_4 instead? I'm fine with that. If you want me to rework the patch, I'll do that, but it seems trivial enough that I don't think you need me to do that :). I would *REALLY* like to see this get applied and a release of Apache::Test happen soon. This is a showstopper for mod perl auth modules that need to support httpd 2.4 as well as 2.2 or earlier. Judging by the mod_perl lists, the a final release for httpd 2.4 is not far off. I'd love to have my Auth modules released to CPAN before the mod_perl final release. Regards, Michael Schout
MIME-Version: 1.0
In-Reply-To: <51FFC662.8000206 [...] gkg.net>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <51FFC662.8000206 [...] gkg.net>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-29074-1408004499-378.87620-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 54
Thanks for the patch. Now applied in revision 1617896.
MIME-Version: 1.0
X-Spam-Status: No, score=-4.965 tagged_above=-99.9 required=10 tests=[AWL=1.603, BAYES_00=-1.9, FROM_OUR_RT=-4, RCVD_IN_DNSWL_NONE=-0.0001, RP_MATCHES_RCVD=-0.668] autolearn=ham
In-Reply-To: <rt-4.0.18-29074-1408004500-1233.87620-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-87620 [...] rt.cpan.org> <51FFC662.8000206 [...] gkg.net> <rt-4.0.18-29074-1408004500-1233.87620-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <54369F62.9020905 [...] gkg.net>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -4.965
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 4E25D24060F for <cpan-bug+Apache-Test [...] hipster.bestpractical.com>; Thu, 9 Oct 2014 10:45:01 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xboKlwY8VDRU for <cpan-bug+Apache-Test [...] hipster.bestpractical.com>; Thu, 9 Oct 2014 10:45:00 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 1373A24024A for <bug-Apache-Test [...] rt.cpan.org>; Thu, 9 Oct 2014 10:44:59 -0400 (EDT)
Received: (qmail 12460 invoked by alias); 9 Oct 2014 14:44:59 -0000
Received: from smtp.gkg.net (HELO smtp-a.gkg.net) (208.180.25.111) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Thu, 09 Oct 2014 07:44:57 -0700
Received: from lothlorien.snowcrash.lan (proxy.gkg.net [208.180.24.220]) by smtp-a.gkg.net (Postfix) with ESMTPSA id 4B82C30F1A7 for <bug-Apache-Test [...] rt.cpan.org>; Thu, 9 Oct 2014 09:44:52 -0500 (CDT)
Delivered-To: cpan-bug+Apache-Test [...] hipster.bestpractical.com
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.1.2
Subject: Re: [rt.cpan.org #87620] PATCH: add -D APACHE24 if running under httpd 2.4
Return-Path: <mschout [...] gkg.net>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Apache-Test [...] hipster.bestpractical.com
X-RT-Mail-Extension: apache-test
Date: Thu, 09 Oct 2014 09:44:50 -0500
X-Spam-Level:
To: bug-Apache-Test [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Michael Schout <mschout [...] gkg.net>
RT-Message-ID: <rt-4.0.18-14436-1412865902-697.87620-0-0 [...] rt.cpan.org>
Content-Length: 248
Download (untitled) / with headers
text/plain 248b
On 8/14/14 3:21 AM, Steve Hay via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=87620 > > > Thanks for the patch. Now applied in revision 1617896.
Any chance a release can be pushed to CPAN with this fix? Regards, Michael Schout
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-14436-1412865902-697.87620-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-87620 [...] rt.cpan.org> <51FFC662.8000206 [...] gkg.net> <rt-4.0.18-29074-1408004500-1233.87620-6-0 [...] rt.cpan.org> <54369F62.9020905 [...] gkg.net> <rt-4.0.18-14436-1412865902-697.87620-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-8922-1429687519-434.87620-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 345
Download (untitled) / with headers
text/plain 345b
On Thu Oct 09 10:45:02 2014, mschout@gkg.net wrote: Show quoted text
> On 8/14/14 3:21 AM, Steve Hay via RT wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=87620 > > > > > Thanks for the patch. Now applied in revision 1617896.
> > Any chance a release can be pushed to CPAN with this fix? >
This is now - finally! - on CPAN, in Apache-Test 1.39.
MIME-Version: 1.0
X-Spam-Status: No, score=-5.931 tagged_above=-99.9 required=10 tests=[AWL=0.668, BAYES_00=-1.9, FROM_OUR_RT=-4, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-8922-1429687519-904.87620-5-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-87620 [...] rt.cpan.org> <51FFC662.8000206 [...] gkg.net> <rt-4.0.18-29074-1408004500-1233.87620-6-0 [...] rt.cpan.org> <54369F62.9020905 [...] gkg.net> <rt-4.0.18-14436-1412865902-697.87620-5-0 [...] rt.cpan.org> <rt-4.0.18-8922-1429687519-904.87620-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.112.40.9 with SMTP id t9mr25602013lbk.55.1429717099155; Wed, 22 Apr 2015 08:38:19 -0700 (PDT)
Message-ID: <CAHrynWBmhoKMdcyq4QEoQcXcGQTDreTPJ9OqKH6DXN2fT4Yh_w [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="001a11336578d341b5051451f32a"
X-Spam-Score: -5.931
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id CD8F92403F6 for <cpan-bug+Apache-Test [...] hipster.bestpractical.com>; Wed, 22 Apr 2015 11:38:38 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fmwG+9ASVqB7 for <cpan-bug+Apache-Test [...] hipster.bestpractical.com>; Wed, 22 Apr 2015 11:38:36 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 5AB0C2403A2 for <bug-Apache-Test [...] rt.cpan.org>; Wed, 22 Apr 2015 11:38:35 -0400 (EDT)
Received: (qmail 18787 invoked by alias); 22 Apr 2015 15:38:34 -0000
Received: from mail-la0-f47.google.com (HELO mail-la0-f47.google.com) (209.85.215.47) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Wed, 22 Apr 2015 08:38:31 -0700
Received: by laat2 with SMTP id t2so177960469laa.1 for <bug-Apache-Test [...] rt.cpan.org>; Wed, 22 Apr 2015 08:38:19 -0700 (PDT)
Received: by 10.25.155.20 with HTTP; Wed, 22 Apr 2015 08:38:18 -0700 (PDT)
Received: by 10.25.155.20 with HTTP; Wed, 22 Apr 2015 08:38:18 -0700 (PDT)
Delivered-To: cpan-bug+Apache-Test [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87620] PATCH: add -D APACHE24 if running under httpd 2.4
Return-Path: <fred [...] redhotpenguin.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Apache-Test [...] hipster.bestpractical.com
X-RT-Mail-Extension: apache-test
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=o0VoMM7cHYvNZn61CEpG1W4DQl990WMzQjl4Y70o1OQ=; b=FS5aBu4dXHv0hw+WwjyV3TxYWcVAJ7rbg9dwGsS1MX5FEdplUatsN9F7YiGL4ysLtt tDDoWmzZUE3BPrkgJgbXVXPi25yrRvOztYtUhAQFD7r6PPHTBdrpHE2r6+9cM4/+umzu iqr6e3Zpf9jku5L3ysqsAoC1l6vkC2y6qKKpDQYQ6FtaMPFmqxwdfG0Ay4K8Ggajxxn0 ef87a6HYbQVhZpdpl5dSN3Xg9FsqIY2wX3jRPZsqVFDf4psX2hXRmiYKzMZBYebV9v5T u94ULWn29TAvVf7Myq+abuOYTwYuZdhbC9gkapcX3bdgDyaW11lxX30mrTkMxZxtnQMM ceMA==
Date: Wed, 22 Apr 2015 08:38:18 -0700
X-Spam-Level:
To: bug-Apache-Test [...] rt.cpan.org
X-GM-Message-State: ALoCoQmCRnxyRgV9I0Z2nj0PweSyIsZPZT25s6bhaYFPX3yR7hX7uaLjNLw5uaA/fWPVU/peU/0o
From: Fred Moyer <fred [...] redhotpenguin.com>
RT-Message-ID: <rt-4.0.18-31308-1429717119-1768.87620-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 606
Download (untitled) / with headers
text/plain 606b
Woot! Eagerly awaiting the announcement on the modperl list. On Apr 22, 2015 12:25 AM, "Steve Hay via RT" <bug-Apache-Test@rt.cpan.org> wrote: Show quoted text
> Queue: Apache-Test > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=87620 > > > On Thu Oct 09 10:45:02 2014, mschout@gkg.net wrote:
> > On 8/14/14 3:21 AM, Steve Hay via RT wrote:
> > > <URL: https://rt.cpan.org/Ticket/Display.html?id=87620 > > > > > > > Thanks for the patch. Now applied in revision 1617896.
> > > > Any chance a release can be pushed to CPAN with this fix? > >
> > This is now - finally! - on CPAN, in Apache-Test 1.39. > >
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1127


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.