Skip Menu |
 

This queue is for tickets about the WebService-Google-Reader CPAN distribution.

Report information
The Basics
Id: 87211
Status: resolved
Priority: 0/
Queue: WebService-Google-Reader

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
WebService-Google-Reader-0.21-returnor.patch



Subject: [PATCH] wrong return precedence
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
Message-ID: <rt-4.0.13-14519-1374601181-1874.0-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1374601181-14519-12"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
Content-Length: 167
Download (untitled) / with headers
text/plain 167b
Please announce end of live, and returns binds stronger than or, so the expressions after or are ignored. See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Subject: WebService-Google-Reader-0.21-returnor.patch
MIME-Version: 1.0
Content-Type: text/x-patch; name="WebService-Google-Reader-0.21-returnor.patch"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="WebService-Google-Reader-0.21-returnor.patch"
Content-Transfer-Encoding: binary
Content-Length: 546
diff -bu WebService-Google-Reader-0.21-WtGY4H/lib/WebService/Google/Reader.pm~ WebService-Google-Reader-0.21-WtGY4H/lib/WebService/Google/Reader.pm --- WebService-Google-Reader-0.21-WtGY4H/lib/WebService/Google/Reader.pm~ 2011-12-03 00:54:14.000000000 -0600 +++ WebService-Google-Reader-0.21-WtGY4H/lib/WebService/Google/Reader.pm 2013-07-23 12:36:52.976898907 -0500 @@ -485,7 +485,7 @@ } sub _public { - return not $_[0]->username or not $_[0]->password; + return (not $_[0]->username or not $_[0]->password); } sub _encode_type {
MIME-Version: 1.0
In-Reply-To: <rt-4.0.13-14519-1374601181-1874.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.13-14519-1374601181-1874.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.14-23755-1374865667-802.87211-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 479
Download (untitled) / with headers
text/plain 479b
On Tue Jul 23 13:39:41 2013, rurban@x-ray.at wrote: Show quoted text
> Please announce end of live, and
A few services claimed they would release apis compatible with google reader, so the module itself may not be end of life. I don't believe it's necessary to publish a separate release just to update the docs to state the obvious that the webservice has been discontinued. Show quoted text
> returns binds stronger than or, so the expressions after or are ignored.
Thanks, pushed a fix to the github repo.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.