Skip Menu |
 

This queue is for tickets about the ACME-QuoteDB CPAN distribution.

Report information
The Basics
Id: 87203
Status: new
Priority: 0/
Queue: ACME-QuoteDB

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: [PATCH] wrong return precedence
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
Message-ID: <rt-4.0.13-14519-1374599920-1745.0-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1374599920-14519-6"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
Content-Length: 141
Download (untitled) / with headers
text/plain 141b
returns binds stronger than or and and, so the expressions after or are ignored. See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Subject: ACME-QuoteDB-0.1.2-returnor.patch
MIME-Version: 1.0
Content-Type: text/x-patch; name="ACME-QuoteDB-0.1.2-returnor.patch"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="ACME-QuoteDB-0.1.2-returnor.patch"
Content-Transfer-Encoding: binary
Content-Length: 842
diff -bu ./lib/ACME/QuoteDB/LoadDB.pm~ ./lib/ACME/QuoteDB/LoadDB.pm --- ./lib/ACME/QuoteDB/LoadDB.pm~ 2009-10-01 01:30:25.000000000 -0500 +++ ./lib/ACME/QuoteDB/LoadDB.pm 2013-07-19 16:23:20.293610841 -0500 @@ -207,7 +207,7 @@ and $hr->{source} eq 'Attribution Source', and $hr->{catg} eq 'Category', and $hr->{rating} eq 'Rating') - or croak 'incorrect headers or header order'; + || croak 'incorrect headers or header order'; } sub dbload_from_csv { @@ -554,7 +554,7 @@ $dbh = undef; }; - return $@ and croak 'Cannot create database tables!'; + return $@ && croak 'Cannot create database tables!'; } @@ -608,7 +608,7 @@ $dbh = undef; }; - return $@ and croak 'Cannot create database tables!'; + return $@ && croak 'Cannot create database tables!'; }


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.