Skip Menu |
 

This queue is for tickets about the Module-Rename CPAN distribution.

Report information
The Basics
Id: 87172
Status: resolved
Priority: 0/
Queue: Module-Rename

People
Owner: Nobody in particular
Requestors: jim.cochrane [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From jim.cochrane [...] gmail.com Mon Jul 22 23: 51:16 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.219 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
X-Spam-Flag: NO
Content-Type: multipart/alternative; boundary="001a11c2a632d07f9304e225b3ce"
Message-ID: <CACgAm381kgz796Y+XgnkWBQsiFOcnJNMK4k-nzSFS_P44XhPYQ [...] mail.gmail.com>
X-Received: by 10.224.173.2 with SMTP id n2mr36570253qaz.75.1374551465293; Mon, 22 Jul 2013 20:51:05 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -6.219
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 6FAD924025F for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Mon, 22 Jul 2013 23:51:16 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X04U3OBotsiL for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Mon, 22 Jul 2013 23:51:13 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id AF78A24022C for <bug-Module-Rename [...] rt.cpan.org>; Mon, 22 Jul 2013 23:51:13 -0400 (EDT)
Received: (qmail 11911 invoked by alias); 23 Jul 2013 03:51:13 -0000
Received: from mail-qe0-f47.google.com (HELO mail-qe0-f47.google.com) (209.85.128.47) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 22 Jul 2013 20:51:09 -0700
Received: by mail-qe0-f47.google.com with SMTP id x7so693743qeu.20 for <bug-Module-Rename [...] rt.cpan.org>; Mon, 22 Jul 2013 20:51:05 -0700 (PDT)
Received: by 10.49.74.226 with HTTP; Mon, 22 Jul 2013 20:51:05 -0700 (PDT)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Delivered-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
Subject: Request to handle 'git mv' in Module::Rename
Return-Path: <jim.cochrane [...] gmail.com>
X-RT-Mail-Extension: module-rename
X-Original-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=fpyVo13Xx5MlFrrUgSmWZxlJwqzmshowOndjj9jhV6o=; b=m6ybbhlwcPZuyP6lpr+bvSZVbtR+nnOMIPIDHwYYO/H3787gmea6o0uryNMjQtEZLq 2odsj5xBMwz0Zaq4Pe+4HMTD6OJi3QfQiiXJjNFlhETugJTIlbymu/vkxPkQdxscZn8P Bwhiwqm7EwYq+k2Jyjg5B1bKcdDo0/HKaCF2hFnsu5vnHoFAupd6tA+75x5PMRLLjRkM h9wnaxRxgxVe6cy76rqjefaNK4McjtR+oXf1lY8aN1bTP37ewoyvAyBpHKSUWBit8cHM QR1rp4X+mX54gMKLtCAqwT8lUIbLdWtxbTKyfN410RpPxiqRLxkcmF2HLZqbiwfbMLG6 AjBg==
Date: Mon, 22 Jul 2013 22:51:05 -0500
X-Spam-Level:
To: bug-Module-Rename [...] rt.cpan.org
From: Jim Cochrane <jim.cochrane [...] gmail.com>
X-RT-Interface: Email
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: iso-8859-1
Content-Length: 948
Download (untitled) / with headers
text/plain 948b
Hi. What I'm reporting here is not really a bug, but a feature request. I didn't find a path to report a feature request - apologies if I missed it. What I'm requesting is an extension to Module::Rename to use 'git-mv' instead of 'mv' to perform the file moves, so that git can be kept in the loop, thus saving extra admin work. I actually grabbed the code from github and made a small change, which worked fine in a simple test case. I can submit this modification to you if you like - just let me know how you prefer I do that - e.g., pull request on github or whatever. I see you've not made any changes to this module for a few years, but (I find) it's a very useful module/script and since the change is small and (IMO) useful, hopefully you'll find it practical and worthwhile to incorporate it. (I'm aware that you may need to add further changes or throw away my changes and implement your own - that's fine.) Thanks! Jim Cochrane
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: iso-8859-1
Content-Length: 1120
MIME-Version: 1.0
In-Reply-To: <CACgAm381kgz796Y+XgnkWBQsiFOcnJNMK4k-nzSFS_P44XhPYQ [...] mail.gmail.com>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: API
References: <CACgAm381kgz796Y+XgnkWBQsiFOcnJNMK4k-nzSFS_P44XhPYQ [...] mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.14-31214-1374924943-111.0-0-0 [...] rt.cpan.org>
Message-ID: <rt-4.0.14-31214-1374924943-1073.87172-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
From: jim.cochrane [...] gmail.com
Content-Length: 233
Download (untitled) / with headers
text/plain 233b
I've not gotten a response yet, so I put my modified version on github: https://github.com/jjttcc/module-rename It essentially used the 'mv' command by default (as the original does) and adds a -g option to do a 'git mv' instead.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.14-31214-1374924943-111.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <CACgAm381kgz796Y+XgnkWBQsiFOcnJNMK4k-nzSFS_P44XhPYQ [...] mail.gmail.com> <rt-4.0.14-31214-1374924943-111.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.14-17855-1374981410-1492.87172-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 749
Download (untitled) / with headers
text/plain 749b
On Sat Jul 27 07:35:43 2013, jim.cochrane@gmail.com wrote: Show quoted text
> I've not gotten a response yet, so I put my modified version > on github:
Sorry for the delay. I've applied most of your changes: https://github.com/mschilli/module-rename-perl/commit/005014267394e9dc993ea9c73829d6d5b13bd27d And added a couple of fixes: https://github.com/mschilli/module-rename-perl/commit/aae967e6408a217e0eaaee41c1a607d2a4c06c70 And released 0.04 to CPAN. Going forward, if you want to make it easy for me apply your changes, please do the following: * press the fork button on github * apply your changes to the fork * send me a pull request Also, don't forget to add test cases, they keep the bugs out! Thanks for your contribution!
From jim.cochrane [...] gmail.com Tue Jul 30 16: 56:00 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.219 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
X-Spam-Flag: NO
X-RT-Interface: API
X-Virus-Checked: Checked
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.182.186.41 with SMTP id fh9mr58833855obc.37.1375217748118; Tue, 30 Jul 2013 13:55:48 -0700 (PDT)
Message-ID: <CACgAm39FLR-9Uf8B_79uY0iMnZ2Gys6Tt1JGgV7CqmG9nzSSNw [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="089e013cbc225d938e04e2c0d539"
X-Spam-Score: -6.219
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 6581B240FBD for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Tue, 30 Jul 2013 16:56:00 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IyBrKh38tYLq for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Tue, 30 Jul 2013 16:55:58 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 39626240F85 for <bug-Module-Rename [...] rt.cpan.org>; Tue, 30 Jul 2013 16:55:57 -0400 (EDT)
Received: (qmail 7375 invoked by alias); 30 Jul 2013 20:55:57 -0000
Received: from mail-oa0-f46.google.com (HELO mail-oa0-f46.google.com) (209.85.219.46) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 30 Jul 2013 13:55:52 -0700
Received: by mail-oa0-f46.google.com with SMTP id l10so2961408oag.5 for <bug-Module-Rename [...] rt.cpan.org>; Tue, 30 Jul 2013 13:55:48 -0700 (PDT)
Received: by 10.60.121.34 with HTTP; Tue, 30 Jul 2013 13:55:48 -0700 (PDT)
Delivered-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
Subject: Thanks, and found new bug [Re: [rt.cpan.org #87172] Request to handle 'git mv' in Module::Rename]
Return-Path: <jim.cochrane [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=Yxz/SlbvP2941L0W0ASFiyvtSPg7tQ2brV/ZRVhtTU0=; b=YmUwEvMgCBNLg49Zys5XAS1ZfacQ9fuM+yP6Qf0RuQ+ZK9ZGjriW4F44OXr4wdfEQz K7DIK6A5v5abiMhPrxt0A6fo9xSU6ht5sDz/rd+wU52H/QbVXlJU+iOfWBbWx2iSyv/3 Mhvm/+izsq430h0eXNgYMtugmxV0lCITUHA1ymB7A4ljQ3wm6DTiyJbUJ81juJlvq1Dn s/RtQ279NZCIAdif8jeIA8Ndbbs3pU8KUNrcWe0NGzEVAG5upZF587aMTbGN9G6/YZuO ake+ncvrwqLkIzzcPm+b7xhks+oAY0mvvEj8fsgd7Xgj/zfhyAgyqubckGwGWDDfi8ZR r6rA==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
X-RT-Mail-Extension: module-rename
Date: Tue, 30 Jul 2013 15:55:48 -0500
X-Spam-Level:
To: bug-Module-Rename [...] rt.cpan.org
From: Jim Cochrane <jim.cochrane [...] gmail.com>
RT-Message-ID: <rt-4.0.14-1386-1375217761-571.87172-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 2108
Hi - sorry for the late reply, and thanks very much for your fixes and notification. I've found (what I consider to be) a bug (which is present in both the old and new versions of module-rename) in how the old-name pattern is used to determine which modules to rename - a partial match is accepted, so that, for example, module-rename Bar::Foo Bar::Boo would consider Bar::Food a match and apply the change on it. If you'd like a simple concrete example of how this produces unwanted behavior, let me know. I've found that adding one line in Rename.pm fixes the problem, at least for the simple test case I'm using: --- Rename.pm.orig 2013-07-27 21:59:50.000000000 -0500 +++ Rename.pm 2013-07-29 16:13:53.440512721 -0500 @@ -36,6 +36,7 @@ push @{ $self->{dir_exclude} }, ".git"; } + $self->{name_old} = '\b' . $self->{name_old} . '\b'; $self->{dir_exclude_hash} = { map { $_ => 1 } @{$self->{dir_exclude}} }; $self->{dir_ignore_hash} = { map { $_ => 1 } @{$self->{dir_ignore}} }; If you agree with this solution, let me know if you'd like me to follow the fork/pull-request procedure on github for this change. Thanks! Jim On Sat, Jul 27, 2013 at 10:16 PM, Michael_Schilli via RT < bug-Module-Rename@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=87172 > > > On Sat Jul 27 07:35:43 2013, jim.cochrane@gmail.com wrote:
> > I've not gotten a response yet, so I put my modified version > > on github:
> > Sorry for the delay. > > I've applied most of your changes: > > > https://github.com/mschilli/module-rename-perl/commit/005014267394e9dc993ea9c73829d6d5b13bd27d > > And added a couple of fixes: > > > https://github.com/mschilli/module-rename-perl/commit/aae967e6408a217e0eaaee41c1a607d2a4c06c70 > > And released 0.04 to CPAN. > > Going forward, if you want to make it easy for me apply your changes, > please do the following: > > * press the fork button on github > * apply your changes to the fork > * send me a pull request > > Also, don't forget to add test cases, they keep the bugs out! > > Thanks for your contribution! > > > > > > > >
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 3740
MIME-Version: 1.0
In-Reply-To: <rt-4.0.14-1386-1375217761-571.87172-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <CACgAm39FLR-9Uf8B_79uY0iMnZ2Gys6Tt1JGgV7CqmG9nzSSNw [...] mail.gmail.com> <rt-4.0.14-1386-1375217761-571.87172-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.14-30340-1375251761-976.87172-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 367
Download (untitled) / with headers
text/plain 367b
On Tue Jul 30 16:56:01 2013, jim.cochrane@gmail.com wrote: Show quoted text
> determine which modules to rename - a partial match is accepted, so > that, > for example, module-rename Bar::Foo Bar::Boo would > consider Bar::Food
Interesting, are you referring to file names or file content? If the latter, it seems that s/($self->{name_old})\b... should take care of it, no?
From jim.cochrane [...] gmail.com Wed Jul 31 17: 13:23 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.219 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
In-Reply-To: <rt-4.0.14-30340-1375251761-1750.87172-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-87172 [...] rt.cpan.org> <CACgAm39FLR-9Uf8B_79uY0iMnZ2Gys6Tt1JGgV7CqmG9nzSSNw [...] mail.gmail.com> <rt-4.0.14-1386-1375217761-571.87172-6-0 [...] rt.cpan.org> <rt-4.0.14-30340-1375251761-1750.87172-6-0 [...] rt.cpan.org>
X-Virus-Checked: Checked
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.182.186.41 with SMTP id fh9mr62936159obc.37.1375305188599; Wed, 31 Jul 2013 14:13:08 -0700 (PDT)
Message-ID: <CACgAm38MEC+FL-zkxyU_cFJzj8zrM5fa-URVSd09k6nYG9x1xA [...] mail.gmail.com>
Content-Type: multipart/mixed; boundary="089e013cbc22396df404e2d531e1"
X-Spam-Score: -6.219
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
X-Amavis-Hold: Exceeded storage quota 129373500 bytes by do_pax_cpio/pre; last chunk 1219770773354 bytes
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 3405D241009 for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Wed, 31 Jul 2013 17:13:23 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zM9Qq61r2ERu for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Wed, 31 Jul 2013 17:13:21 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id D963D240124 for <bug-Module-Rename [...] rt.cpan.org>; Wed, 31 Jul 2013 17:13:20 -0400 (EDT)
Received: (qmail 15267 invoked by alias); 31 Jul 2013 21:13:20 -0000
Received: from mail-ob0-f182.google.com (HELO mail-ob0-f182.google.com) (209.85.214.182) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Wed, 31 Jul 2013 14:13:13 -0700
Received: by mail-ob0-f182.google.com with SMTP id wo10so2396809obc.13 for <bug-Module-Rename [...] rt.cpan.org>; Wed, 31 Jul 2013 14:13:08 -0700 (PDT)
Received: by 10.60.121.34 with HTTP; Wed, 31 Jul 2013 14:13:08 -0700 (PDT)
Delivered-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87172] Request to handle 'git mv' in Module::Rename
Return-Path: <jim.cochrane [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=hl0x8wgqoEsac/QMJBr/ZOEM0AcKtMEfqJY0NDHkyPM=; b=dpOWMAU1eXmTFBwi7VlFMx9YdgGQqJuU5vkxM6CtfoWHVi7b0A+5eAuXb9gxXZBrTZ LFZRElHo+V3ed8UxSA1sa7LaxYFWfpQIPo1G3YaGasM3Gi0wk4YGurUiGcqv6FLyFFn7 Tk5XhLkfWdLrpZEMx7EwZiVJSwpVN9Z0aAF+m3j5tL5KO8/7uDX6Jv6eDJfFxFU5P0QO x/SmJX95RdaMHfRemE6PoHrGndTgh4gRZCypjOCNCbt+4IBlaRCjXvH+HqfXA4K5ggPG bCok/hYlN0aluKfFwpXdP7g5VnA4VsAXSqsCta7VM0RINFnk6qFSMhgsa3eS+BABSQdc Z+WA==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
X-RT-Mail-Extension: module-rename
Date: Wed, 31 Jul 2013 16:13:08 -0500
X-Spam-Level:
To: bug-Module-Rename [...] rt.cpan.org
From: Jim Cochrane <jim.cochrane [...] gmail.com>
RT-Message-ID: <rt-4.0.16-32243-1375305204-1108.87172-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: multipart/alternative; boundary="089e013cbc22396def04e2d531df"
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 1405
Download (untitled) / with headers
text/plain 1.3k
The content is OK; the file/directory names are what get messed up. I think what happens is that the first search - for file names that match the old pattern - finds more than it should; but when \b is applied in file_process, no overly-optimistic matches are found, so the bug does not occur when changing file contents. But the bug does occur when figuring out what 'git mv' commands (and, probably, when -g is not specified, what 'mv' commands) to generate. I'm attaching a small example, with original git repo, cloned repo with buggy version applied, and cloned repo with non-buggy version (my fix) applied, which I think gives a simple demo of the problem. Let me know if anything's unclear or you have questions. If the mail server we're using doesn't allow attachments, please let me know the best way to get this tar file to you. Thanks. On Wed, Jul 31, 2013 at 1:22 AM, Michael_Schilli via RT < bug-Module-Rename@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=87172 > > > On Tue Jul 30 16:56:01 2013, jim.cochrane@gmail.com wrote:
> > determine which modules to rename - a partial match is accepted, so > > that, > > for example, module-rename Bar::Foo Bar::Boo would > > consider Bar::Food
> > Interesting, are you referring to file names or file content? If the > latter, it seems that > > s/($self->{name_old})\b... > > should take care of it, no? > > >
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 2004
Content-Type: application/x-tar; name="namebug.tar"
X-Attachment-ID: f_hjt134bw0
Content-Disposition: attachment; filename="namebug.tar"
Content-Transfer-Encoding: base64
Content-Length: 184320
Download namebug.tar
application/x-tar 180k

Message body not shown because it is not plain text.

From jim.cochrane [...] gmail.com Fri Aug 2 08: 54:58 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.219 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_NEUTRAL=0.779] autolearn=ham
X-Spam-Flag: NO
X-RT-Interface: API
X-Virus-Checked: Checked
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.60.94.230 with SMTP id df6mr5282546oeb.64.1375448085223; Fri, 02 Aug 2013 05:54:45 -0700 (PDT)
Message-ID: <CACgAm3_Rdn-ZjooU16j8Y2w=oCQShNjk3+8su8ZpxtwMNzNsZw [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="089e01184a1286df2004e2f6769d"
X-Spam-Score: -6.219
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 8768124112F for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Fri, 2 Aug 2013 08:54:58 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j1A0WlooLCMV for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Fri, 2 Aug 2013 08:54:56 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 92260240358 for <bug-Module-Rename [...] rt.cpan.org>; Fri, 2 Aug 2013 08:54:56 -0400 (EDT)
Received: (qmail 7501 invoked by alias); 2 Aug 2013 12:54:55 -0000
Received: from mail-ob0-f180.google.com (HELO mail-ob0-f180.google.com) (209.85.214.180) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 02 Aug 2013 05:54:49 -0700
Received: by mail-ob0-f180.google.com with SMTP id up14so1042878obb.25 for <bug-Module-Rename [...] rt.cpan.org>; Fri, 02 Aug 2013 05:54:45 -0700 (PDT)
Received: by 10.60.121.34 with HTTP; Fri, 2 Aug 2013 05:54:45 -0700 (PDT)
Delivered-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87172] Request to handle 'git mv' in Module::Rename
Return-Path: <jim.cochrane [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=lwMziJogPvF7i6pHw4Ia35WbJK0JBw6TQWLIvpnaEuY=; b=vZAYzRXLIJ1IJForLk41ELIzZLgFC44sDbK2I7DVS+JPPu8LcTgKBnBIqW45QhCP2+ rlsIjjagCNA50jDuZZWc3BSCgo7pP/bcY/XMl1MGKoFEHMnnCybRs/YdXk037NLWTt0Z +qZR4eRSryc06cPtYDvIO3aO+C3GjQ5u4bcgzChaEw1Wtev4yxYT9I0zZtZWxs2Gk+yT TI/3L74MTWxmXwMz3OBJY/hm2UUHDJwNHN92/JWswQRYJYBlg+Bc0T+l3XWlEwZ/xcZ9 nM7l9JVoPu9F+LpdbRr3KXJbkGjOkkJFHRN9ZykY7ZkbleFL8dBXUYPkhz95rm8e9Fbs jnAw==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
X-RT-Mail-Extension: module-rename
Date: Fri, 2 Aug 2013 07:54:45 -0500
X-Spam-Level:
To: bug-Module-Rename [...] rt.cpan.org
From: Jim Cochrane <jim.cochrane [...] gmail.com>
RT-Message-ID: <rt-4.0.16-4144-1375448099-240.87172-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 2927
Download (untitled) / with headers
text/plain 2.8k
Hi Michael. I've not heard back and I'm not sure if my last message got to you - I included an attachment and I suspect the message may have been discarded because your mail server does not allow attachments. So I'm sending the same message again (below) minus the attachment. Let me know if you want me to send you the file I tried to attach (tar file with evidence of the bug) by some other means. Also, here is a listing of the *.pm files in the tar file I sent, from which I think the problem is evident: ./renamed_without_bug/lib/NowOrLater/Core/Tasks/TaskState.pm ./renamed_without_bug/lib/NowOrLater/Core/Tasks/Task.pm ./renamed_without_bug/lib/NowOrLater.pm ./renamed_with_bug/lib/NowOrLater/Core/Tasks/Task.pm ./renamed_with_bug/lib/NowOrLater/Core/Tasks/Tasks/TaskState.pm ./renamed_with_bug/lib/NowOrLater.pm ./orig/lib/NowOrLater/Core/TaskState.pm ./orig/lib/NowOrLater/Core/Task.pm ./orig/lib/NowOrLater.pm Evidence of the bug shows up in the listing: ./renamed_with_bug/lib/NowOrLater/Core/Tasks/Tasks/TaskState.pm Without the bug, it should be: ./renamed_with_bug/lib/NowOrLater/Core/Tasks/TaskState.pm Two rename commands were run: module-rename -g NowOrLater::Core::TaskState NowOrLater::Core::Tasks::TaskState lib/ module-rename -g NowOrLater::Core::Task NowOrLater::Core::Tasks::Task lib/ As always, let me know if you have further questions. Thanks! On Wed, Jul 31, 2013 at 4:13 PM, Jim Cochrane <jim.cochrane@gmail.com>wrote: Show quoted text
> The content is OK; the file/directory names are what get messed up. I > think what happens is that the first search - for file names that match the > old pattern - finds more than it should; but when \b is applied in > file_process, no overly-optimistic matches are found, so the bug does not > occur when changing file contents. But the bug does occur when figuring > out what 'git mv' commands (and, probably, when -g is not specified, what > 'mv' commands) to generate. > > I'm attaching a small example, with original git repo, cloned repo with > buggy version applied, and cloned repo with non-buggy version (my fix) > applied, which I think gives a simple demo of the problem. Let me know if > anything's unclear or you have questions. > > If the mail server we're using doesn't allow attachments, please let me > know the best way to get this tar file to you. > > Thanks. > > > > On Wed, Jul 31, 2013 at 1:22 AM, Michael_Schilli via RT < > bug-Module-Rename@rt.cpan.org> wrote: >
>> <URL: https://rt.cpan.org/Ticket/Display.html?id=87172 > >> >> On Tue Jul 30 16:56:01 2013, jim.cochrane@gmail.com wrote:
>> > determine which modules to rename - a partial match is accepted, so >> > that, >> > for example, module-rename Bar::Foo Bar::Boo would >> > consider Bar::Food
>> >> Interesting, are you referring to file names or file content? If the >> latter, it seems that >> >> s/($self->{name_old})\b... >> >> should take care of it, no? >> >> >>
>
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 4692
MIME-Version: 1.0
In-Reply-To: <rt-4.0.16-4144-1375448099-240.87172-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <CACgAm3_Rdn-ZjooU16j8Y2w=oCQShNjk3+8su8ZpxtwMNzNsZw [...] mail.gmail.com> <rt-4.0.16-4144-1375448099-240.87172-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.16-14276-1376191894-264.87172-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 605
Download (untitled) / with headers
text/plain 605b
Hi Jim, sorry again for the delay. I only work on my modules in my spare time, and there's been very little of that lately :). I've looked over your patch, but I think the \b...\b regex might actually trigger some other bugs (and the test suite broke with it in my env), so I went ahead and created a test case for the bug you reported: https://github.com/mschilli/module-rename-perl/commit/4b3d1c1801036afe49ca4dff4ab67a27b8559298 And a fix for it: https://github.com/mschilli/module-rename-perl/commit/b6a7d38daa6f5187e540c7baaec022843003fd22 Let me know if that works for you as well! -- Mike
From jim.cochrane [...] gmail.com Mon Aug 19 03: 44:09 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.276 tagged_above=-99.9 required=10 tests=[AWL=0.057, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-4.0.16-14276-1376191895-1578.87172-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-87172 [...] rt.cpan.org> <CACgAm3_Rdn-ZjooU16j8Y2w=oCQShNjk3+8su8ZpxtwMNzNsZw [...] mail.gmail.com> <rt-4.0.16-4144-1375448099-240.87172-6-0 [...] rt.cpan.org> <rt-4.0.16-14276-1376191895-1578.87172-6-0 [...] rt.cpan.org>
X-Virus-Checked: Checked
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.182.81.41 with SMTP id w9mr11743493obx.18.1376898232453; Mon, 19 Aug 2013 00:43:52 -0700 (PDT)
Message-ID: <CACgAm38m-Zt8pTn8h_2wtoVJbJbZSP2MFFO7hrek-NsE4rJ0Yw [...] mail.gmail.com>
Content-Type: multipart/mixed; boundary="047d7b2e4d7c09912504e4481a98"
X-Spam-Score: -6.276
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 5BBBD2405DF for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Mon, 19 Aug 2013 03:44:09 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pTLBpHZO+ki8 for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Mon, 19 Aug 2013 03:44:04 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 8AF8724047E for <bug-Module-Rename [...] rt.cpan.org>; Mon, 19 Aug 2013 03:44:04 -0400 (EDT)
Received: (qmail 8258 invoked by alias); 19 Aug 2013 07:44:04 -0000
Received: from mail-ob0-f180.google.com (HELO mail-ob0-f180.google.com) (209.85.214.180) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 19 Aug 2013 00:43:56 -0700
Received: by mail-ob0-f180.google.com with SMTP id up14so4726738obb.25 for <bug-Module-Rename [...] rt.cpan.org>; Mon, 19 Aug 2013 00:43:52 -0700 (PDT)
Received: by 10.60.121.34 with HTTP; Mon, 19 Aug 2013 00:43:52 -0700 (PDT)
Delivered-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87172] Request to handle 'git mv' in Module::Rename
Return-Path: <jim.cochrane [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=hzAIG496XSYpCGBxqp2n1nIV3GGDV405NoqLx5hzf+4=; b=PXNXAk3sNYbDWYtCl8aiX948QASAyTqRGIC9+qneefZb2LT+cx11f0W+XP/PYw6AHG qOYeyNUaqHD9AELrpig/tLhViZ/HbRthNpwIjpJWCEmM1QBufrBBT1HQyDiL5v8HNAlN 0FX/dD5aK3vUv1ciMmKLSkMnRg7ePsBRWV9mxMhQZuiZWcpEOiHGBSek4GFyL3tpuySb 0hFp0sAm3pcz1HQp8y084IQHCth8Cl3rH6OQYLe4MEXiXKSnByIV8vleZ5TwOzR2Jcxd gwFAhSPp7kYssVGrVfXli57siDJZfdZSMG+/OeYE++oMuMb2eXBjglfMEvsS8pT85fXv tR8g==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
X-RT-Mail-Extension: module-rename
Date: Mon, 19 Aug 2013 02:43:52 -0500
X-Spam-Level:
To: bug-Module-Rename [...] rt.cpan.org
From: Jim Cochrane <jim.cochrane [...] gmail.com>
RT-Message-ID: <rt-4.0.16-32054-1376898250-1839.87172-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: multipart/alternative; boundary="047d7b2e4d7c09912104e4481a96"
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 2148
Hi Mike. No problem with the delay - I had assumed you were busy with your day job that you actually get paid for. :-) Thanks for the fix and notification - and apologies for responding so late. It took me a while, but I finally got around to testing the new version and I found a couple fairly minor (but still important, IMO) problems. I think the basic logic of your changes is fine, but: - You appear to be missing 'use Cwd;' in Rename.pm (causes undefined subroutine error [getcwd] for my test). - The line 'INFO "mv $file $newfile"' causes a redundant report when the trial_run option is enabled, and with -g, the report of 'mv xxx yyy' and 'git mv xxx yyy' can cause confusion for the user (e.g., "What? It would have both done a 'mv' and a 'git mv' - that's no good!). (I think that line wasn't triggered before, but I think your change of 'level' to INFO put it back in. That's fine, I think, but I think this line should not be invoked when -t is used. And to be really picky, with -g [no -t], perhaps the output should be "git mv xxx yyy".) I'll attach a patch with my suggested fixes for this. Also, a couple even more minor issues (but I'm hoping they can be addressed if it's practical to do so): - commands ('mv' and 'git mv') are output to stderr, but diffs are output to stdout. (Can cause problems when redirecting output to a file - and if >2&1 is used, you might get other, unwanted, error messages in the file.) - The output "tapping git mv File1.pm A/B/File1.pm (skipped - dry run)" is more verbose than necessary, IMO. Better would be: git mv File1.pm A/B/File1.pm Since the user knows he typed module-rename -t ..., he knows it's a trial (dry) run and doesn't need to be told that; and "tapping" refers to the implementation, which the user doesn't care about. I suspect there might not a practical way to make this change with Sysadm::Install, so I'll leave it up to you whether this is doable. I have a little more testing to do - I'll let you know if I uncover anything else. Thanks! Jim On Sat, Aug 10, 2013 at 10:31 PM, Michael_Schilli via RT < bug-Module-Rename@rt.cpan.org> wrote: Show quoted text
> ...
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 3003
Content-Type: application/octet-stream; name="renpatch"
X-Attachment-ID: f_hkjdggr60
Content-Disposition: attachment; filename="renpatch"
Content-Transfer-Encoding: base64
Content-Length: 694
Download renpatch
application/octet-stream 694b

Message body not shown because it is not plain text.

MIME-Version: 1.0
In-Reply-To: <rt-4.0.16-32054-1376898250-1839.87172-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-87172 [...] rt.cpan.org> <CACgAm3_Rdn-ZjooU16j8Y2w=oCQShNjk3+8su8ZpxtwMNzNsZw [...] mail.gmail.com> <rt-4.0.16-4144-1375448099-240.87172-6-0 [...] rt.cpan.org> <rt-4.0.16-14276-1376191895-1578.87172-6-0 [...] rt.cpan.org> <CACgAm38m-Zt8pTn8h_2wtoVJbJbZSP2MFFO7hrek-NsE4rJ0Yw [...] mail.gmail.com> <rt-4.0.16-32054-1376898250-1839.87172-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.16-26166-1376967519-1806.87172-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1266
Download (untitled) / with headers
text/plain 1.2k
On Mon Aug 19 03:44:10 2013, jim.cochrane@gmail.com wrote: Show quoted text
> - You appear to be missing 'use Cwd;' in Rename.pm (causes undefined > subroutine error [getcwd] for my test).
Good catch, I've added a test case for that. Show quoted text
> - The line 'INFO "mv $file $newfile"' causes a redundant report
Yep, but I think we should just delete it entirely, because in case of a real run, Sysadm::Install's mv() is going to do the logging. Show quoted text
> - commands ('mv' and 'git mv') are output to stderr, but diffs are > output to stdout.
Yep, I've changed the print commands to Log4perl statements, now everything goes to STDERR (or STDOUT, whatever you configure via Log4perl). Show quoted text
> - The output "tapping git mv File1.pm A/B/File1.pm (skipped - dry run)" > is more verbose than necessary, IMO. Better would be: > git mv File1.pm A/B/File1.pm > Since the user knows he typed module-rename -t
Actually, I like the extra confirmation. I know I typed -t, but do I know that the script is doing the right thing? The "skipped" message lets me sleep calmly at night :). Here's (hopefully) all of the above: https://github.com/mschilli/module-rename-perl/commit/a04a0e7e394f38b6c8529a09bcaa35ddc8a46e97 Would be great if you could run your tests on it one more time, thanks! -- Mike
From jim.cochrane [...] gmail.com Mon Aug 19 23: 09:23 2013
MIME-Version: 1.0
X-Spam-Status: No, score=-6.285 tagged_above=-99.9 required=10 tests=[AWL=0.049, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-4.0.16-26166-1376967520-166.87172-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-87172 [...] rt.cpan.org> <CACgAm3_Rdn-ZjooU16j8Y2w=oCQShNjk3+8su8ZpxtwMNzNsZw [...] mail.gmail.com> <rt-4.0.16-4144-1375448099-240.87172-6-0 [...] rt.cpan.org> <rt-4.0.16-14276-1376191895-1578.87172-6-0 [...] rt.cpan.org> <CACgAm38m-Zt8pTn8h_2wtoVJbJbZSP2MFFO7hrek-NsE4rJ0Yw [...] mail.gmail.com> <rt-4.0.16-32054-1376898250-1839.87172-6-0 [...] rt.cpan.org> <rt-4.0.16-26166-1376967520-166.87172-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.60.96.169 with SMTP id dt9mr16160804oeb.27.1376968150336; Mon, 19 Aug 2013 20:09:10 -0700 (PDT)
Message-ID: <CACgAm3_zqAbj3vUOEwPDMev_fpurs1ZEv_qQJRQsDAyQvbf+zQ [...] mail.gmail.com>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.285
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 2A9CD2410B5 for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Mon, 19 Aug 2013 23:09:23 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q+rTlWd8Yqma for <cpan-bug+Module-Rename [...] hipster.bestpractical.com>; Mon, 19 Aug 2013 23:09:21 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 8145624065F for <bug-Module-Rename [...] rt.cpan.org>; Mon, 19 Aug 2013 23:09:21 -0400 (EDT)
Received: (qmail 1621 invoked by alias); 20 Aug 2013 03:09:20 -0000
Received: from mail-ob0-f171.google.com (HELO mail-ob0-f171.google.com) (209.85.214.171) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 19 Aug 2013 20:09:14 -0700
Received: by mail-ob0-f171.google.com with SMTP id tb18so6481036obb.16 for <bug-Module-Rename [...] rt.cpan.org>; Mon, 19 Aug 2013 20:09:10 -0700 (PDT)
Received: by 10.60.67.35 with HTTP; Mon, 19 Aug 2013 20:09:10 -0700 (PDT)
Delivered-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #87172] Request to handle 'git mv' in Module::Rename
Return-Path: <jim.cochrane [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Ja/vaUVRHWwd0hy+l7X/PG9h94fGXKcc0ooBbMxWwoY=; b=af/5Bc9gbMLFzsDMDy/i3QqQWaA8XHHDumT4KgbR01Wh2umhdUoHOfItKHKvVgWJN5 zktqTe0I8YtUDTVyouySG7c7+ISyl0mAQ9x23j6YbgwaPAJK6rPX60g0nN6OsLK/Q7Ki JjMSeAmbzdFwsQNxjlq4gOq47rs5B4pp5w+k2osB5xL9X4MVTyclNp4mcCC6Y7yr5ekQ kHD89x9Z8k1OaiMeXLqAzBa2/Xoa7DNSCxd3Pgh9bJXTE8j1V5M+KnMW9RcJFpBeOlz4 ONnFuEu0YEmtMbr9ZuZ1it206ly7RfvLi2Pa1OC1GRU6gxHz+Wy+ordofFU8ZWGd7hcH cKxA==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Module-Rename [...] hipster.bestpractical.com
X-RT-Mail-Extension: module-rename
Date: Mon, 19 Aug 2013 22:09:10 -0500
X-Spam-Level:
To: bug-Module-Rename [...] rt.cpan.org
From: Jim Cochrane <jim.cochrane [...] gmail.com>
RT-Message-ID: <rt-4.0.16-5844-1376968163-1162.87172-0-0 [...] rt.cpan.org>
Content-Length: 1606
Download (untitled) / with headers
text/plain 1.5k
On Mon, Aug 19, 2013 at 9:58 PM, Michael_Schilli via RT <bug-Module-Rename@rt.cpan.org> wrote: Show quoted text
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=87172 > > > On Mon Aug 19 03:44:10 2013, jim.cochrane@gmail.com wrote: >
> > - You appear to be missing 'use Cwd;' in Rename.pm (causes undefined > > subroutine error [getcwd] for my test).
> > Good catch, I've added a test case for that. >
> > - The line 'INFO "mv $file $newfile"' causes a redundant report
> > Yep, but I think we should just delete it entirely, because in case of a real run, Sysadm::Install's mv() is going to do the logging.
That's fine with me. Show quoted text
> >
> > - commands ('mv' and 'git mv') are output to stderr, but diffs are > > output to stdout.
> > Yep, I've changed the print commands to Log4perl statements, now everything goes to STDERR (or STDOUT, whatever you configure via Log4perl). >
Good. Thanks. Show quoted text
>
> > - The output "tapping git mv File1.pm A/B/File1.pm (skipped - dry run)" > > is more verbose than necessary, IMO. Better would be: > > git mv File1.pm A/B/File1.pm > > Since the user knows he typed module-rename -t
> > Actually, I like the extra confirmation. I know I typed -t, but do I know that the script is doing the right thing? The "skipped" message lets me sleep calmly at night :). >
OK, I'll accept that. Show quoted text
> > Here's (hopefully) all of the above: > > https://github.com/mschilli/module-rename-perl/commit/a04a0e7e394f38b6c8529a09bcaa35ddc8a46e97 > > Would be great if you could run your tests on it one more time, thanks! > > -- Mike
I'll try to get to it tonight and let you know the result. Jim


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.